Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit a5a2a0c7fa039c59619bc908b3b1ed24734d442a

Authored by Darren Hart
Committed by Thomas Gleixner
1 parent d2de688891
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

futex: fix futex_wait_setup key handling 

If the get_futex_key() call were to fail, the existing code would
try and put_futex_key() prior to returning.  This patch makes sure
we only put_futex_key() if get_futex_key() succeeded.

Reported-by: Clark Williams <williams@redhat.com>
Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
LKML-Reference: <20090410165005.14342.16973.stgit@Aeon>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -1668,7 +1668,7 @@
1668 1668 q->key = FUTEX_KEY_INIT;
1669 1669 ret = get_futex_key(uaddr, fshared, &q->key);
1670 1670 if (unlikely(ret != 0))
1671   - goto out;
  1671 + return ret;
1672 1672  
1673 1673 retry_private:
1674 1674 *hb = queue_lock(q);