Commit aeb35ebc5f54bcdd7163f5282a3f39bc48c75cae

Authored by Julia Lawall
Committed by Mauro Carvalho Chehab
1 parent da4b7b2011

[media] imon: Correct call to input_free_device

ictx->touch is intialied in imon_init_intf1, to the result of calling the
function that contains this code.  Thus, in this code, input_free_device
should be called on touch itself.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression struct input_dev * x;
expression ra,rr;
position p1,p2;
@@

x = input_allocate_device@p1(...)
...  when != x = rr
    when != input_free_device(x,...)
    when != if (...) { ... input_free_device(x,...) ...}
if(...) { ... when != x = ra
    when forall
    when != input_free_device(x,...)
\(return <+...x...+>; \| return@p2...; \) }

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

cocci.print_main("input_allocate_device",p1)
cocci.print_secs("input_free_device",p2)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/media/rc/imon.c
... ... @@ -1970,7 +1970,7 @@
1970 1970 return touch;
1971 1971  
1972 1972 touch_register_failed:
1973   - input_free_device(ictx->touch);
  1973 + input_free_device(touch);
1974 1974  
1975 1975 touch_alloc_failed:
1976 1976 return NULL;