Eric Lee / linux-smarc-t335x-v3.2

Commit b09d2501ed3d294619cbfbcf828ad39324d0e548

Authored by H. Peter Anvin 2009-04-02 08:21:56 +0800

Committed by Ingo Molnar 2009-04-06 15:30:27 +0800

Exists in master and in 4 other branches

mutex: drop "inline" from mutex_lock() inside kernel/mutex.c

Impact: build fix

mutex_lock() is was defined inline in kernel/mutex.c, but wasn't
declared so not in <linux/mutex.h>.  This didn't cause a problem until
checkin 3a2d367d9aabac486ac4444c6c7ec7a1dab16267 added the
atomic_dec_and_mutex_lock() inline in between declaration and
definion.

This broke building with CONFIG_ALLOW_WARNINGS=n, e.g. make
allnoconfig.

Either from the source code nor the allnoconfig binary output I cannot
find any internal references to mutex_lock() in kernel/mutex.c, so
presumably this "inline" is now-useless legacy.

Cc: Eric Paris <eparis@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Orig-LKML-Reference: <tip-3a2d367d9aabac486ac4444c6c7ec7a1dab16267@git.kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

kernel/mutex.c

kernel/mutex.c

Diff comments View file @ b09d250

...	...	@@ -89,7 +89,7 @@
89	89	*
90	90	* This function is similar to (but not equivalent to) down().
91	91	*/
92		-void inline __sched mutex_lock(struct mutex *lock)
	92	+void __sched mutex_lock(struct mutex *lock)
93	93	{
94	94	might_sleep();
95	95	/*