Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit bb86a7338b7a864c03e1736a8d370b10254b0300

Authored by Alex Chiang
Committed by Linus Torvalds
1 parent 9fdcd886ab
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

page-types: exit early when invoked with -d|--describe 

On a system with large amount of memory (256GB), invoking page-types can
take quite a long time, which is unreasonable considering the user only
wants a description of the flags:

	# time ./page-types -d 0x10
	0x0000000000000010	____D_____________________________	dirty

	real	0m34.285s
	user	0m1.966s
	sys	0m32.313s

This is because we still walk the entire address range.

Exiting early seems like a reasonble solution:

# time ./page-types -d 0x10
	0x0000000000000010	____D_____________________________	dirty

	real	0m0.007s
	user	0m0.001s
	sys	0m0.005s

Signed-off-by: Alex Chiang <achiang@hp.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Haicheng Li <haicheng.li@intel.com>
Acked-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 2 deletions Side-by-side Diff

Documentation/vm/page-types.c
Diff comments   View file @ bb86a73
... ... @@ -940,9 +940,8 @@
940 940 parse_bits_mask(optarg);
941 941 break;
942 942 case 'd':
943   - opt_no_summary = 1;
944 943 describe_flags(optarg);
945   - break;
  944 + exit(0);
946 945 case 'l':
947 946 opt_list = 1;
948 947 break;