Commit c18c821fd40ad0ffc199a55be874e556bf999416

Authored by Boaz Harrosh
Committed by J. Bruce Fields
1 parent 774f8bbd9e

nfsd41: Fix a crash when a callback is retried

If a callback is retried at nfsd4_cb_recall_done() due to
some error, the returned rpc reply crashes here:

@@ -514,6 +514,7 @@ decode_cb_sequence(struct xdr_stream *xdr, struct nfsd4_cb_sequence *res,
 	u32 dummy;
 	__be32 *p;

 +	BUG_ON(!res);
 	if (res->cbs_minorversion == 0)
 		return 0;

[BUG_ON added for demonstration]

This is because the nfsd4_cb_done_sequence() has NULLed out
the task->tk_msg.rpc_resp pointer.

Also eventually the rpc would use the new slot without making
sure it is free by calling nfsd41_cb_setup_sequence().

This problem was introduced by a 4.1 protocol addition patch:
	[0421b5c5] nfsd41: Backchannel: Implement cb_recall over NFSv4.1

Which was overlooking the possibility of an RPC callback retries.
For not-4.1 case redoing the _prepare is harmless.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

fs/nfsd/nfs4callback.c
... ... @@ -697,7 +697,7 @@
697 697 if (dp->dl_retries--) {
698 698 rpc_delay(task, 2*HZ);
699 699 task->tk_status = 0;
700   - rpc_restart_call(task);
  700 + rpc_restart_call_prepare(task);
701 701 return;
702 702 } else {
703 703 atomic_set(&clp->cl_cb_set, 0);