Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit cfca31ce789963c0dd6ca2e9cc13b90cc2802fbd

Authored by Julia Lawall
Committed by Wim Van Sebroeck
1 parent 386f40c86d
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

[PATCH 2/11] drivers/watchdog: Eliminate a NULL pointer dereference 

At the point of the call to dev_err, wm8350 is NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/watchdog/wm8350_wdt.c
Diff comments   View file @ cfca31c
... ... @@ -284,7 +284,7 @@
284 284 struct wm8350 *wm8350 = platform_get_drvdata(pdev);
285 285  
286 286 if (!wm8350) {
287   - dev_err(wm8350->dev, "No driver data supplied\n");
  287 + pr_err("No driver data supplied\n");
288 288 return -ENODEV;
289 289 }
290 290