Commit f04e2be7d9b73a1da7be99a08b3695074e14970c

Authored by Larry Finger
Committed by Jeff Garzik
1 parent 3470cb1d4f

[PATCH] bcm43xx: output proper link quality with scans

The bcm43xx-softmac driver fails to set two quantities needed for
iwlist to compute wireless quality when scanning. As a result, userland
programs using the quality to determine the best connection fail.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

Showing 3 changed files with 5 additions and 3 deletions Side-by-side Diff

drivers/net/wireless/bcm43xx/bcm43xx.h
... ... @@ -365,6 +365,9 @@
365 365 #define BCM43xx_DEFAULT_SHORT_RETRY_LIMIT 7
366 366 #define BCM43xx_DEFAULT_LONG_RETRY_LIMIT 4
367 367  
  368 +/* FIXME: the next line is a guess as to what the maximum RSSI value might be */
  369 +#define RX_RSSI_MAX 60
  370 +
368 371 /* Max size of a security key */
369 372 #define BCM43xx_SEC_KEYSIZE 16
370 373 /* Security algorithms. */
drivers/net/wireless/bcm43xx/bcm43xx_main.c
... ... @@ -3688,6 +3688,8 @@
3688 3688 phy_type);
3689 3689 return -ENODEV;
3690 3690 };
  3691 + bcm->ieee->perfect_rssi = RX_RSSI_MAX;
  3692 + bcm->ieee->worst_rssi = 0;
3691 3693 if (!phy_rev_ok) {
3692 3694 printk(KERN_WARNING PFX "Invalid PHY Revision %x\n",
3693 3695 phy_rev);
drivers/net/wireless/bcm43xx/bcm43xx_wx.c
... ... @@ -47,9 +47,6 @@
47 47 #define BCM43xx_WX_VERSION 18
48 48  
49 49 #define MAX_WX_STRING 80
50   -/* FIXME: the next line is a guess as to what the maximum RSSI value might be */
51   -#define RX_RSSI_MAX 60
52   -
53 50  
54 51 static int bcm43xx_wx_get_name(struct net_device *net_dev,
55 52 struct iw_request_info *info,