09 Aug, 2010
1 commit
-
This fixes a warning ("comparison of distinct pointer types lacks a
cast") introduced by the commit
040f6b4f14adb2ca5babb84e9fb2ebc6661e0be2 ("tx493xide: use ->pio_mode
value to determine pair device speed").Signed-off-by: Atsushi Nemoto
Signed-off-by: David S. Miller
19 Jan, 2010
2 commits
-
Use the current PIO mode value instead of the physical maximum one
of the pair device on the port to determine PIO commmand timings used
for both devices on the port.Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller -
Change ->set_pio_mode method parameters to match ->set_piomode method
used in struct ata_port_operations.Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller
24 Nov, 2009
1 commit
-
Use resource_size() for devm_request_mem_region.
Signed-off-by: H Hartley Sweeten
Signed-off-by: David S. Miller
18 May, 2009
2 commits
-
Remove hw_regs_t typedef and rename struct hw_regs_s to struct ide_hw.
There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Pass number of ports to ide_host_{alloc,add}() and then update
all users accordingly.v2:
- drop no longer needed NULL initializers in buddha.c, cmd640.c and gayle.c
(noticed by Sergei)There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
08 Apr, 2009
1 commit
-
Now tx493[89]ide_tf_{load,read} do not contain word I/O operations.
They are endian-free now.Signed-off-by: Atsushi Nemoto
Cc: Sergei Shtylyov ,
Signed-off-by: Bartlomiej Zolnierkiewicz
01 Apr, 2009
6 commits
-
Turn selectproc() method into dev_select() method by teaching it to write to the
device register and moving it from 'struct ide_port_ops' to 'struct ide_tp_ops'.Signed-off-by: Sergei Shtylyov
Cc: benh@kernel.crashing.org
Cc: petkovbb@gmail.com
[bart: add ->dev_select to at91_ide.c and tx4939.c (__BIG_ENDIAN case)]
Signed-off-by: Bartlomiej Zolnierkiewicz -
Move IDE_FTFLAG_{IN|OUT}_DATA flag handling out of tf_{read|load}() methods
into the only two functions where these flags actually need to be handled:
do_rw_taskfile() and ide_complete_cmd()...Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Handle IDE_FTFLAG_{IN|OUT}_DATA flags in tf_{read|load}() methods by calling
{in|out}put_data() methods to transfer 2 bytes -- this will allow us to move
that handling out of those methods altogether...Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
The feature register has never been readable -- when its location is read, one
gets the error register value; hence rename IDE_TFLAG_IN_[HOB_]FEATURE into
IDE_TFLAG_IN_[HOB_]ERROR and introduce the 'hob_error' field into the 'struct
ide_taskfile' (despite the error register not really depending on the HOB bit).Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Turn set_irq() method with its software reset hack into write_devctl() method
(for just writing a value into the device control register) at last...Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Make use of ATA_HOB instead of hard-coded value in the tf_read() method.
Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
27 Mar, 2009
4 commits
-
* Add IDE_TFLAG_FS taskfile flag and set it for REQ_TYPE_FS requests.
* Convert ->{in,out}put_data methods to take command instead of request
as an argument. Then convert pre_task_out_intr(), task_end_request(),
task_error(), task_in_unexpected(), ide_pio_sector(), ide_pio_multi()
and ide_pio_datablock() in similar way.* Rename task_end_request() to ide_finish_cmd().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
While at it:
- rename struct ide_task_s to struct ide_cmd
- remove stale comments from idedisk_{read_native,set}_max_address()
- drop unused 'cmd' argument from ide_{cmd,task}_ioctl()
- drop unused 'task' argument from tx4939ide_tf_load_fixup()
- rename ide_complete_task() to ide_complete_cmd()
- use consistent naming for struct ide_cmd variablesThere should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
* Add ->ftf_flags field to struct ide_taskfile
and convert flags for TASKFILE ioctl to use it.* Rename "flagged" taskfile flags:
- IDE_TFLAG_FLAGGED -> IDE_FTFLAG_FLAGGED
- IDE_TFLAG_FLAGGED_SET_IN_FLAGS -> IDE_FTFLAG_SET_IN_FLAGS
- IDE_TFLAG_{OUT,IN}_DATA -> IDE_FTFLAG_{OUT,IN}_DATAv2:
* Remember to fully update ide-h8300.c, scc_pata.c and tx493{8,9}ide.c
(thanks to Stephen Rothwell for noticing).There should be no functional changes caused by this patch.
Cc: Stephen Rothwell
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Signed-off-by: Bartlomiej Zolnierkiewicz
15 Jan, 2009
1 commit
-
Signed-off-by: Atsushi Nemoto
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
02 Jan, 2009
2 commits
-
* Set chipset type explicitly in tx4938ide and tx4939ide host drivers
(all other host drivers were updated already).* Remove no longer used chipset type fixup from ide_host_register().
Acked-by: Atsushi Nemoto
Cc: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Trivial CodingStyle fixup for tx4938ide and tx4939ide drivers.
Acked-by: Atsushi Nemoto
Acked-by: Sergei Shtyltov
Signed-off-by: Bartlomiej Zolnierkiewicz
30 Dec, 2008
1 commit
-
This fixes data corruption on PIO mode.
Signed-off-by: Atsushi Nemoto
Cc: stable
Cc: sshtylyov@ru.mvista.com
Signed-off-by: Bartlomiej Zolnierkiewicz
03 Nov, 2008
3 commits
-
Make 'wt' variable signed while it can be negative during calculation.
Suggested-by: Sergei Shtylyov
Signed-off-by: Atsushi Nemoto
Cc: sshtylyov@ru.mvista.com
Signed-off-by: Bartlomiej Zolnierkiewicz -
Call devm_ioremap() for CS0 and CS1 separetely.
And some style cleanups.Suggested-by: Sergei Shtylyov
Signed-off-by: Atsushi Nemoto
Cc: ralf@linux-mips.org
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
SHWT value is used as address valid to -CSx assertion and -CSx to -DIOx
assertion setup time, and contrarywise, -DIOx to -CSx release and -CSx
release to address invalid hold time, so it actualy applies 4 times and
so constitutes -DIOx recovery time. Check requirement of the recovery
time and cycle time. Also check SHWT maximum value.Suggested-by: Sergei Shtylyov
Signed-off-by: Atsushi Nemoto
Cc: ralf@linux-mips.org
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
24 Oct, 2008
1 commit
-
This is the driver for the Toshiba TX4938 SoC EBUS controller ATA mode.
It has custom set_pio_mode and some hacks for big endian.Signed-off-by: Atsushi Nemoto
Cc: ralf@linux-mips.org
Cc: sshtylyov@ru.mvista.com
Signed-off-by: Bartlomiej Zolnierkiewicz