Eric Lee / linux-smarc-t335x-v3.2

28 Jul, 2010

1 commit

12 Apr, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

03 Mar, 2010

1 commit

  • 6c71dcb28   [SCSI] scsi_dh_emc: fix mode select request setup ... Browse Code »

    This patch fixes the request setup code for mode selects. I got the fixes from
    Hannes Reinecke while trying to hunt down some problems and merged it
    into one patch. I am sending it because Hannes is busy with other things.

    The patch fixes:
    - setting of the length for mode selects.
    - setting of the data direction for mode select 10.

    Signed-off-by: Hannes Reinecke
    Signed-off-by: Mike Christie
    Signed-off-by: James Bottomley

    Hannes Reinecke
     

20 Feb, 2010

2 commits

10 Dec, 2009

1 commit

05 Dec, 2009

5 commits

02 Oct, 2009

1 commit

12 Sep, 2009

4 commits

05 Sep, 2009

1 commit

23 Aug, 2009

5 commits

  • 4dbfb544a   [SCSI] scsi_dh: add two SUN devices to the list of devices supported by default ... Browse Code »

    Reported-by: Rice Brown
    Signed-Off-by: Chandra Seetharaman
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     
  • 14d9cb5f7   [SCSI] scsi_dh: Provide set_params interface in emc device handler ... Browse Code »

    Handle the parameters provided by user thru multipath.

    This handler expects only 2 parameters and their value can either be 0 or 1.

    This code originates from the old dm-emc.c file. Appropriate changes have
    been made to make it work in the new design.

    Reported-by: Eddie Williams
    Signed-off-by: Chandra Seetharaman
    Tested-by: Eddie Williams
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     
  • 18ee70c9d   [SCSI] scsi_dh: add the interface scsi_dh_set_params() ... Browse Code »

    When we moved the device handler functionality from dm layer to SCSI layer
    we dropped the parameter functionality.

    This path adds an interface to scsi dh layer to set device handler
    parameters.

    Basically, multipath layer need to create a string with all the parameters
    and call scsi_dh_set_params() after it called scsi_dh_attach() on a
    device.

    If a device handler provides such an interface it will handle the parameters
    as it expects them.

    Reported-by: Eddie Williams
    Signed-off-by: Chandra Seetharaman
    Tested-by: Eddie Williams
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     
  • 3c0d1d94a   [SCSI] ALUA: send STPG if explicit and implicit is supported ... Browse Code »

    alua_activate only sends a STPG if only explicit is suppored.
    As a result, for EMC targets that support both we end up doing
    a implicit failover when X commands are finally sent to
    the other SP.

    This patch does a AND on the h->tpgs, so we do a explicit failover
    right away.

    Signed-off-by: Mike Christie
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Mike Christie
     
  • 6c10db72c   [SCSI] scsi_dh: Reference count scsi_dh_attach ... Browse Code »

    Problem reported: http://marc.info/?l=dm-devel&m=124585978305866&w=2

    scsi_dh does not do a refernce count for attach/detach, and this affects
    the way it is supposed to work with multipath when a device is not
    in the dev_list of the hardware handler.

    This patch adds a reference count that counts each attach.

    Signed-off-by: Chandra Seetharaman
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     

21 May, 2009

1 commit

18 Mar, 2009

1 commit

13 Mar, 2009

5 commits

30 Dec, 2008

3 commits

12 Dec, 2008

1 commit

  • febd7a5c1   Commands needing to be retried require a complete re-initialization. ... Browse Code »

    The test-unit-ready portion of this patch was causing boots to fail on
    my test machine (as in http://lkml.org/lkml/2008/12/5/161). With this
    patch in place, the system is booting reliably.

    Mike Anderson found the same problem in the hp_hw_start_stop code,
    and I applied the same solution in cdrom_read_cdda_bpc.

    Signed-off-by: Alan D. Brunelle
    Cc: Mike Anderson
    Signed-off-by: Jens Axboe

    Alan D. Brunelle
     

24 Oct, 2008

1 commit

13 Oct, 2008

2 commits

  • 64f84bc1c   [SCSI] scsi_dh_alua: remove REQ_NOMERGE ... Browse Code »

    We do not need to set REQ_NOMERGE because when the module calls
    blk_execute_rq -> blk_execute_rq_nowait, blk_execute_rq_nowait sets
    it for us. This brings all the modules in sync for those bits.

    Signed-off-by: Mike Christie
    Signed-off-by: James Bottomley

    Mike Christie
     
  • 6000a368c   [SCSI] block: separate failfast into multiple bits. ... Browse Code »

    Multipath is best at handling transport errors. If it gets a device
    error then there is not much the multipath layer can do. It will just
    access the same device but from a different path.

    This patch breaks up failfast into device, transport and driver errors.
    The multipath layers (md and dm mutlipath) only ask the lower levels to
    fast fail transport errors. The user of failfast, read ahead, will ask
    to fast fail on all errors.

    Note that blk_noretry_request will return true if any failfast bit
    is set. This allows drivers that do not support the multipath failfast
    bits to continue to fail on any failfast error like before. Drivers
    like scsi that are able to fail fast specific errors can check
    for the specific fail fast type. In the next patch I will convert
    scsi.

    Signed-off-by: Mike Christie
    Cc: Jens Axboe
    Signed-off-by: James Bottomley

    Mike Christie
     

04 Oct, 2008

3 commits