28 Jul, 2010

1 commit


18 May, 2010

1 commit


02 May, 2010

1 commit


01 May, 2010

1 commit


12 Apr, 2010

1 commit

  • While testing the midlevel q_at_head and q_at_tail
    patch for sg and the block SG_IO ioctl I found it
    useful to reduce the queuing within the scsi_debug
    driver. The reason is that the midlevel queue only
    comes into play when the corresponding LLD queue
    is full.

    It is also useful when testing to be confident that
    your program is the only thing issuing commands
    to the (virtual) scsi_debug device. The no_uld=1
    parameter will stop a scsi_debug virtual disk
    appearing as /dev/sd* .

    Changelog:
    - add max_queue parameter to reduce the number
    of queued commands the driver will accept.
    This parameter can be changed after the driver
    is loaded.
    - add no_uld parameter that restricts scsi_debug's
    virtual devices to the sg and bsg drivers
    - correct stale url

    Signed-off-by: Douglas Gilbert
    Signed-off-by: James Bottomley

    Douglas Gilbert
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

05 Dec, 2009

2 commits

  • While testing scsi_debug with these patches I found a
    problem with the Block Limits VPD page function. The
    length returned by the inquiry_evpd_b0() function was
    too short. A patch to fix that and a cosmetic change
    (that the form factor of scsi_debug is less than 1.8
    inches) is attached.

    Signed-off-by: Douglas Gilbert
    Signed-off-by: James Bottomley

    Douglas Gilbert
     
  • This version fixes 64-bit modulo on 32-bit as well as inadvertent map
    updates when TP was disabled.

    Implement support for thin provisioning in scsi_debug. No actual memory
    de-allocation is taking place. The intent is to emulate a thinly
    provisioned storage device, not to be one.

    There are four new module options:

    - unmap_granularity specifies the granularity at which to track mapped
    blocks (specified in number of logical blocks). 2048 (1 MB) is a
    realistic value for disk arrays although some may have a finer
    granularity.

    - unmap_alignment specifies the first LBA which is naturally aligned on
    an unmap_granularity boundary.

    - unmap_max_desc specifies the maximum number of ranges that can be
    unmapped using one UNMAP command. If this is 0, only WRITE SAME is
    supported and UNMAP will cause a check condition.

    - unmap_max_blocks specifies the maximum number of blocks that can be
    unmapped using a single UNMAP command. Default is 0xffffffff.

    These parameters are reported in the new and extended block limits VPD.

    If unmap_granularity is specified the device is tagged as thin
    provisioning capable in READ CAPACITY(16). A bitmap is allocated to
    track whether blocks are mapped or not. A WRITE request will cause a
    block to be mapped. So will WRITE SAME unless the UNMAP bit is set.

    Blocks can be unmapped using either WRITE SAME or UNMAP. No accounting
    is done to track partial blocks. This means that only whole blocks will
    be marked free. This is how the array people tell me their firmwares
    work.

    GET LBA STATUS is also supported. This command reports whether a block
    is mapped or not, and how long the adjoining mapped/unmapped extent is.

    The block allocation bitmap can also be viewed from user space via:

    /sys/bus/pseudo/drivers/scsi_debug/map

    Signed-off-by: Martin K. Petersen
    Acked-by: Douglas Gilbert
    Signed-off-by: James Bottomley

    Martin K. Petersen
     

02 Oct, 2009

1 commit

  • Add support for 32-byte READ/WRITE as well as DIF Type 2 protection.

    Reject protected 10/12/16 byte READ/WRITE commands when Type 2 is
    enabled.

    Verify Type 2 reference tag according to Expected Initial LBA in 32-byte
    CDB.

    Signed-off-by: Martin K. Petersen
    Acked-by: Douglas Gilbert
    Signed-off-by: James Bottomley

    Martin K. Petersen
     

22 Jun, 2009

1 commit


21 May, 2009

1 commit


13 Mar, 2009

1 commit

  • This patch adds support for DIX and DIF in scsi_debug. A separate
    buffer is allocated for the protection information.

    - The dix parameter indicates whether the controller supports DIX
    (protection information DMA)

    - The dif parameter indicates whether the simulated storage device
    supports DIF

    - The guard parameter switches between T10 CRC(0) and IP checksum(1)

    - The ato parameter indicates whether the application tag is owned by
    the disk(0) or the OS(1)

    - DIF and DIX errors can be triggered using the scsi_debug_opts mask

    Signed-off-by: Martin K. Petersen
    Acked-by: Douglas Gilbert
    Signed-off-by: James Bottomley

    Martin K. Petersen
     

03 Jan, 2009

1 commit


27 Jul, 2008

1 commit


12 Jul, 2008

2 commits


29 Apr, 2008

1 commit


08 Apr, 2008

18 commits


18 Feb, 2008

1 commit

  • scsi_debug does at several places:

    for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) {
    kaddr = (unsigned char *)
    kmap_atomic(sg_page(sg), KM_USER0);

    We cannot do something like that with the clustering enabled (or we
    can use scsi_kmap_atomic_sg).

    Signed-off-by: FUJITA Tomonori
    Acked-by: Douglas Gilbert
    Signed-off-by: James Bottomley

    FUJITA Tomonori
     

31 Jan, 2008

3 commits


12 Jan, 2008

1 commit