Eric Lee / linux-smarc-t335x-v3.2

17 Jul, 2008

1 commit

30 Apr, 2008

1 commit

05 Mar, 2008

2 commits

  • daa49ff50   ds1wm: report bus reset error ... Browse Code »

    The patch replaces dev_dbg() by dev_err(), so the user could actually see the
    error, instead of wondering why w1 doesn't work. The root cause of the bus
    reset error isn't yet debugged though, but this sometimes happens on iPaq
    H5555.

    And while I'm at it, some cosmetic cleanups also made (few lines were using
    spaces instead of tabs).

    Signed-off-by: Anton Vorontsov
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anton Vorontsov
     
  • fbc357df2   ds1wm: should check for IS_ERR(clk) instead of NULL ... Browse Code »

    On the error condition clk_get() returns ERR_PTR(..), so checking for NULL
    doesn't work. ds1wm module causes a kernel oops when ds1wm clock isn't
    registered.

    This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
    for the return code.

    Signed-off-by: Anton Vorontsov
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anton Vorontsov
     

08 Feb, 2008

1 commit

  • 4aa323bd8   DS1WM: decouple host IRQ and INTR active state settings ... Browse Code »

    The DS1WM driver incorrectly infers the IAS bit (1-wire interrupt active
    high) from IRQ settings. There are devices that have IAS=0 but still need
    the IRQ to trigger on a rising edge. With this patch, machines with DS1WM
    that need IAS=1 have to set .active_high=1 in the ds1wm_platform_data.

    Signed-off-by: Philipp Zabel
    Acked-by: Evgeniy Polyakov
    Acked-by: Matt Reimer
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Philipp Zabel
     

07 Feb, 2008

3 commits

  • ad8dc96e3   w1-gpio: add GPIO w1 bus master driver ... Browse Code »

    Add a GPIO 1-wire bus master driver. The driver used the GPIO API to
    control the wire and the GPIO pin can be specified using platform data
    similar to i2c-gpio. The driver was tested with AT91SAM9260 + DS2401.

    Signed-off-by: Ville Syrjala
    Cc: Evgeniy Polyakov
    Cc: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ville Syrjala
     
  • 7129b126c   W1: w1_therm.c standardize units to millidegrees C ... Browse Code »

    Standardize the temperature units to millidegrees C for the two sensor
    conversion routines. Previously the routines were,

    w1_DS18B20_convert_temp degrees C
    w1_DS18S20_convert_temp millidegrees C

    Unfortunately this will break any program using the ds18b20 value as it
    will now be 1000 times bigger. Fortunately there can't be that many users
    out there, or some of these bugs will have been fixed by now, such as the
    negative C error (see previous patch) that makes me think the ds18b20 is
    the better choice to change because of the current bugs.

    Signed-off-by: David Fries
    Cc: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Fries
     
  • 18a2354db   w1: remove unused and confusing variable. ... Browse Code »

    Remvoe variable which actually is not used (except assigning it a value)
    and confusing break out of the family checking loop. Found by Harry Mason.

    Signed-off-by: Evgeniy Polyakov
    Cc: Harry J Mason
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Evgeniy Polyakov
     

28 Jan, 2008

1 commit

23 Jan, 2008

2 commits

  • 80c002ddd   W1: w1_therm.c is flagging 0C etc as invalid ... Browse Code »

    The extra rom[0] check is flagging valid temperatures as invalid when
    there is already a CRC data transmission check.

    w1_therm_read_bin()
    if (rom[8] == crc && rom[0])
    verdict = 1;

    Requiring rom[0] to be non-zero will flag as invalid temperature
    conversions when the low byte is zero, specifically the temperatures 0C,
    16C, 32C, 48C, -16C, -32C, and -48C.

    The CRC check is produced on the device for the previous 8 bytes and is
    required to ensure the data integrity in transmission. I don't see why the
    extra check for rom[0] being non-zero is in there. Evgeniy Polyakov didn't
    know either. Just for a check I unplugged the sensor, executed a
    temperature conversion, and read the results. The read was all ff's, which
    also failed the CRC, so it doesn't need to protect against a disconnected
    sensor.

    I have more extensive patches in the work, but these two trivial ones will
    do for today. I would like to hear from people who use the ds2490 USB to
    one wire dongle. 1 if you would be willing to test the patches as I
    currently only have the one sensor on a short parisite powered wire, 2 if
    there is any cheap sources for the ds2490.

    Signed-off-by: David Fries
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Fries
     
  • 941ed3b53   W1: w1_therm.c ds18b20 decode freezing temperatures correctly ... Browse Code »

    Correct the decoding of negative C temperatures. The code did a binary OR
    of two bytes to make a 16 bit value, but assignd it to an integer. This
    caused the value to not be sign extended and to loose that it was a
    negative number in the assignment.

    Before the patch (in my freezer),
    w1_slave
    ed fe 4b 46 7f ff 03 10 e4 : crc=e4 YES
    ed fe 4b 46 7f ff 03 10 e4 t=4078
    With the patch,
    e3 fe 4b 46 7f ff 0d 10 81 : crc=81 YES
    e3 fe 4b 46 7f ff 0d 10 81 t=-17

    Signed-off-by: David Fries
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Fries
     

15 Jan, 2008

1 commit

  • a2a6c74d3   w1: decrement slave counter only in ->release() callback ... Browse Code »

    Decrement the slave counter only in ->release() callback instead of both
    in ->release() and w1 control.

    Patch is based on debug work and preliminary patch made by Henri Laakso.
    Henri noticed in debug that this counter becomes negative after w1 slave
    device is physically removed.

    Signed-off-by: Evgeniy Polyakov
    Cc: Henri Laakso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Evgeniy Polyakov
     

15 Nov, 2007

1 commit

31 Oct, 2007

1 commit

19 Oct, 2007

1 commit

  • 898eb71cb   Add missing newlines to some uses of dev_<level> messages ... Browse Code »

    Found these while looking at printk uses.

    Add missing newlines to dev_ uses
    Add missing KERN_ prefixes to multiline dev_s
    Fixed a wierd->weird spelling typo
    Added a newline to a printk

    Signed-off-by: Joe Perches
    Cc: "Luck, Tony"
    Cc: Jens Axboe
    Cc: Mark M. Hoffman
    Cc: Roland Dreier
    Cc: Tilman Schmidt
    Cc: David Woodhouse
    Cc: Jeff Garzik
    Cc: Stephen Hemminger
    Cc: Greg KH
    Cc: Jeremy Fitzhardinge
    Cc: Geert Uytterhoeven
    Cc: Alessandro Zummo
    Cc: David Brownell
    Cc: James Smart
    Cc: Andrew Vasquez
    Cc: "Antonino A. Daplas"
    Cc: Evgeniy Polyakov
    Cc: Russell King
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     

17 Oct, 2007

1 commit

13 Oct, 2007

1 commit

  • 7eff2e7a8   Driver core: change add_uevent_var to use a struct ... Browse Code »

    This changes the uevent buffer functions to use a struct instead of a
    long list of parameters. It does no longer require the caller to do the
    proper buffer termination and size accounting, which is currently wrong
    in some places. It fixes a known bug where parts of the uevent
    environment are overwritten because of wrong index calculations.

    Many thanks to Mathieu Desnoyers for finding bugs and improving the
    error handling.

    Signed-off-by: Kay Sievers
    Cc: Mathieu Desnoyers
    Cc: Cornelia Huck
    Signed-off-by: Greg Kroah-Hartman

    Kay Sievers
     

25 Sep, 2007

1 commit

23 Aug, 2007

1 commit

27 Jul, 2007

1 commit

20 Jul, 2007

1 commit

  • dd00cc486   some kmalloc/memset ->kzalloc (tree wide) ... Browse Code »

    Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).

    Here is a short excerpt of the semantic patch performing
    this transformation:

    @@
    type T2;
    expression x;
    identifier f,fld;
    expression E;
    expression E1,E2;
    expression e1,e2,e3,y;
    statement S;
    @@

    x =
    - kmalloc
    + kzalloc
    (E1,E2)
    ... when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
    - memset((T2)x,0,E1);

    @@
    expression E1,E2,E3;
    @@

    - kzalloc(E1 * E2,E3)
    + kcalloc(E1,E2,E3)

    [akpm@linux-foundation.org: get kcalloc args the right way around]
    Signed-off-by: Yoann Padioleau
    Cc: Richard Henderson
    Cc: Ivan Kokshaysky
    Acked-by: Russell King
    Cc: Bryan Wu
    Acked-by: Jiri Slaby
    Cc: Dave Airlie
    Acked-by: Roland Dreier
    Cc: Jiri Kosina
    Acked-by: Dmitry Torokhov
    Cc: Benjamin Herrenschmidt
    Acked-by: Mauro Carvalho Chehab
    Acked-by: Pierre Ossman
    Cc: Jeff Garzik
    Cc: "David S. Miller"
    Acked-by: Greg KH
    Cc: James Bottomley
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoann Padioleau
     

18 Jul, 2007

1 commit

  • 831441862   Freezer: make kernel threads nonfreezable by default ... Browse Code »

    Currently, the freezer treats all tasks as freezable, except for the kernel
    threads that explicitly set the PF_NOFREEZE flag for themselves. This
    approach is problematic, since it requires every kernel thread to either
    set PF_NOFREEZE explicitly, or call try_to_freeze(), even if it doesn't
    care for the freezing of tasks at all.

    It seems better to only require the kernel threads that want to or need to
    be frozen to use some freezer-related code and to remove any
    freezer-related code from the other (nonfreezable) kernel threads, which is
    done in this patch.

    The patch causes all kernel threads to be nonfreezable by default (ie. to
    have PF_NOFREEZE set by default) and introduces the set_freezable()
    function that should be called by the freezable kernel threads in order to
    unset PF_NOFREEZE. It also makes all of the currently freezable kernel
    threads call set_freezable(), so it shouldn't cause any (intentional)
    change of behaviour to appear. Additionally, it updates documentation to
    describe the freezing of tasks more accurately.

    [akpm@linux-foundation.org: build fixes]
    Signed-off-by: Rafael J. Wysocki
    Acked-by: Nigel Cunningham
    Cc: Pavel Machek
    Cc: Oleg Nesterov
    Cc: Gautham R Shenoy
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Rafael J. Wysocki
     

17 Jul, 2007

1 commit

  • 012bfdf00   Use menuconfig objects: W1 ... Browse Code »

    Use menuconfigs instead of menus, so the whole menu can be disabled at once
    instead of going through all options.

    Signed-off-by: Jan Engelhardt
    Cc: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Engelhardt
     

16 Jul, 2007

2 commits

12 Jul, 2007

2 commits

  • 91a690295   sysfs: add parameter "struct bin_attribute *" in .read/.write methods for sysfs binary attributes ... Browse Code »

    Well, first of all, I don't want to change so many files either.

    What I do:
    Adding a new parameter "struct bin_attribute *" in the
    .read/.write methods for the sysfs binary attributes.

    In fact, only the four lines change in fs/sysfs/bin.c and
    include/linux/sysfs.h do the real work.
    But I have to update all the files that use binary attributes
    to make them compatible with the new .read and .write methods.
    I'm not sure if I missed any. :(

    Why I do this:
    For a sysfs attribute, we can get a pointer pointing to the
    struct attribute in the .show/.store method,
    while we can't do this for the binary attributes.
    I don't know why this is different, but this does make it not
    so handy to use the binary attributes as the regular ones.
    So I think this patch is reasonable. :)

    Who benefits from it:
    The patch that exposes ACPI tables in sysfs
    requires such an improvement.
    All the table binary attributes share the same .read method.
    Parameter "struct bin_attribute *" is used to get
    the table signature and instance number which are used to
    distinguish different ACPI table binary attributes.

    Without this parameter, we need to offer different .read methods
    for different ACPI table binary attributes.
    This is impossible as there are various ACPI tables on different
    platforms, and we don't know what they are until they are loaded.

    Signed-off-by: Zhang Rui
    Signed-off-by: Greg Kroah-Hartman

    Zhang Rui
     
  • 7b595756e   sysfs: kill unnecessary attribute->owner ... Browse Code »

    sysfs is now completely out of driver/module lifetime game. After
    deletion, a sysfs node doesn't access anything outside sysfs proper,
    so there's no reason to hold onto the attribute owners. Note that
    often the wrong modules were accounted for as owners leading to
    accessing removed modules.

    This patch kills now unnecessary attribute->owner. Note that with
    this change, userland holding a sysfs node does not prevent the
    backing module from being unloaded.

    For more info regarding lifetime rule cleanup, please read the
    following message.

    http://article.gmane.org/gmane.linux.kernel/510293

    (tweaked by Greg to not delete the field just yet, to make it easier to
    merge things properly.)

    Signed-off-by: Tejun Heo
    Cc: Cornelia Huck
    Cc: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Tejun Heo
     

10 Jul, 2007

1 commit

29 Jun, 2007

1 commit

10 May, 2007

1 commit

09 May, 2007

3 commits

13 Feb, 2007

1 commit

14 Dec, 2006

1 commit

08 Dec, 2006

2 commits

04 Dec, 2006

1 commit

17 Nov, 2006

1 commit

17 Oct, 2006

1 commit

  • f9b2e97be   [PATCH] w1 kconfig fix ... Browse Code »

    Remove dependency of w1 subsytem from connector, only w1_con must depend on
    it. With attached patch applied to vanilla 2.6.19-git things works fine.

    Signed-off-by: Evgeniy Polyakov
    Cc:
    Cc: Greg KH
    Cc: Roman Zippel
    Cc: "Randy.Dunlap"
    Cc: Adrian Bunk
    Acked-by: Jean Delvare
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Evgeniy Polyakov