21 Oct, 2008

2 commits

  • Signed-off-by: Al Viro

    Al Viro
     
  • To keep the size of changesets sane we split the switch by drivers;
    to keep the damn thing bisectable we do the following:
    1) rename the affected methods, add ones with correct
    prototypes, make (few) callers handle both. That's this changeset.
    2) for each driver convert to new methods. *ALL* drivers
    are converted in this series.
    3) kill the old (renamed) methods.

    Note that it _is_ a flagday; all in-tree drivers are converted and by the
    end of this series no trace of old methods remain. The only reason why
    we do that this way is to keep the damn thing bisectable and allow per-driver
    debugging if anything goes wrong.

    New methods:
    open(bdev, mode)
    release(disk, mode)
    ioctl(bdev, mode, cmd, arg) /* Called without BKL */
    compat_ioctl(bdev, mode, cmd, arg)
    locked_ioctl(bdev, mode, cmd, arg) /* Called with BKL, legacy */

    Signed-off-by: Al Viro

    Al Viro
     

04 Jul, 2008

1 commit


28 Jan, 2008

1 commit


24 Oct, 2007

1 commit

  • Commits

    58b053e4ce9d2fc3023645c1b96e537c72aa8d9a ("Update arch/ to use sg helpers")
    45711f1af6eff1a6d010703b4862e0d2b9afd056 ("[SG] Update drivers to use sg helpers")
    fa05f1286be25a8ce915c5dd492aea61126b3f33 ("Update net/ to use sg helpers")

    converted many files to use the scatter gather helpers without ensuring
    that the necessary headerfile is included. This
    happened to work for ia64, powerpc, sparc64 and x86 because they
    happened to drag in that file via their .

    On most of the others this probably broke.

    Instead of increasing the header file spider web I choose to include
    directly into the affectes files.

    Signed-off-by: Ralf Baechle
    Signed-off-by: Jens Axboe
    Signed-off-by: Linus Torvalds

    Ralf Baechle
     

23 Oct, 2007

1 commit


20 Sep, 2007

1 commit

  • sparc32:

    drivers/block/DAC960.c: In function 'DAC960_V1_EnableMemoryMailboxInterface':
    drivers/block/DAC960.c:1168: error: 'DMA_32BIT_MASK' undeclared (first use in this function)
    drivers/block/DAC960.c:1168: error: (Each undeclared identifier is reported only

    Cc:
    Cc:
    Cc: Alessandro Polverini
    Cc: Jeff Garzik
    Cc: Matthew Wilcox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     

12 Sep, 2007

1 commit


13 Feb, 2007

1 commit

  • Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

12 Feb, 2007

2 commits

  • * master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (97 commits)
    [SCSI] zfcp: removed wrong comment
    [SCSI] zfcp: use of uninitialized variable
    [SCSI] zfcp: Invalid locking order
    [SCSI] aic79xx: use dma_get_required_mask()
    [SCSI] aic79xx: fix bracket mismatch in unused macro
    [SCSI] BusLogic: Replace 'boolean' by 'bool'
    [SCSI] advansys: clean up warnings
    [SCSI] 53c7xx: brackets fix in uncompiled code
    [SCSI] nsp_cs: remove old scsi code
    [SCSI] aic79xx: make ahd_match_scb() static
    [SCSI] DAC960: kmalloc->kzalloc/Casting cleanups
    [SCSI] scsi_kmap_atomic_sg(): check that local irqs are disabled
    [SCSI] Buslogic: local_irq_disable() is redundant after local_irq_save()
    [SCSI] aic94xx: update for v28 firmware
    [SCSI] scsi_error: Fix lost EH commands
    [SCSI] aic94xx: Add default bus reset handler
    [SCSI] aic94xx: Remove TMF result code munging
    [SCSI] libsas: Add an LU reset mechanism to the error handler
    [SCSI] libsas: Don't BUG when connecting two expanders via wide port
    [SCSI] st: fix Tape dies if wrong block size used, bug 7919
    ...

    Linus Torvalds
     
  • Converts 'boolean' to 'bool' and removes the 'boolean' typedef.

    Signed-off-by: Richard Knutsson
    Cc: Jens Axboe
    Cc: James Bottomley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Richard Knutsson
     

08 Feb, 2007

1 commit


08 Dec, 2006

1 commit


07 Oct, 2006

1 commit

  • - Eliminate casts to/from void*

    - Eliminate checks for conditions that never occur. These typically
    fall into two classes:

    1) Checking for 'dev_id == NULL', then it is never called with
    NULL as an argument.

    2) Checking for invalid irq number, when the only caller (the
    system) guarantees the irq handler is called with the proper
    'irq' number argument.

    Signed-off-by: Jeff Garzik

    Jeff Garzik
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

01 Oct, 2006

2 commits


04 Aug, 2006

1 commit

  • The PCI ID table in the DAC960 driver conflicts with some devices
    that use the ipr driver. All ipr adapters that use this chip
    have an IBM subvendor ID and all DAC960 adapters that use this
    chip have a Mylex subvendor id.

    Signed-off-by: Brian King
    Signed-off-by: James Bottomley

    Brian King
     

03 Jul, 2006

1 commit


27 Jun, 2006

1 commit


20 May, 2006

1 commit

  • The Coverity checker found a memory leak (bug nr. 1245) in
    drivers/block/DAC960.c::DAC960_V2_ProcessCompletedCommand()

    The leak is pretty unlikely since it requires that the first of two
    successive kmalloc() calls fail while the second one succeeds. But it can
    still happen even if it's unlikely.

    If the first call that allocates 'PhysicalDeviceInfo' fails but the one
    that allocates 'InquiryUnitSerialNumber' succeeds, then we will leak the
    memory allocated to 'InquiryUnitSerialNumber' when the variable goes out
    of scope.

    A simple fix for this is to change the existing code that frees
    'PhysicalDeviceInfo' if that one was allocated but
    'InquiryUnitSerialNumber' was not, into a check for either pointer
    being NULL and if so just free both. This is safe since kfree() can
    deal with being passed a NULL pointer and it avoids the leak.

    While I was there I also removed the casts of the kmalloc() return
    value since it's pointless.
    I also updated the driver version since this patch changes the workings of
    the code (however slightly).

    This issue could probably be fixed a lot more elegantly, but the code
    is a big mess IMHO and I just took the least intrusive route to a fix
    that I could find instead of starting on a cleanup as well (that can
    come later).

    Please consider for inclusion.

    Signed-off-by: Jesper Juhl
    Signed-off-by: James Bottomley

    Jesper Juhl
     

29 Mar, 2006

1 commit


27 Mar, 2006

1 commit


25 Mar, 2006

1 commit


09 Mar, 2006

1 commit


10 Jan, 2006

1 commit


09 Jan, 2006

2 commits

  • Use ARRAY_SIZE macro instead of sizeof(x)/sizeof(x[0]) and remove a
    duplicate of ARRAY_SIZE. Some trailing whitespaces are also removed.

    drivers/block/acsi* has been left out as it's marked BROKEN.

    Signed-off-by: Tobias Klauser
    Cc: Jens Axboe
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tobias Klauser
     
  • HDIO_GETGEO is implemented in most block drivers, and all of them have to
    duplicate the code to copy the structure to userspace, as well as getting
    the start sector. This patch moves that to common code [1] and adds a
    ->getgeo method to fill out the raw kernel hd_geometry structure. For many
    drivers this means ->ioctl can go away now.

    [1] the s390 block drivers are odd in this respect. xpram sets ->start
    to 4 always which seems more than odd, and the dasd driver shifts
    the start offset around, probably because of it's non-standard
    sector size.

    Signed-off-by: Christoph Hellwig
    Cc: Jens Axboe
    Cc:
    Cc: Jeff Dike
    Cc: Paolo Giarrusso
    Cc: Bartlomiej Zolnierkiewicz
    Cc: Neil Brown
    Cc: Markus Lidel
    Cc: Russell King
    Cc: David Woodhouse
    Cc: Martin Schwidefsky
    Cc: James Bottomley
    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

06 Jan, 2006

1 commit

  • add @uptodate argument to end_that_request_last() and @error
    to rq_end_io_fn(). there's no generic way to pass error code
    to request completion function, making generic error handling
    of non-fs request difficult (rq->errors is driver-specific and
    each driver uses it differently). this patch adds @uptodate
    to end_that_request_last() and @error to rq_end_io_fn().

    for fs requests, this doesn't really matter, so just using the
    same uptodate argument used in the last call to
    end_that_request_first() should suffice. imho, this can also
    help the generic command-carrying request jens is working on.

    Signed-off-by: tejun heo
    Signed-Off-By: Jens Axboe

    Tejun Heo
     

07 Nov, 2005

1 commit

  • This is the remaining misc drivers/ part of the big kfree cleanup patch.

    Remove pointless checks for NULL prior to calling kfree() in misc files in
    drivers/.

    Signed-off-by: Jesper Juhl
    Acked-by: Aristeu Sergio Rozanski Filho
    Acked-by: Roland Dreier
    Acked-by: Pierre Ossman
    Acked-by: Jean Delvare
    Acked-by: Greg Kroah-Hartman
    Acked-by: Len Brown
    Acked-by: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     

06 May, 2005

1 commit

  • This patch adds support for a new class of DAC960 controllers. It's based
    on the GPLed idac320 driver from IBM for Linux 2.4.18. That driver is a
    fork of the 2.4.18 version of DAC960 that adds support for this new type of
    controllers (internally called "GEM Series"), that differ from other DAC960
    V2 firmware controllers only in the register offsets and removes support
    for all others.

    This patch instead integrates support for these controllers into the DAC960
    driver.

    Thanks to Anders Norrbring for pointing me to the idac320 driver and
    testing this patch.

    No Signed-Off: line because all code is either copy & pasted from IBM's
    idac320 driver or support for other controllers in the 2.6 DAC960 driver.

    Note: the really odd formating matches the rest of the DAC960 driver.

    Cc: Dave Olien
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds