06 Jan, 2009
1 commit
-
... and don't bother in callers. Don't bother with zeroing i_blocks,
while we are at it - it's already been zeroed.i_mode is not worth the effort; it has no common default value.
Signed-off-by: Al Viro
31 Dec, 2008
4 commits
-
Conflicts:
arch/x86/kernel/io_apic.c
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband:
IB/mlx4: Fix reading SL field out of cqe->sl_vid
RDMA/addr: Fix build breakage when IPv6 is disabled -
Commit f780a9f1 ("mlx4_core: Add ethernet fields to CQE struct")
introduced a bug in how wc->sl is set in mlx4_ib_poll_one() -- since
cqe->sl_vid is a big-endian value, the shift must be done after
converting to host endianness.This bug was found using sparse endianness checking.
Signed-off-by: Roland Dreier
30 Dec, 2008
6 commits
-
Commit 38617c64 ("RDMA/addr: Add support for translating IPv6
addresses") broke the build when CONFIG_IPV6=n, because the ib_addr
module unconditionally attempted to call ipv6_chk_addr() and other
IPv6 functions that are not defined when IPv6 is disabled. Fix this
by only building IPv6 support if CONFIG_IPV6 is turned on, and
add a Kconfig dependency to prevent the ib_addr code from being built
in when IPv6 is built modular.Signed-off-by: Roland Dreier
-
Impact: cleanup
We're moving from handing around cpumask_t's to handing around struct
cpumask *'s. cpus_*, cpumask_t and cpu_*_map are deprecated: convert
to cpumask_*, cpu_*_mask.Signed-off-by: Rusty Russell
Cc: Ralph Campbell -
Impact: cleanup
We're moving from handing around cpumask_t's to handing around struct
cpumask *'s. cpus_*, cpumask_t and cpu_*_map are deprecated: convert
to cpumask_*, cpu_*_mask.Signed-off-by: Rusty Russell
Acked-by: Hoang-Nam Nguyen
Tested-by: Hoang-Nam Nguyen
Cc: Christoph Raisch -
Impact: cleanup
In future, accessing cpu numbers beyond nr_cpu_ids (the runtime limit)
will be undefined. We can avoid future problems by using
for_each_online_cpu() here.Signed-off-by: Rusty Russell
Acked-by: Hoang-Nam Nguyen
Tested-by: Hoang-Nam Nguyen
Cc: Christoph Raisch -
We do not need to allocate a itt for data_out, so this
passes the opcode to the alloc_pdu callout.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This just converts iser to new alloc_pdu api. It still
preallocates the pdu, so there is no difference.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
29 Dec, 2008
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1429 commits)
net: Allow dependancies of FDDI & Tokenring to be modular.
igb: Fix build warning when DCA is disabled.
net: Fix warning fallout from recent NAPI interface changes.
gro: Fix potential use after free
sfc: If AN is enabled, always read speed/duplex from the AN advertising bits
sfc: When disabling the NIC, close the device rather than unregistering it
sfc: SFT9001: Add cable diagnostics
sfc: Add support for multiple PHY self-tests
sfc: Merge top-level functions for self-tests
sfc: Clean up PHY mode management in loopback self-test
sfc: Fix unreliable link detection in some loopback modes
sfc: Generate unique names for per-NIC workqueues
802.3ad: use standard ethhdr instead of ad_header
802.3ad: generalize out mac address initializer
802.3ad: initialize ports LACPDU from const initializer
802.3ad: remove typedef around ad_system
802.3ad: turn ports is_individual into a bool
802.3ad: turn ports is_enabled into a bool
802.3ad: make ntt bool
ixgbe: Fix set_ringparam in ixgbe to use the same memory pools.
...Fixed trivial IPv4/6 address printing conflicts in fs/cifs/connect.c due
to the conversion to %pI (in this networking merge) and the addition of
doing IPv6 addresses (from the earlier merge of CIFS).
27 Dec, 2008
1 commit
-
When we removed the network device argument from several
NAPI interfaces in 908a7a16b852ffd618a9127be8d62432182d81b4
("net: Remove unused netdev arg from some NAPI interfaces.")
several drivers now started getting unused variable warnings.This fixes those up.
Signed-off-by: David S. Miller
25 Dec, 2008
5 commits
-
When resizing a CQ, when copying over unpolled CQEs from the old CQE
buffer to the new buffer, the ownership bit must be set appropriately
for the new buffer, or the ownership bit in the new buffer gets
corrupted.Signed-off-by: Jack Morgenstein
Signed-off-by: Roland Dreier -
There is no lock protecting tx_free_list thus causing a system crash
when skb_dequeue() is called and the list is empty. Since it did not give
any performance boost under heavy load, remove it to simplify the code.
Replace get_free_pkt() with dev_alloc_skb() to allocate MAX_CM_BUFFER skb
for connection establishment/teardown as well as MPA request/response.Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
Handle AF_INET6 cases where required, and use struct sockaddr_storage
wherever an IPv6 address might be stored.Signed-off-by: Aleksey Senin
Signed-off-by: Roland Dreier -
Add support for translating AF_INET6 addresses to the IB address
translation service. This requires using struct sockaddr_storage
instead of struct sockaddr wherever an IPv6 address might be stored,
and adding cases to handle IPv6 in addition to IPv4 to the various
translation functions.Signed-off-by: Aleksey Senin
Signed-off-by: Roland Dreier
23 Dec, 2008
1 commit
-
When the napi api was changed to separate its 1:1 binding to the net_device
struct, the netif_rx_[prep|schedule|complete] api failed to remove the now
vestigual net_device structure parameter. This patch cleans up that api by
properly removing it..Signed-off-by: Neil Horman
Signed-off-by: David S. Miller
22 Dec, 2008
3 commits
-
When using MSI-X mode, create a completion event queue for each CPU.
Report the number of completion EQs in a new struct mlx4_caps member,
num_comp_vectors, and extend the mlx4_cq_alloc() interface with a
vector parameter so that consumers can specify which completion EQ
should be used to report events for the CQ being created.Signed-off-by: Yevgeny Petrilin
Signed-off-by: Roland Dreier -
iSCSI/iSER targets may send PDUs without a prior request from the
initiator. RFC 5046 refers to these PDUs as "unexpected". NOP-In PDUs
with itt=RESERVED and Asynchronous Message PDUs occupy this category.The amount of active "unexpected" PDU's an iSER target may have at any
time is governed by the MaxOutstandingUnexpectedPDUs key, which is not
yet supported.Currently when an iSER target sends an "unexpected" PDU, the
initiators recv buffer consumed by the PDU is not replaced. If over
initial_post_recv_bufs_num "unexpected" PDUs are received then the
receive queue will run out of receive work requests entirely.This patch ensures recv buffers consumed by "unexpected" PDUs are
replaced in the next iser_post_receive_control() call.Signed-off-by: David Disseldorp
Signed-off-by: Ken Sandars
Acked-by: Or Gerlitz
Signed-off-by: Roland Dreier -
vpage is checked not to be NULL just after it is initialized at the
beginning of each loop iteration.A simplified version of the semantic patch that makes this change is
as follows: (http://www.emn.fr/x-info/coccinelle/)//
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@if (x@p1 == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@(
- if ((x@p2 != NULL) || ...)
S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
//Signed-off-by: Julia Lawall
Signed-off-by: Roland Dreier
06 Dec, 2008
15 commits
-
With the latest flush error completion patch we introduced modulus
operation to calculate the next index within a qmap. Based on
comments from other mailing lists we decided to optimize this
operation by using an addition and an if-statement instead of modulus,
even though this is on the error path.Signed-off-by: Stefan Roscher
Signed-off-by: Roland Dreier -
Fixes timing race resulting in panic. Not a performance sensitive path.
Signed-off-by: Dave Olson
Signed-off-by: Roland Dreier -
ipath_piobufbase was a single value offset, but is multiple values on
newer chips, so use only the 32 bits for the 2K buffers (4K buffers
are currently used only by the driver).Signed-off-by: Dave Olson
Signed-off-by: Roland Dreier -
Signed-off-by: Dave Olson
Signed-off-by: Roland Dreier -
Implement the ignoring of ibsymbol errors and linkrecover errors while
the link is at less than INIT (long needed), to get accurate counts.
Particularly an issue when doing non-IBTA DDR negotiation with chips
from vendors that do not support IBTA mode negotiation. If the driver
is unloaded, and there is a delta, the adjusted counters are written
back to the chip, so they stay adjusted across driver reload.Signed-off-by: Dave Olson
Signed-off-by: Roland Dreier -
This fixes an obvious oversight where the return value is not checked
for error.Signed-off-by: Ralph Campbell
Signed-off-by: Roland Dreier -
The PSN of the first packet after an RDMA read is based on the size of
the RDMA read request. This is calculated correctly for the WQE sent
after the first request message but not on subsequent requests if the
RDMA read is resent.Signed-off-by: Ralph Campbell
Signed-off-by: Roland Dreier -
Wrap NES_DEBUG and assert macros with do while (0) to avoid ambiguous
else. No one is using sk_buff * returned from form_cm_frame(), so
drop the return. drop_packet() should not be incrementing reset
counter on receiving a FIN.Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
Check for loopback connection in make_cm_node().
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
Between the first empty list check and locking the list, the list can
change. Check it again after it is locked to make sure the list is
still not empty.Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
ANVL testing showed we are not handling all cm_node states during
connection establishment. Add missing state handlers and fix sequence
number send reset in handle_tcp_options().Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
Under heavy traffic, there is a small windows when an APBVT entry is
not yet removed and a new connection is established. Packets for the
new connection are dropped until APBVT entry is removed. This patch
will forward the packets instead of dropping them.Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
In passive open, after indicating MPA request to rdma_cm, an incoming
RST would fire a reset event to rdma_cm causing it to crash, since the
current state is not connected. The solution is to wait for
nes_accept() or nes_reject() before firing the reset event. If
nes_accept() or nes_reject() is already done, then the reset event
will be fired when RST is processed.Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
While processing connected_nodes list, we would release the lock when
we need to send reset to remote partner. That created a window where
the list can be modified. Change this into a two step process: place
nodes that need processing on a local list then process the local list.Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier -
Use nes_free_cqp_request() instead of open coding. Change some
continue to break in nes_cm_timer_tick, because send_entry used to be
a list processed in a loop (so continue went to the next item). Now
it is a single item, so using break is correct.Signed-off-by: Faisal Latif
Signed-off-by: Chien Tung
Signed-off-by: Roland Dreier
03 Dec, 2008
1 commit
-
Conflicts:
drivers/net/ixgbe/ixgbe_main.c
drivers/net/smc91x.c
02 Dec, 2008
2 commits
-
Receive work queue entries are checked for L_Key validity, and
pointers to the memory region structure are saved in an allocated
structure. For UD loopback packets, this structure is allocated and
freed for each packet. This patch changes that to allocate/free
during QP creation and destruction.Signed-off-by: Ralph Campbell
Signed-off-by: Roland Dreier -
The return from lookup_one_len() is assigned to *dentry, so that's
what we should be checking with IS_ERR().Signed-off-by: Michael Ellerman
Signed-off-by: Roland Dreier
