27 Jul, 2011

1 commit

  • This allows us to move duplicated code in
    (atomic_inc_not_zero() for now) to

    Signed-off-by: Arun Sharma
    Reviewed-by: Eric Dumazet
    Cc: Ingo Molnar
    Cc: David Miller
    Cc: Eric Dumazet
    Acked-by: Mike Frysinger
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arun Sharma
     

19 Jul, 2011

2 commits

  • Move the various definitions and mad structures needed for software
    implementation of IBA PM agent from the ipath and qib drivers into a
    single include file, which in turn could be used by more consumers.

    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Or Gerlitz
     
  • Add IB GID change event type. This is needed for IBoE when the HW
    driver updates the GID (e.g when new VLANs are added/deleted) table
    and the change should be reflected to the IB core cache.

    Signed-off-by: Eli Cohen
    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Or Gerlitz
     

27 May, 2011

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband:
    RDMA/cma: Save PID of ID's owner
    RDMA/cma: Add support for netlink statistics export
    RDMA/cma: Pass QP type into rdma_create_id()
    RDMA: Update exported headers list
    RDMA/cma: Export enum cma_state in
    RDMA/nes: Add a check for strict_strtoul()
    RDMA/cxgb3: Don't post zero-byte read if endpoint is going away
    RDMA/cxgb4: Use completion objects for event blocking
    IB/srp: Fix integer -> pointer cast warnings
    IB: Add devnode methods to cm_class and umad_class
    IB/mad: Return EPROTONOSUPPORT when an RDMA device lacks the QP required
    IB/uverbs: Add devnode method to set path/mode
    RDMA/ucma: Add .nodename/.mode to tell userspace where to create device node
    RDMA: Add netlink infrastructure
    RDMA: Add error handling to ib_core_init()

    Linus Torvalds
     

26 May, 2011

4 commits

  • Add callbacks and data types for statistics export of all current
    devices/ids. The schema for RDMA CM is a series of netlink messages.
    Each one contains an rdma_cm_stat struct. Additionally, two netlink
    attributes are created for the addresses for each message (if
    applicable).

    Their types used are:
    RDMA_NL_RDMA_CM_ATTR_SRC_ADDR (The source address for this ID)
    RDMA_NL_RDMA_CM_ATTR_DST_ADDR (The destination address for this ID)
    sockaddr_* structs are encapsulated within these attributes.

    In other words, every transaction contains a series of messages like:

    -------message 1-------
    struct rdma_cm_id_stats {
    __u32 qp_num;
    __u32 bound_dev_if;
    __u32 port_space;
    __s32 pid;
    __u8 cm_state;
    __u8 node_type;
    __u8 port_num;
    __u8 reserved;
    }
    RDMA_NL_RDMA_CM_ATTR_SRC_ADDR attribute - contains the source address
    RDMA_NL_RDMA_CM_ATTR_DST_ADDR attribute - contains the destination address
    -------end 1-------
    -------message 2-------
    struct rdma_cm_id_stats
    RDMA_NL_RDMA_CM_ATTR_SRC_ADDR attribute
    RDMA_NL_RDMA_CM_ATTR_DST_ADDR attribute
    -------end 2-------

    Signed-off-by: Nir Muchtar
    Signed-off-by: Roland Dreier

    Nir Muchtar
     
  • The RDMA CM currently infers the QP type from the port space selected
    by the user. In the future (eg with RDMA_PS_IB or XRC), there may not
    be a 1-1 correspondence between port space and QP type. For netlink
    export of RDMA CM state, we want to export the QP type to userspace,
    so it is cleaner to explicitly associate a QP type to an ID.

    Modify rdma_create_id() to allow the user to specify the QP type, and
    use it to make our selections of datagram versus connected mode.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • Various RDMA headers are intended to be exported to userspace, so add
    them to the headers-y list. Add a (strictly speaking, superfluous)
    include of to avoid a headers_check warning.

    Signed-off-by: Roland Dreier

    Roland Dreier
     
  • Move cma.c's internal definition of enum cma_state to enum rdma_cm_state
    in an exported header so that it can be exported via RDMA netlink.

    Signed-off-by: Nir Muchtar
    Signed-off-by: Roland Dreier

    Nir Muchtar
     

21 May, 2011

2 commits

  • * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1446 commits)
    macvlan: fix panic if lowerdev in a bond
    tg3: Add braces around 5906 workaround.
    tg3: Fix NETIF_F_LOOPBACK error
    macvlan: remove one synchronize_rcu() call
    networking: NET_CLS_ROUTE4 depends on INET
    irda: Fix error propagation in ircomm_lmp_connect_response()
    irda: Kill set but unused variable 'bytes' in irlan_check_command_param()
    irda: Kill set but unused variable 'clen' in ircomm_connect_indication()
    rxrpc: Fix set but unused variable 'usage' in rxrpc_get_transport()
    be2net: Kill set but unused variable 'req' in lancer_fw_download()
    irda: Kill set but unused vars 'saddr' and 'daddr' in irlan_provider_connect_indication()
    atl1c: atl1c_resume() is only used when CONFIG_PM_SLEEP is defined.
    rxrpc: Fix set but unused variable 'usage' in rxrpc_get_peer().
    rxrpc: Kill set but unused variable 'local' in rxrpc_UDP_error_handler()
    rxrpc: Kill set but unused variable 'sp' in rxrpc_process_connection()
    rxrpc: Kill set but unused variable 'sp' in rxrpc_rotate_tx_window()
    pkt_sched: Kill set but unused variable 'protocol' in tc_classify()
    isdn: capi: Use pr_debug() instead of ifdefs.
    tg3: Update version to 3.119
    tg3: Apply rx_discards fix to 5719/5720
    ...

    Fix up trivial conflicts in arch/x86/Kconfig and net/mac80211/agg-tx.c
    as per Davem.

    Linus Torvalds
     
  • Add basic RDMA netlink infrastructure that allows for registration of
    RDMA clients for which data is to be exported and supplies message
    construction callbacks.

    Signed-off-by: Nir Muchtar

    [ Reorganize a few things, add CONFIG_NET dependency. - Roland ]

    Signed-off-by: Roland Dreier

    Roland Dreier
     

10 May, 2011

2 commits

  • The IW_CM_EVENT_STATUS_xxx values were used in only a couple of places;
    cma.c uses -Exxx values instead, and so do the amso1100, cxgb3 and cxgb4
    drivers -- only nes was using the enum values (with the mild consequence
    that all nes connection failures were treated as generic errors rather
    than reported as timeouts or rejections).

    We can fix this confusion by getting rid of enum iw_cm_event_status and
    using a plain int for struct iw_cm_event.status, and converting nes to
    use -Exxx as the other iWARP drivers do.

    This also gets rid of the warning

    drivers/infiniband/core/cma.c: In function 'cma_iw_handler':
    drivers/infiniband/core/cma.c:1333:3: warning: case value '4294967185' not in enumerated type 'enum iw_cm_event_status'
    drivers/infiniband/core/cma.c:1336:3: warning: case value '4294967186' not in enumerated type 'enum iw_cm_event_status'
    drivers/infiniband/core/cma.c:1332:3: warning: case value '4294967192' not in enumerated type 'enum iw_cm_event_status'

    Signed-off-by: Roland Dreier
    Reviewed-by: Steve Wise
    Reviewed-by: Sean Hefty
    Reviewed-by: Faisal Latif

    Roland Dreier
     
  • Lustre requires that clients bind to a privileged port number before
    connecting to a remote server. On larger clusters (typically more
    than about 1000 nodes), the number of privileged ports is exhausted,
    resulting in lustre being unusable.

    To handle this, we add support for reusable addresses to the rdma_cm.
    This mimics the behavior of the socket option SO_REUSEADDR. A user
    may set an rdma_cm_id to reuse an address before calling
    rdma_bind_addr() (explicitly or implicitly). If set, other
    rdma_cm_id's may be bound to the same address, provided that they all
    have reuse enabled, and there are no active listens.

    If rdma_listen() is called on an rdma_cm_id that has reuse enabled, it
    will only succeed if there are no other id's bound to that same
    address. The reuse option is exported to user space. The behavior of
    the kernel reuse implementation was verified against that given by
    sockets.

    This patch is derived from a path by Ira Weiny

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Hefty, Sean
     

30 Apr, 2011

1 commit

  • This makes sure that when a driver calls the ethtool's
    get/set_settings() callback of another driver, the data passed to it
    is clean. This guarantees that speed_hi will be zeroed correctly if
    the called callback doesn't explicitely set it: we are sure we don't
    get a corrupted speed from the underlying driver. We also take care of
    setting the cmd field appropriately (ETHTOOL_GSET/SSET).

    This applies to dev_ethtool_get_settings(), which now makes sure it
    sets up that ethtool command parameter correctly before passing it to
    drivers. This also means that whoever calls dev_ethtool_get_settings()
    does not have to clean the ethtool command parameter. This function
    also becomes an exported symbol instead of an inline.

    All drivers visible to make allyesconfig under x86_64 have been
    updated.

    Signed-off-by: David Decotigny
    Signed-off-by: David S. Miller

    David Decotigny
     

17 Jan, 2011

1 commit

  • * ib_wq is added, which is used as the common workqueue for infiniband
    instead of the system workqueue. All system workqueue usages
    including flush_scheduled_work() callers are converted to use and
    flush ib_wq.

    * cancel_delayed_work() + flush_scheduled_work() converted to
    cancel_delayed_work_sync().

    * qib_wq is removed and ib_wq is used instead.

    This is to prepare for deprecation of flush_scheduled_work().

    Signed-off-by: Tejun Heo
    Signed-off-by: Roland Dreier

    Tejun Heo
     

26 Oct, 2010

2 commits


15 Oct, 2010

1 commit


14 Oct, 2010

1 commit

  • Add support for IBoE device binding and IP --> GID resolution. Path
    resolving and multicast joining are implemented within cma.c by
    filling in the responses and running callbacks in the CMA work queue.

    IP --> GID resolution always yields IPv6 link local addresses; remote
    GIDs are derived from the destination MAC address of the remote port.
    Multicast GIDs are always mapped to multicast MACs as is done in IPv6.
    (IPv4 multicast is enabled by translating IPv4 multicast addresses to
    IPv6 multicast as described in
    .)

    Some helper functions are added to ib_addr.h.

    Signed-off-by: Eli Cohen
    Signed-off-by: Roland Dreier

    Eli Cohen
     

28 Sep, 2010

1 commit

  • This patch allows ports to have different link layers:
    IB_LINK_LAYER_INFINIBAND or IB_LINK_LAYER_ETHERNET. This is required
    for adding IBoE (InfiniBand-over-Ethernet, aka RoCE) support. For
    devices that do not provide an implementation for querying the link
    layer property of a port, we return a default value based on the
    transport: RMA_TRANSPORT_IB nodes will return IB_LINK_LAYER_INFINIBAND
    and RDMA_TRANSPORT_IWARP nodes will return IB_LINK_LAYER_ETHERNET.

    Signed-off-by: Eli Cohen
    Signed-off-by: Roland Dreier

    Eli Cohen
     

05 Aug, 2010

1 commit

  • Change abbreviated IB_QPT_RAW_ETY to IB_QPT_RAW_ETHERTYPE to make
    the special QP type easier to understand.

    cf http://www.mail-archive.com/linux-rdma@vger.kernel.org/msg04530.html

    Signed-off-by: Aleksey Senin
    Signed-off-by: Roland Dreier

    Aleksey Senin
     

22 May, 2010

1 commit

  • Add a new parameter to ib_register_device() so that low-level device
    drivers can pass in a pointer to a callback function that will be
    called for each port that is registered in sysfs. This allows
    low-level device drivers to create files in

    /sys/class/infiniband//ports//

    without having to poke through the internals of the RDMA sysfs handling.

    There is no need for an unregister function since the kobject
    reference will go to zero when ib_unregister_device() is called.

    Signed-off-by: Ralph Campbell
    Signed-off-by: Roland Dreier

    Ralph Campbell
     

22 Apr, 2010

1 commit

  • - Add new IB_WR_MASKED_ATOMIC_CMP_AND_SWP and IB_WR_MASKED_ATOMIC_FETCH_AND_ADD
    send opcodes that can be used to post "masked atomic compare and
    swap" and "masked atomic fetch and add" work request respectively.
    - Add masked_atomic_cap capability.
    - Add mask fields to atomic struct of ib_send_wr
    - Add new opcodes to ib_wc_opcode

    The new operations are described more precisely below:

    * Masked Compare and Swap (MskCmpSwap)

    The MskCmpSwap atomic operation is an extension to the CmpSwap
    operation defined in the IB spec. MskCmpSwap allows the user to
    select a portion of the 64 bit target data for the “compare” check as
    well as to restrict the swap to a (possibly different) portion. The
    pseudo code below describes the operation:

    | atomic_response = *va
    | if (!((compare_add ^ *va) & compare_add_mask)) then
    | *va = (*va & ~(swap_mask)) | (swap & swap_mask)
    |
    | return atomic_response

    The additional operands are carried in the Extended Transport Header.
    Atomic response generation and packet format for MskCmpSwap is as for
    standard IB Atomic operations.

    * Masked Fetch and Add (MFetchAdd)

    The MFetchAdd Atomic operation extends the functionality of the
    standard IB FetchAdd by allowing the user to split the target into
    multiple fields of selectable length. The atomic add is done
    independently on each one of this fields. A bit set in the
    field_boundary parameter specifies the field boundaries. The pseudo
    code below describes the operation:

    | bit_adder(ci, b1, b2, *co)
    | {
    | value = ci + b1 + b2
    | *co = !!(value & 2)
    |
    | return value & 1
    | }
    |
    | #define MASK_IS_SET(mask, attr) (!!((mask)&(attr)))
    | bit_position = 1
    | carry = 0
    | atomic_response = 0
    |
    | for i = 0 to 63
    | {
    | if ( i != 0 )
    | bit_position = bit_position << 1
    |
    | bit_add_res = bit_adder(carry, MASK_IS_SET(*va, bit_position),
    | MASK_IS_SET(compare_add, bit_position), &new_carry)
    | if (bit_add_res)
    | atomic_response |= bit_position
    |
    | carry = ((new_carry) && (!MASK_IS_SET(compare_add_mask, bit_position)))
    | }
    |
    | return atomic_response

    Signed-off-by: Vladimir Sokolovsky
    Signed-off-by: Roland Dreier

    Vladimir Sokolovsky
     

02 Mar, 2010

2 commits


25 Feb, 2010

2 commits


12 Feb, 2010

1 commit


16 Dec, 2009

1 commit


10 Dec, 2009

1 commit


20 Nov, 2009

3 commits

  • The RDMA CM is intended to support the use of a loopback address
    when establishing a connection; however, the behavior of the CM
    when loopback addresses are used is confusing and does not always
    work, depending on whether loopback was specified by the server,
    the client, or both.

    The defined behavior of rdma_bind_addr is to associate an RDMA
    device with an rdma_cm_id, as long as the user specified a non-
    zero address. (ie they weren't just trying to reserve a port)
    Currently, if the loopback address is passed to rdam_bind_addr,
    no device is associated with the rdma_cm_id. Fix this.

    If a loopback address is specified by the client as the destination
    address for a connection, it will fail to establish a connection.
    This is true even if the server is listing across all addresses or
    on the loopback address itself. The issue is that the server tries
    to translate the IP address carried in the REQ message to a local
    net_device address, which fails. The translation is not needed in
    this case, since the REQ carries the actual HW address that should
    be used.

    Finally, cleanup loopback support to be more transport neutral.
    Replace separate calls to get/set the sgid and dgid from the
    device address to a single call that behaves correctly depending
    on the format of the device address. And support both IPv4 and
    IPv6 address formats.

    Signed-off-by: Sean Hefty

    [ Fixed RDS build by s/ib_addr_get/rdma_addr_get/ - Roland ]

    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • The struct rdma_dev_addr stores net_device address information:
    the source device address, destination hardware address, and
    broadcast address. For consistency, store the net_device type
    rather than converting it to the rdma_node_type.

    The type indicates the format of the various hardware addresses,
    which is what we're concerned with, and not the RDMA node type
    that the address may map to.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • Provide the device interface when resolving route information to
    ensure that the correct outbound device is used. This will also
    simplify processing of sin6_scope_id for IPv6 support.

    Based on work from:
    David Wilder
    Jason Gunthorpe

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     

17 Nov, 2009

1 commit

  • Export rdma_set_ib_paths to user space to allow applications to
    manually set the IB path used for connections. This allows
    alternative ways for a user space application or library to obtain
    path record information, including retrieving path information
    from cached data, avoiding direct interaction with the IB SA.
    The IB SA is a single, centralized entity that can limit scaling
    on large clusters running MPI applications.

    Future changes to the rdma cm can expand on this framework to
    support the full range of features allowed by the IB CM, such as
    separate forward and reverse paths and APM.

    Signed-off-by: Sean Hefty
    Reviewed-By: Jason Gunthorpe
    Signed-off-by: Roland Dreier

    Sean Hefty
     

21 Sep, 2009

1 commit


27 Mar, 2009

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1750 commits)
    ixgbe: Allow Priority Flow Control settings to survive a device reset
    net: core: remove unneeded include in net/core/utils.c.
    e1000e: update version number
    e1000e: fix close interrupt race
    e1000e: fix loss of multicast packets
    e1000e: commonize tx cleanup routine to match e1000 & igb
    netfilter: fix nf_logger name in ebt_ulog.
    netfilter: fix warning in ebt_ulog init function.
    netfilter: fix warning about invalid const usage
    e1000: fix close race with interrupt
    e1000: cleanup clean_tx_irq routine so that it completely cleans ring
    e1000: fix tx hang detect logic and address dma mapping issues
    bridge: bad error handling when adding invalid ether address
    bonding: select current active slave when enslaving device for mode tlb and alb
    gianfar: reallocate skb when headroom is not enough for fcb
    Bump release date to 25Mar2009 and version to 0.22
    r6040: Fix second PHY address
    qeth: fix wait_event_timeout handling
    qeth: check for completion of a running recovery
    qeth: unregister MAC addresses during recovery.
    ...

    Manually fixed up conflicts in:
    drivers/infiniband/hw/cxgb3/cxio_hal.h
    drivers/infiniband/hw/nes/nes_nic.c

    Linus Torvalds
     

25 Mar, 2009

1 commit


28 Feb, 2009

1 commit

  • Fix ib_set_rmpp_flags() to use the correct bit mask for RRespTime. In
    the 8-bit field of the RMPP header, the first 5 bits are RRespTime and
    next 3 bits are RMPPFlags. Hence to retain the first 5 bits, the mask
    should be 0xF8 instead of 0xF1.

    ack_recv()-->format_ack() calls ib_set_rmpp_flags() and due to the
    incorrect ANDing with 0xF1, RRespTime got changed incorrectly and RMPP
    Acks sent back always had a RRespTime of 0x1E (30) which caused the
    other end to consider the time outs to be approximately 4297 seconds
    (i.e. in the order of 4*2^30) instead of the usual ~4 seconds (order
    of 4*2^20).

    Signed-off-by: Ramachandra K
    Acked-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Ramachandra K
     

15 Feb, 2009

1 commit


18 Jan, 2009

1 commit

  • The base versions handle constant folding just fine, use them
    directly. The replacements are OK in the include/ files as they are
    not exported to userspace so we don't need the __ prefixed versions.

    This patch does not affect code generation at all.

    Signed-off-by: Harvey Harrison
    Signed-off-by: Roland Dreier

    Harvey Harrison
     

05 Aug, 2008

1 commit

  • There are a few places where the RDMA CM code handles IPv6 by doing

    struct sockaddr addr;
    u8 pad[sizeof(struct sockaddr_in6) -
    sizeof(struct sockaddr)];

    This is fragile and ugly; handle this in a better way with just

    struct sockaddr_storage addr;

    [ Also roll in patch from Aleksey Senin to
    switch to struct sockaddr_storage and get rid of padding arrays in
    struct rdma_addr. ]

    Signed-off-by: Roland Dreier

    Roland Dreier