17 May, 2010
12 commits
-
This patch does:
- no need call tracepoint_synchronize_unregister() when kvm module
is unloaded since ftrace can handle it- cleanup ftrace's macro
Signed-off-by: Xiao Guangrong
Signed-off-by: Avi Kivity -
If fail to create the vcpu, we should not create the debugfs
for it.Signed-off-by: Wei Yongjun
Acked-by: Alexander Graf
Cc: stable@kernel.org
Signed-off-by: Avi Kivity -
This patch fixed possible memory leak in kvm_arch_vcpu_create()
under s390, which would happen when kvm_arch_vcpu_create() fails.Signed-off-by: Wei Yongjun
Acked-by: Carsten Otte
Cc: stable@kernel.org
Signed-off-by: Avi Kivity -
LMSW is present in both group tables. It was marked privileged only in
one of them. Intel analog of VMMCALL is already marked privileged.Signed-off-by: Gleb Natapov
Signed-off-by: Marcelo Tosatti -
These bits are ignored by the hardware too. Implement this
for nested svm too.Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
This patch adds the correct handling of the nested io
permission bitmap. Old behavior was to not lookup the port
in the iopm but only reinject an io intercept to the guest.Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
There is a generic function now to calculate msrpm offsets.
Use that function in nested_svm_exit_handled_msr() remove
the duplicate logic (which had a bug anyway).Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
This patch optimizes the way the msrpm of the host and the
guest are merged. The old code merged the 2 msrpm pages
completly. This code needed to touch 24kb of memory for that
operation. The optimized variant this patch introduces
merges only the parts where the host msrpm may contain zero
bits. This reduces the amount of memory which is touched to
48 bytes.Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
This patch introduces a list with all msrs a guest might
have direct access to and changes the svm_vcpu_init_msrpm
function to use this list.
It also adds a check to set_msr_interception which triggers
a warning if a developer changes a msr intercept that is not
in the list.Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
The algorithm to find the offset in the msrpm for a given
msr is needed at other places too. Move that logic to its
own function.Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
The nested_svm_exit_handled_msr() returned an bool which is
a bug. I worked by accident because the exected integer
return values match with the true and false values. This
patch changes the return value to int and let the function
return the correct values.Signed-off-by: Joerg Roedel
Signed-off-by: Marcelo Tosatti -
arch/x86/kvm/kvm_timer.h:13: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini
Signed-off-by: Marcelo Tosatti
25 Apr, 2010
28 commits
-
Implement jmp far opcode ff/5. It is used by multiboot loader.
Signed-off-by: Gleb Natapov
Signed-off-by: Avi Kivity -
Add decoding of Ep type of argument used by callf/jmpf.
Signed-off-by: Gleb Natapov
Signed-off-by: Avi Kivity -
segment_base() is used only by vmx so move it there.
Signed-off-by: Gleb Natapov
Signed-off-by: Avi Kivity -
fix segment_base() to properly check for null segment selector and
avoid accessing NULL pointer if ldt selector in null.Signed-off-by: Gleb Natapov
Signed-off-by: Avi Kivity -
Linux now has native_store_gdt() to do the same. Use it instead of
kvm local version.Signed-off-by: Gleb Natapov
Signed-off-by: Avi Kivity -
Marcelo introduced gfn_to_hva_memslot() when he implemented
gfn_to_pfn_memslot(). Let's use this for gfn_to_hva() too.Note: also remove parentheses next to return as checkpatch said to do.
Signed-off-by: Takuya Yoshikawa
Signed-off-by: Avi Kivity -
When injecting an vmexit.intr into the nested hypervisor
there might be leftover values in the exit_info fields.
Clear them to not confuse nested hypervisors.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
If we have the following situation with nested svm:
1. Host KVM intercepts cr0 writes
2. Guest hypervisor intercepts only selective cr0 writesThen we get an cr0 write intercept which is handled on the
host. But that intercepts may actually be a selective cr0
intercept for the guest. This patch checks for this
condition and injects a selective cr0 intercept if needed.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
The vcpu->arch.cr0 variable is already set in the
architecture specific set_cr0 callbacks. There is no need to
set it in the common code.
This allows the architecture code to keep the old arch.cr0
value if it wants. This is required for nested svm to decide
if a selective_cr0 exit needs to be injected.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
Hyper-V as a guest wants to write this bit. This patch
ignores it.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
This patch implements the emulation of the vm_cr msr for
nested svm.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
This patch adds a tracepoint to get information about the
most important intercept bitmasks from the nested vmcb.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
A recent change broke tracing of the nested vmcb address. It
was reported as 0 all the time. This patch fixes it.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
This patch implements the NMI intercept checking for nested
svm.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
Without resetting the MMU the gva_to_pga function will not
work reliably when the vcpu is running in nested context.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
This patch removes whitespace errors, fixes comment formats
and most of checkpatch warnings. Now vim does not show
c-space-errors anymore.Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity -
Call directly into the vendor services for getting/setting rflags in
emulate_instruction to ensure injected TF survives the emulation.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
RF is not required for injecting TF as the latter will trigger only
after an instruction execution anyway. So do not touch RF when arming or
disarming guest single-step mode.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
When in guest debugging mode, we have to reinject those #BP software
exceptions that are caused by guest-injected INT3. As older AMD
processors do not support the required nRIP VMCB field, try to emulate
it by moving RIP past the instruction on exception injection. Fix it up
again in case the injection failed and we were able to catch this. This
does not work for unintercepted faults, but it is better than doing
nothing.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
Based on Gleb's suggestion: Add a helper kvm_is_linear_rip that matches
a given linear RIP against the current one. Use this for guest
single-stepping, more users will follow.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
Move svm_queue_exception past skip_emulated_instruction to allow calling
it later on.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
This restores the deferred VCPU kicking before 956f97cf. We need this
over -rt as wake_up* requires non-atomic context in this configuration.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
When we destory a vcpu, we should also make sure to kill all pending
timers that could still be up. When not doing this, hrtimers might
dereference null pointers trying to call our code.This patch fixes spontanious kernel panics seen after closing VMs.
Signed-off-by: Alexander Graf
Signed-off-by: Avi Kivity -
While converting the kzalloc we used to allocate our vcpu struct to
vmalloc, I forgot to memset the contents to zeros. That broke quite
a lot.This patch memsets it to zero again.
Signed-off-by: Alexander Graf
Signed-off-by: Avi Kivity -
So far user space was not able to save and restore debug registers for
migration or after reset. Plug this hole.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
The interrupt shadow created by STI or MOV-SS-like operations is part of
the VCPU state and must be preserved across migration. Transfer it in
the spare padding field of kvm_vcpu_events.interrupt.As a side effect we now have to make vmx_set_interrupt_shadow robust
against both shadow types being set. Give MOV SS a higher priority and
skip STI in that case to avoid that VMX throws a fault on next entry.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
To avoid that user space migrates a pending software exception or
interrupt, mask them out on KVM_GET_VCPU_EVENTS. Without this, user
space would try to reinject them, and we would have to reconstruct the
proper instruction length for VMX event injection. Now the pending event
will be reinjected via executing the triggering instruction again.Signed-off-by: Jan Kiszka
Signed-off-by: Avi Kivity -
The nested_svm_intr() function does not execute the vmexit
anymore. Therefore we may still be in the nested state after
that function ran. This patch changes the nested_svm_intr()
function to return wether the irq window could be enabled.Cc: stable@kernel.org
Signed-off-by: Joerg Roedel
Signed-off-by: Avi Kivity
