26 Sep, 2006
1 commit
-
The v4l2 API documentation for VIDIOC_ENUMSTD says:
To enumerate all standards applications shall begin at index
zero, incrementing by one until the driver returns EINVAL.The actual code, however, tests the index this way:
if (index= vfd->tvnormsize) {
ret=-EINVAL;So any application which passes in index=0 gets EINVAL right off the bat
- and, in fact, this is what happens to mplayer. So I think the
following patch is called for, and maybe even appropriate for a 2.6.18.x
stable release.Signed-off-by: Jonathan Corbet
Cc: Mauro Carvalho Chehab
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Sep, 2006
6 commits
-
Signed-off-by: Mauro Carvalho Chehab
-
Several DVB modules depends on I2C
Signed-off-by: Andrew de Quincey
Signed-off-by: Mauro Carvalho Chehab -
V4L1 support should be disabled when no CONFIG_VIDEO_V4L1_COMPAT is defined,
to allow checking for broken V4L2 ports. This is very important during the
migration phase for V4L2 API.
However, userspace apps should be capable of using both APIs, since they need
to test at runtime, via VIDIOCGCAP ioctl, if V4L1 is supported. So, when
__KERNEL__ is not defined, those ioctls and corresponding structs should be
visible.
This patch also removes the obsolete defines HAVE_V4L1 and HAVE_V4L2, that
where causing some confusion, and were replaced by CONFIG_VIDEO_V4L1_COMPAT
and CONFIG_VIDEO_V4L2.Signed-off-by: Mauro Carvalho Chehab
-
Previously, this were reported:
Ooops: IR config error [card=139]Signed-off-by: Mauro Carvalho Chehab
-
The tena_9533_di_pal_ranges use 0x04 instead the original 0x08 for the
UHF (range 2) switching. This is wrong and therefore nothing happens.
Restore tuner_ymec_tvf66t5_b_dff_pal_ranges[] to make the UHF switch
working again.Signed-off-by: Hermann Pitton
Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
VIDIOCGMBUF should be compiled only when V4L1 support is selected, since
this ioctl is from the obsoleted API.Signed-off-by: Mauro Carvalho Chehab
09 Aug, 2006
11 commits
-
Signed-off-by: Yeasah Pell
Signed-off-by: Manu Abraham
Signed-off-by: Mauro Carvalho Chehab -
In bugzilla #6943, Maxim Britov reported:
"I can enable Logitech quickcam support in .config, but it want be compile.
I have to add into drivers/media/video/Makefile:
obj-$(CONFIG_USB_QUICKCAM_MESSENGER) += usbvideo/"
He's right, just enable that driver as module while disabling every other
driver that gets into that directory, nothing will get compiled.
This patch fixes the Makefile.Signed-off-by: Diego Calleja
Acked-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Mauro Carvalho Chehab
-
Without the LNA these tuners perform very poorly (read 'unwatchable') when
the signal is weak.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Due to a wrong statement order the 'standard' module option didn't
work for 'G' model chips.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
cx25840_read4 assembled the bytes in the wrong order.
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
In pwc Kconfig, change 'depends' to 'depends on'
In dvb-core Makefile, change '=' to ':='Signed-off-by: Trent Piepho
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Mauro Carvalho Chehab
-
Config option typo:
-#ifdef CONFIG_V4L1_COMPAT
+#ifdef CONFIG_VIDEO_V4L1_COMPATSigned-off-by: Mauro Carvalho Chehab
-
The compat_ioctl support of the pwc driver was dropped during the last update of the driver.
I suppose it was by mistake. If yes here is the patch to restore the support.Signed-off-by: Luc Van Oostenryck
Signed-off-by: Mauro Carvalho Chehab -
Compat32 should be able to handle V4L1 ioctls if the old API support were
selected.Signed-off-by: Mauro Carvalho Chehab
30 Jul, 2006
22 commits
-
A previous patch changed VBI_OFFSET to match what the datasheets say it
should be. However, the bt8x8 datasheets are wrong. The old value of
244 is closer to what is actually observed. The real value appears to
not be constant and is different for different chip revisions.
Acked-by: Alan CoxSigned-off-by: Trent Piepho
Signed-off-by: Mauro Carvalho Chehab -
Errors are return values < 0, not != 0.
Signed-off-by: Trent Piepho
Signed-off-by: Mauro Carvalho Chehab -
Take note of which sysfs files / groups that the pvrusb2 successfully
creates and only delete those specific items when tearing things
down. (Previously we just blindly tore everything down every time.)Signed-off-by: Mike Isely
Signed-off-by: Mauro Carvalho Chehab -
Revert bttv-driver.c from video_device_create_file() to use
class_device_create_file() again. video_device_create_file() is only
available when V4L1 is on.
Proper error checking is added for failure of class_device_create_file().
Will print error message and unroll partially created sysfs entries.Signed-off-by: Trent Piepho
Signed-off-by: Mauro Carvalho Chehab -
Add proper error checking and roll-back for failure of
class_device_create_file() in videodev.c. Print error messages and
unroll partially created sysfs entries.
Also, failure of class_device_register() in video_register_device() is
handled correctly. It was failing to de-allocate the minor number. This
must be done in video_register_device(), since the caller has no way of
knowing if failure occurred before or after the class device was
registered.
Also added an error message if video_register_device() is called with
an unknown type, which should never happen.Signed-off-by: Trent Piepho
Signed-off-by: Mauro Carvalho Chehab -
A patch from Aug, 17 activated by mistake OVERLAY flag on cx88-video,
together with several cx88-blackbird cleanups. This makes the cx88 driver
to report:
/dev/video0 [v4l2]: ioctl VIDIOC_G_FBUF: Invalid argument
instead of:
/dev/video0 [v4l2]: no overlay supportSigned-off-by: Mauro Carvalho Chehab
-
Signed-off-by: Mauro Carvalho Chehab
-
Removed usage of HAVE_V4L1
Including videodev.h will just include videodev2.h if V4L1 is not supported
V4L1 code at core drivers will honor CONFIG_V4L1_COMPAT stuffSigned-off-by: Mauro Carvalho Chehab
-
video_code size is 24 on i386 and 32 on x86_64, so a proper handling is needed
on compat_ioctl32 to fix it.
This code should be tested, since just *a few* boards use this ioctl.Signed-off-by: Mauro Carvalho Chehab
-
Trent Piepho pointed out that the pll test i2c transmission is slightly
wrong; it was transmitting a zero length message, and then reading from the
PLL. This was wrong; it should only be transmitting a single read i2c message.Signed-off-by: Andrew de Quincey
Signed-off-by: Mauro Carvalho Chehab -
Supplying a NULL i2c adapter to dvb_pll_attach is allowed, for example with
mt352 demods. However, the pll i2c probe will segfault because it does not
check for this.Signed-off-by: Andrew de Quincey
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Mike Isely
Signed-off-by: Mauro Carvalho Chehab -
Fix bug reported by Andrew de Quincey:
After cold boot the saa7146 DMA did not start if the demuxer was opened
before the frontend has locked to the signal.
DMA transfers will be started now if (and only if)
the frontend is locked and data should be sent to the demuxer.Signed-off-by: Oliver Endriss
Signed-off-by: Mauro Carvalho Chehab -
Check __must_check warnings for class_device_register and class_device_create_file
video_device_create_file was declared as a void, but instead should
return the int value of class_device_create_file.Move the check from bttv-driver.c into v4l2-dev.h, because all other
callers of video_device_create_file must also be checked.Replace the call to class_device_create_file in videodev.c with
video_device_create_file, as defined in v4l2-dev.h, so that the
return value of class_device_create_file will be checked.Check the return value of class_device_register in videodev.c and
pvrusb2-sysfs.cSigned-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
With the LG H06xF tuners, an auxiliary byte must be sent after the
standard four-byte i2c sequence. The code that does this is currently in
the wrong place, causing random bytes to be written to the tuner over
i2c in the set_type function.
This patch moves this code from set_type to default_set_tv_freq.Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
Fix keycode calculations (all codes for this remote were wrong due to a
lost + sign)Signed-off-by: Ricardo Cerqueira
Signed-off-by: Mauro Carvalho Chehab -
Two different exports with the same name are not a good idea:
$ grep -r EXPORT_SYMBOL\(dmasound_init\) *
drivers/media/video/saa7134/saa7134-core.c:EXPORT_SYMBOL(dmasound_init);
sound/oss/dmasound/dmasound_core.c:EXPORT_SYMBOL(dmasound_init);
$
This patch renames the saa7134 dmasound_{init,exit} to
saa7134_dmasound_{init,exit}.Signed-off-by: Adrian Bunk
Signed-off-by: Mauro Carvalho Chehab -
This patch just sets the option noninterlaced to 1 by default since
it has no known disadvantages. It is still possibe to get the old
behaviour by setting noninterlaced=0.Signed-off-by: Hartmut Hackmann
Signed-off-by: Mauro Carvalho Chehab -
Signed-off-by: Randy Dunlap
Signed-off-by: Mauro Carvalho Chehab -
To prevent autoloading of the driver, as it then conflicts with every other
saa7146 device in existence.Signed-off-by: Andrew de Quincey
Signed-off-by: Mauro Carvalho Chehab -
Fix typo in comment for TDA9819
Signed-off-by: Marco Schluessler
Signed-off-by: Andrew de Quincey
Signed-off-by: Mauro Carvalho Chehab -
It was pointed out on the mailing list that this PLL definition is broken. I
went back to the original dibusb driver and confirmed it used to use these
settings, as well as consulting the datasheet.Signed-off-by: Andrew de Quincey
Signed-off-by: Mauro Carvalho Chehab
