Eric Lee / linux-smarc-t335x-v3.2

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

05 Dec, 2008

1 commit

  • c2e27c359   sparc: Add missing of_node_put ... Browse Code »

    of_node_put is needed before discarding a value received from
    of_find_node_by_name, eg in error handling code or when the device
    node is no longer used.

    The semantic match that catches the bug is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @r exists@
    local idexpression struct device_node *n;
    position p1, p2;
    struct device_node *n1;
    statement S;
    identifier f;
    expression E;
    expression *ptr != NULL;
    @@

    n@p1 = of_find_node_by_name(...)
    ...
    if (!n) S
    ... when != of_node_put(n)
    when != n1 = f(n,...)
    when != E = n
    when any
    when strict
    (
    return \(0\|\|ptr\);
    |
    return@p2 ...;
    |
    of_node_put(n);
    |
    n1 = f(n,...)
    |
    E = n
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    print "* file: %s of_find_node_by_name %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
    //

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Nicolas Palix
     

20 Sep, 2008

6 commits

01 Sep, 2008

1 commit

  • 5110bd21b   sparc: remove CONFIG_SUN4 ... Browse Code »

    While doing some easy cleanups on the sparc code I noticed that the
    CONFIG_SUN4 code seems to be worse than the rest - there were some
    "I don't know how it should work, but the current code definitely cannot
    work." places.

    And while I have seen people running Linux on machines like a
    SPARCstation 5 a few years ago I don't recall having seen sun4
    machines, even less ones running Linux.

    Signed-off-by: Adrian Bunk
    Signed-off-by: David S. Miller

    Adrian Bunk
     

29 Aug, 2008

2 commits

18 Jul, 2008

1 commit

  • c61c65cdc   sparc/kernel/: possible cleanups ... Browse Code »

    This patch contains the following possible cleanups:
    - make the following needlessly global code static:
    - apc.c: apc_swift_idle()
    - ebus.c: ebus_blacklist_irq()
    - ebus.c: fill_ebus_child()
    - ebus.c: fill_ebus_device()
    - entry.S: syscall_is_too_hard
    - etra: tsetup_sun4c_stackchk
    - head.S: cputyp
    - head.S: prom_vector_p
    - idprom.c: Sun_Machines[]
    - ioport.c: _sparc_find_resource()
    - ioport.c: create_proc_read_entry()
    - irq.c: struct sparc_irq[]
    - rtrap.S: sun4c_rett_stackchk
    - setup.c: prom_sync_me()
    - setup.c: boot_flags
    - sun4c_irq.c: sun4c_sbint_to_irq()
    - sun4d_irq.c: sbus_tid[]
    - sun4d_irq.c: struct sbus_actions
    - sun4d_irq.c: sun4d_sbint_to_irq()
    - sun4m_irq.c: sun4m_sbint_to_irq()
    - sun4m_irq.c: sun4m_get_irqmask()
    - sun4m_irq.c: sun4m_timers
    - sun4m_smp.c: smp4m_cross_call()
    - sun4m_smp.c: smp4m_blackbox_id()
    - sun4m_smp.c: smp4m_blackbox_current()
    - time.c: sp_clock_typ
    - time.c: sbus_time_init()
    - traps.c: instruction_dump()
    - wof.S: spwin_sun4c_stackchk
    - wuf.S: sun4c_fwin_stackchk
    - #if 0 the following unused code:
    - process.c: sparc_backtrace_lock
    - process.c: __show_backtrace()
    - process.c: show_backtrace()
    - process.c: smp_show_backtrace_all_cpus()
    - remove the following unused code:
    - entry.S: __handle_exception
    - smp.c: smp_num_cpus
    - smp.c: smp_activated
    - smp.c: __cpu_number_map[]
    - smp.c: __cpu_logical_map[]
    - smp.c: bitops_spinlock
    - traps.c: trap_curbuf
    - traps.c: trapbuf[]
    - traps.c: linux_smp_still_initting
    - traps.c: thiscpus_tbr
    - traps.c: thiscpus_mid

    Signed-off-by: Adrian Bunk
    Signed-off-by: David S. Miller

    Adrian Bunk
     

22 Jul, 2007

1 commit

09 Oct, 2006

2 commits

03 Jul, 2006

1 commit

01 Jul, 2006

1 commit

20 Jun, 2006

1 commit

  • c6387a48c   [SPARC]: Kill __irq_itoa(). ... Browse Code »

    This ugly hack was long overdue to die.

    It was a way to print out Sparc interrupts in a more freindly format,
    since IRQ numbers were arbitrary opaque 32-bit integers which vectored
    into PIL levels. These 32-bit integers were not necessarily in the
    0-->NR_IRQS range, but the PILs they vectored to were.

    The idea now is that we will increase NR_IRQS a little bit and use a
    virtualreal IRQ number mapping scheme similar to PowerPC.

    That makes this IRQ printing hack irrelevant, and furthermore only a
    handful of drivers actually used __irq_itoa() making it even less
    useful.

    Signed-off-by: David S. Miller

    David S. Miller
     

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds