17 Jul, 2008
40 commits
-
Remove some code which has been made obsolete and hasn't worked properly
before anyway. Part of the infrastructure may be reintroduced in a
follow up patch to implement a working command aborting facility.Signed-off-by: Elias Oltmanns
Cc: "Alan Cox"
Cc: "Randy Dunlap"
Signed-off-by: Bartlomiej Zolnierkiewicz -
Currently, the code path executing an HDIO_DRIVE_RESET ioctl is broken
in various ways. Most importantly, it is treated as an out of band
request in an illegal way which may very likely lead to system lock ups.
Use the drive's request queue to avoid this problem (and fix a locking
issue for free along the way).Signed-off-by: Elias Oltmanns
Cc: "Alan Cox"
Cc: "Randy Dunlap"
Signed-off-by: Bartlomiej Zolnierkiewicz -
The code that needed this #include was removed one year ago.
Signed-off-by: Adrian Bunk
Cc: rmk@arm.linux.org.uk
Cc: Alan Cox
Signed-off-by: Bartlomiej Zolnierkiewicz -
Many people will see this option the first time now that it is in
drivers/block/Make it clear that virtually noone needs it.
Signed-off-by: Adrian Bunk
Cc: rmk@arm.linux.org.uk
Cc: Alan Cox
Signed-off-by: Bartlomiej Zolnierkiewicz -
This patch moves hd.c to drivers/block/
Signed-off-by: Adrian Bunk
Cc: rmk@arm.linux.org.uk
Cc: Alan Cox
Signed-off-by: Bartlomiej Zolnierkiewicz -
Since the later move to drivers/block/ will break the link order,
the module_init() has to become a late_initcall().Signed-off-by: Adrian Bunk
Cc: rmk@arm.linux.org.uk
Cc: Alan Cox
Signed-off-by: Bartlomiej Zolnierkiewicz -
After commit 80aa31cb460d12c1e02327b43eceb3eebc6e7090
(ide: remove CONFIG_BLK_DEV_HD_IDE config option (take 2))
the indirection through BLK_DEV_HD_ONLY is no longer required.Signed-off-by: Adrian Bunk
Cc: rmk@arm.linux.org.uk
Cc: Alan Cox
Signed-off-by: Bartlomiej Zolnierkiewicz -
Signed-off-by: Harvey Harrison
Cc: Al Viro
Cc: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
This is a precaution just to make sure a new pc is clean when allocated.
There should be no functional change introduced by this patch.
[bart: ported it over IDE changes]
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
There's no need for this function since it is used only once.
[bart: ported it over IDE changes]
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
As a nice side effect, this minimizes the IRQ handler execution time.
There should be no functionality change resulting from this patch.
[bart: remove extra newlines from ide_cd_do_request()]
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
... by factoring out the rq preparation code into a separate
function called in the request routine. As a nice side effect,
this minimizes the IRQ handler execution time.There should be no functionality change resulting from this patch.
[bart: s/HWGROUP()/drive->hwif->hwgroup/ and remove extra newline]
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
... by factoring out the rq preparation code into a separate
function called in the request routine. As a nice side effect,
this minimizes the IRQ handler execution time.There should be no functionality change resulting from this patch.
[bart: s/HWGROUP()/drive->hwif->hwgroup/ and remove extra newlines]
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Do what the compiler does anyway: inline a function that is used only once.
This saves us the overhead of a function call and the function is small enough
to be embedded in the callsite anyways.Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Call cdrom_start_packet_command() only from the ->do_request() routine.
As a nice side effect, this improves code readability a bit.There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Use the generic ide_pad_transfer() helper instead.
[bart: fixup ide_cd_drain_data() -> ide_pad_transfer() conversion]
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
This is done in the request issue path anyway.
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Move ide_find_port_slot() call closer to ide_device_add().
This is basically a preparation for the future changes.
Cc: Jeremy Higdon
Signed-off-by: Bartlomiej Zolnierkiewicz -
Move ide_find_port_slot() call closer to ide_device_add().
This is basically a preparation for the future changes.
Cc: Maciej W. Rozycki
Signed-off-by: Bartlomiej Zolnierkiewicz -
Try to probe first interface even if ide_hwifs[]'s slot for the second
interface cannot be obtained.While at it:
- Add DRV_NAME define and use it for request_dma() instead of hwif->name.
Cc: Russell King
Signed-off-by: Bartlomiej Zolnierkiewicz -
Return -ENOENT on ide_find_port() failure.
While at it:
- Cleanup rapide_probe() a bit.
Cc: Russell King
Signed-off-by: Bartlomiej Zolnierkiewicz -
v2:
* sparc build fix. (From Stephen Rothwell)Signed-off-by: Bartlomiej Zolnierkiewicz
-
v2:
On Sunday 15 June 2008, Geert Uytterhoeven wrote:
> As ide-taskfile.c uses scatterlists, it should include .(v1 broke IDE build on m68k, thanks to Geert for finding the bug)
Cc: Geert Uytterhoeven
Signed-off-by: Bartlomiej Zolnierkiewicz -
Signed-off-by: Bartlomiej Zolnierkiewicz
-
ide_set_handler() bugs on ->handler == NULL so no need to do it
in set_geometry_intr().There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Allow any command requesting DMA data phase for HDIO_DRIVE_TASKFILE ioctl
and remove no longer needed task_dma_ok()Signed-off-by: Bartlomiej Zolnierkiewicz
-
Print driver banner message early and without interface number.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Print driver banner message early and without interface number.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
* Add DRV_NAME define to ide-h8300.c.
* Fix ide-h8300.c, swarm.c and sgiioc4.c to set .name field in
struct ide_port_info to DRV_NAME, then convert these host drivers
to use ide_find_port_slot() instead of ide_find_port().* Print message on error in ide_find_port_slot().
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Convert the driver to use struct ide_port_info.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Convert the driver to use struct ide_port_info.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Convert the driver to use struct ide_port_info.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Convert the driver to use ->init_dev method instead of open-coding devices
init in cmd640x_init().While at it:
- fix printk()-s to use KERN_INFO level instead of the default KERN_ERR
- use DRV_NAME define in printk()-s
- set proper ->pio_mask also for CONFIG_BLK_DEV_CMD640_ENHANCED=n
There should be no functional changes caused by this patch
(except fixing printk()-s levels).Signed-off-by: Bartlomiej Zolnierkiewicz
-
Change ->port_init_devs method to take 'ide_drive_t *' as an argument
instead of 'ide_hwif_t *' and rename it to ->init_dev.There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Register secondary interface also when user requested not to probe devices.
While at it:
- remove write-only second_port_toggled variable
Signed-off-by: Bartlomiej Zolnierkiewicz
-
This driver was only used by arch/ppc code and is obsolete
now with the move to common arch/powerpc code.[bart: port it over IDE tree, remove leftover 'choice' from Kconfig]
Signed-off-by: Arnd Bergmann
Acked-by: Kumar Gala
Cc: Paul Mackerras
Signed-off-by: Bartlomiej Zolnierkiewicz -
Convert the driver to use struct ide_port_info.
There should be no functional changes caused by this patch.
Acked-by: Maciej W. Rozycki
Tested-by: Maciej W. Rozycki
Signed-off-by: Bartlomiej Zolnierkiewicz