24 Mar, 2011

13 commits


18 Feb, 2011

1 commit


22 Dec, 2010

12 commits


17 Nov, 2010

1 commit

  • Move the mid-layer's ->queuecommand() invocation from being locked
    with the host lock to being unlocked to facilitate speeding up the
    critical path for drivers who don't need this lock taken anyway.

    The patch below presents a simple SCSI host lock push-down as an
    equivalent transformation. No locking or other behavior should change
    with this patch. All existing bugs and locking orders are preserved.

    Additionally, add one parameter to queuecommand,
    struct Scsi_Host *
    and remove one parameter from queuecommand,
    void (*done)(struct scsi_cmnd *)

    Scsi_Host* is a convenient pointer that most host drivers need anyway,
    and 'done' is redundant to struct scsi_cmnd->scsi_done.

    Minimal code disturbance was attempted with this change. Most drivers
    needed only two one-line modifications for their host lock push-down.

    Signed-off-by: Jeff Garzik
    Acked-by: James Bottomley
    Signed-off-by: Linus Torvalds

    Jeff Garzik
     

27 Oct, 2010

1 commit

  • If the command has timedout then the block layer has called
    blk_mark_rq_complete. If qla4xxx_cmd_wait is then called
    from qla4xxx_eh_host_reset, we will always fail, because if
    the driver calls scsi_done then the the block layer will fail
    at blk_complete_request's blk_mark_rq_complete call instead of
    calling the normal completion path including the function,
    blk_queue_end_tag, which releases the tag.

    Signed-off-by: Mike Christie
    Signed-off-by: Vikas Chaudhary
    Signed-off-by: James Bottomley

    Mike Christie
     

26 Oct, 2010

12 commits