24 Mar, 2011
1 commit
-
Signed-off-by: Vasiliy Kulikov
Acked-by: Mike Christie
Signed-off-by: James Bottomley
25 Feb, 2011
3 commits
-
For drivers using the ep callbacks the addr and port
are attached to the endpoint instead of the conn.
This adds a callout to the iscsi_transport to get
ep values. It also adds locking around the get
param call to make sure that ep_disconnect does
not free the LLD's ep interconnect structs from
under us (the ep has a refcount so it will not
go away but the LLD may have structs from other
subsystems that are not allocated in the ep so
we need to protect them from getting freed).Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
The active variable on the iscsi_cls_conn is not used
so this patch removes it.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
When iscsid restarts it does not know the connection's
endpoint, so it is getting leaked. This fixes the problem
by having the iscsi class force a disconnect before a
new connection is bound.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
22 Dec, 2010
1 commit
-
Since iscsi transport can be built as a module and uses netlink socket
to communicate. The module should have an alias to autoload when socket
of NETLINK_ISCSI type is requested.Signed-off-by: Stephen Hemminger
Acked-by: Mike Christie
Signed-off-by: James Bottomley
10 Sep, 2010
1 commit
-
Fix typo in scsi_transport_iscsi.c kernel-doc notation:
Warning(drivers/scsi/scsi_transport_iscsi.c:548): No description found for parameter 'cmd'
Signed-off-by: Randy Dunlap
Acked-by: Mike Christie
Signed-off-by: James Bottomley
28 Jul, 2010
3 commits
-
wait for session to come online in eh_device_reset_handler
and eh_target_reset_handlerSigned-off-by: Mike Christie
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Signed-off-by: James Bottomley -
Added support to modify session->recovery_tmo from sysfs
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Acked-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
30 Mar, 2010
1 commit
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
05 Dec, 2009
2 commits
-
This patch modifies the replacement/recovery_timeout so it works
more like the fc fast io fail tmo.If userspace tries to set the replacement/recovery_timeout to less than
zero, we will turn off the forced recovery cleanup.If userspace sets the value to 0 then we will force the recovery
cleanup immediately.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This implements warm target reset tmf support for
the scsi-ml target reset callback. Previously we would
just drop the session in that callback. This patch will
now try a target reset and if that fails drop the session.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
05 Sep, 2009
1 commit
-
Logging for connections and sessions in the scsi_transport_iscsi module
is now controlled by module parameters.Signed-off-by: Erez Zilber
[Mike Christie: newline fixups and modification of some dbg statements]
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
31 Jul, 2009
1 commit
-
Changing to GFP_ATOMIC because the only caller in cnic/bnx2i may
be calling this function while holding spin_lock.This problem was discovered by Mike Christie.
Signed-off-by: Michael Chan
Acked-by: Mike Christie
Signed-off-by: David S. Miller
22 Jun, 2009
1 commit
-
setting err as -EOVERFLOW for Too many iscsi targets.
Also fixes a spurious compiler warning for gcc 4.3.3 and gcc 4.4 :
CC drivers/scsi/scsi_transport_iscsi.o
drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this functionSigned-off-by: Jaswinder Singh Rajput
Acked-by: Mike Christie
Signed-off-by: James Bottomley
09 Jun, 2009
1 commit
-
Add ISCSI_NETLINK messages for iSCSI NICs to get information such as
path from userspace. Original iscsid messages are now always sent as
multicast to group 1. The new messages are sent to group 2.The multicast changes were made by Mike Christie.
Signed-off-by: Michael Chan
Signed-off-by: Benjamin Li
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
24 May, 2009
1 commit
-
When we create the tcp/ip connection by calling ep_connect, we currently
just go by the routing table info.I think there are two problems with this.
1. Some drivers do not have access to a routing table. Some drivers like
qla4xxx do not even know about other ports.2. If you have two initiator ports on the same subnet, the user may have
set things up so that session1 was supposed to be run through port1. and
session2 was supposed to be run through port2. It looks like we could
end with both sessions going through one of the ports.Fixes for cxgb3i from Karen Xie.
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
16 May, 2009
1 commit
-
Andrew Vasquez wrote:
> fc-transport: Close state transition-window during rport deletion.
>
> After an rport's state has transitioned to FC_PORTSTATE_BLOCKED,
> but, prior to making the upcall to 'block' the scsi-target
> associated with an rport, queued commands can recycle and
> ultimately run out of retries causing failures to propagate to
> upper-level drivers. Close this transition-window by returning
> the non-'retries' modifying DID_IMM_RETRY status for submitted
> I/Os.The same can happen for iscsi when transitioning from logged in
to failed and blocking the sdevs.This patch converts iscsi and fc's transitions back to use DID_IMM_RETRY
instead of DID_TRANSPORT_DISRUPTED which has a limited number of retries
that we do not want to use for handling this race.Signed-off-by: Andrew Vasquez
[Addition of iscsi and fc port online devloss case conversion by Mike Christie]
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
29 Mar, 2009
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (119 commits)
[SCSI] scsi_dh_rdac: Retry for NOT_READY check condition
[SCSI] mpt2sas: make global symbols unique
[SCSI] sd: Make revalidate less chatty
[SCSI] sd: Try READ CAPACITY 16 first for SBC-2 devices
[SCSI] sd: Refactor sd_read_capacity()
[SCSI] mpt2sas v00.100.11.15
[SCSI] mpt2sas: add MPT2SAS_MINOR(221) to miscdevice.h
[SCSI] ch: Add scsi type modalias
[SCSI] 3w-9xxx: add power management support
[SCSI] bsg: add linux/types.h include to bsg.h
[SCSI] cxgb3i: fix function descriptions
[SCSI] libiscsi: fix possbile null ptr session command cleanup
[SCSI] iscsi class: remove host no argument from session creation callout
[SCSI] libiscsi: pass session failure a session struct
[SCSI] iscsi lib: remove qdepth param from iscsi host allocation
[SCSI] iscsi lib: have lib create work queue for transmitting IO
[SCSI] iscsi class: fix lock dep warning on logout
[SCSI] libiscsi: don't cap queue depth in iscsi modules
[SCSI] iscsi_tcp: replace scsi_debug/tcp_debug logging with iscsi conn logging
[SCSI] libiscsi_tcp: replace tcp_debug/scsi_debug logging with session/conn logging
...
14 Mar, 2009
2 commits
-
We do not need to have llds set the host no for the session's
parent, because we know the session's parent is going to be
the host. This removes it from the session creation callback
and converts the drivers.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
We never should hit the lock up that is spit out when
lock dep is on and we logout. But we have been using the
shost work queue in a odd way. This patch has us use the
work queue for scanning instead of creating our own,
and this ends up also killing the lock dep warnings.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
06 Feb, 2009
1 commit
-
Currently, netlink_broadcast() reports errors to the caller if no
messages at all were delivered:1) If, at least, one message has been delivered correctly, returns 0.
2) Otherwise, if no messages at all were delivered due to skb_clone()
failure, return -ENOBUFS.
3) Otherwise, if there are no listeners, return -ESRCH.With this patch, the caller knows if the delivery of any of the
messages to the listeners have failed:1) If it fails to deliver any message (for whatever reason), return
-ENOBUFS.
2) Otherwise, if all messages were delivered OK, returns 0.
3) Otherwise, if no listeners, return -ESRCH.In the current ctnetlink code and in Netfilter in general, we can add
reliable logging and connection tracking event delivery by dropping the
packets whose events were not successfully delivered over Netlink. Of
course, this option would be settable via /proc as this approach reduces
performance (in terms of filtered connections per seconds by a stateful
firewall) but providing reliable logging and event delivery (for
conntrackd) in return.This patch also changes some clients of netlink_broadcast() that
may report ENOBUFS errors via printk. This error handling is not
of any help. Instead, the userspace daemons that are listening to
those netlink messages should resync themselves with the kernel-side
if they hit ENOBUFS.BTW, netlink_broadcast() clients include those that call
cn_netlink_send(), nlmsg_multicast() and genlmsg_multicast() since they
internally call netlink_broadcast() and return its error value.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: David S. Miller
03 Jan, 2009
1 commit
-
[jejb: limit ioctl to returning 20 characters to avoid overrun
on long device names and add a few more conversions]
Signed-off-by: Kay Sievers
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: James Bottomley
13 Oct, 2008
3 commits
-
Some endpoint code was using unsigned int and some
was using uint64_t. This converts it all to uint64_t.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
If the driver knows when hardware is removed like with cxgb3i,
bnx2i, qla4xxx and iser then we will want to remove the sessions/devices
that are bound to that device before removing the host.cxgb3i and in the future bnx2i will remove the host and that will
remove all the sessions on the hba. iser can call iscsi_kill_session
when it gets an event that indicates that a hca is removed.
And when qla4xxx is hooked in to the lib (it is only hooked into
the class right now) it can call iscsi remove host like the
partial offload card drivers.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This patch converts the iscsi drivers to the new host byte values.
v2
Drop some conversions. Want to avoid conflicts with other patches.
v1
initial patch.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
04 Oct, 2008
1 commit
-
This patch cleans up the behavior of scsi_host_lookup().
The original implementation attempted to use the dual role of
either returning a pointer value, or a negative error code.
User's needed to use IS_ERR() to check the result. Additionally,
the IS_ERR() macro never checks for when a NULL pointer was
returned, so a NULL pointer actually passes with a success case.
Note: scsi_host_get(), used by scsi_host_lookup(), can return
a NULL pointer.Talk about a mudhole for the unitiated to step into....
This patch converts scsi_host_lookup() to return either NULL
or a valid pointer. The consumers were updated for the change.Signed-off-by: James Smart
Signed-off-by: James Bottomley
22 Jul, 2008
2 commits
-
Kobjects do not have a limit in name size since a while, so stop
pretending that they do.Signed-off-by: Kay Sievers
Signed-off-by: Greg Kroah-Hartman -
This mirrors the functionality that driver_find_device has as well.
We add a start variable, and all callers of the function are fixed up at
the same time.The block layer will be using this new functionality in a follow-on
patch.Cc: Kay Sievers
Signed-off-by: Greg Kroah-Hartman
12 Jul, 2008
11 commits
-
class_find_device gets a ref to the device so we must release it.
The class will serialize access to the ep so we do not have to worry
about a remove racing with the callers access, so we can simplify the
use and drop the ref right away.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Update iscsi class version number.
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Must do a module_out if the endpoint lookup fails.
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This adds two new attrs used for creating initiator ports and
binding sessions to hardware.The session level initiatorname:
Since bnx2i does a scsi_host per host device, we need to add the
iface initiator port settings on the session, so we can create
multiple initiator ports (each with different inames) per device/scsi_host.The current iname reflects that qla4xxx can have one iname per hba, and we are
allocating a host per session for software. The iname on the host will
remain so we can export and set the hba level qla4xxx setting.The ifacename attr:
To bind a session to a some peice of hardware in userspace we maintain
some mappings, but during boot or iscsid restart (iscsid contains the user
space part of the driver) we need to be able to figure out which of those
host mappings abstractions maps to certain sessions. This patch adds
a ifacename attr, which userspace can set to id the host side of the
endpoint across pivot_roots and iscsid restarts.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Add sysfs representation for the endpoint, so userspace can match the
host and session to the endpoint. This will allow us to set the host's
parent correctly at host creation time.The next patches will convert tcp and iser, and fix iser's dma_mask
bug.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Currently we duplicate the list of sessions, because we were using the
test for if a session was on the host list to indicate if the session
was bound or unbound. We can instead use the target_id and fix up
the class so that drivers like bnx2i do not have to manage the target id
space.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This removes the session and conn data_size fields from the iscsi_transport.
Just pass in the value like with host allocation. This patch also makes
it so the LLD iscsi_conn data is allocated with the iscsi_cls_conn.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This finishes the host/session unbinding, by adding some helpers
to add and remove hosts and the session they manage.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
bnx2i allocates a host per netdevice but will use libiscsi,
so this unbinds the session from the host in that code.This will also be useful for the iser parent device dma settings
fixes.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This renames the iscsi_host to iscsi_cls_host to match the other
structs, because libiscsi wants to use the iscsi_host name in
the future.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
max_cmd_len and max_conn are not really used. max_cmd_len is
always 16 and can be set by the LLD. max_conn is always one
since we do not support MCS.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley