06 Jan, 2009

1 commit


30 Dec, 2008

2 commits

  • ARRAY_SIZE is more concise to use when the size of an array is divided by
    the size of its type or the size of its first element.

    Signed-off-by: Julia Lawall
    Acked-by: "Prakash, Sathya"
    Signed-off-by: James Bottomley

    Julia Lawall
     
  • Remove excess kernel-doc function parameter notation:

    Warning(drivers/message/fusion/mptbase.c:964): Excess function parameter or struct member 'handle' description in 'mpt_free_msg_frame'
    Warning(drivers/message/fusion/mptbase.c:5434): Excess function parameter or struct member 'portnum' description in 'mpt_findImVolumes'
    Warning(drivers/message/fusion/mptbase.c:6949): Excess function parameter or struct member 'mr' description in 'mpt_spi_log_info'

    Signed-off-by: Randy Dunlap
    cc: Eric.Moore@lsi.com
    Signed-off-by: James Bottomley

    Randy Dunlap
     

29 Dec, 2008

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1429 commits)
    net: Allow dependancies of FDDI & Tokenring to be modular.
    igb: Fix build warning when DCA is disabled.
    net: Fix warning fallout from recent NAPI interface changes.
    gro: Fix potential use after free
    sfc: If AN is enabled, always read speed/duplex from the AN advertising bits
    sfc: When disabling the NIC, close the device rather than unregistering it
    sfc: SFT9001: Add cable diagnostics
    sfc: Add support for multiple PHY self-tests
    sfc: Merge top-level functions for self-tests
    sfc: Clean up PHY mode management in loopback self-test
    sfc: Fix unreliable link detection in some loopback modes
    sfc: Generate unique names for per-NIC workqueues
    802.3ad: use standard ethhdr instead of ad_header
    802.3ad: generalize out mac address initializer
    802.3ad: initialize ports LACPDU from const initializer
    802.3ad: remove typedef around ad_system
    802.3ad: turn ports is_individual into a bool
    802.3ad: turn ports is_enabled into a bool
    802.3ad: make ntt bool
    ixgbe: Fix set_ringparam in ixgbe to use the same memory pools.
    ...

    Fixed trivial IPv4/6 address printing conflicts in fs/cifs/connect.c due
    to the conversion to %pI (in this networking merge) and the addition of
    doing IPv6 addresses (from the earlier merge of CIFS).

    Linus Torvalds
     

20 Dec, 2008

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6:
    [SCSI] mpt fusion: clear list of outstanding commands on host reset
    [SCSI] scsi_lib: only call scsi_unprep_request() under queue lock
    [SCSI] ibmvstgt: move crq_queue_create to the end of initialization
    [SCSI] libiscsi REGRESSION: fix passthrough support with older iscsi tools
    [SCSI] aacraid: disable Dell Percraid quirk on Adaptec 2200S and 2120S

    Linus Torvalds
     

17 Dec, 2008

1 commit

  • A bug in the fusion driver was exposed by the switch to block timeout.
    Basically, drivers are supposed to terminate commands once error
    handling begins on them. The fusion apparently wasn't doing this.
    Under the old timeout regime, completions on terminated commands would
    by and large get ignored because of the way command timeouts used to
    work. The new block timers are very intolerant to this, though,
    becuase the request gets cleaned and freed.

    Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=12195

    Reported-by: Alex Shi
    Tested-by: Ming Lin
    Cc: Eric Moore
    Signed-off-by: James Bottomley

    James Bottomley
     

16 Dec, 2008

1 commit


06 Dec, 2008

2 commits


04 Dec, 2008

1 commit


12 Nov, 2008

1 commit


08 Nov, 2008

1 commit


07 Nov, 2008

1 commit


02 Nov, 2008

1 commit

  • As it is, all instances of ->release() for files that have ->fasync()
    need to remember to evict file from fasync lists; forgetting that
    creates a hole and we actually have a bunch that *does* forget.

    So let's keep our lives simple - let __fput() check FASYNC in
    file->f_flags and call ->fasync() there if it's been set. And lose that
    crap in ->release() instances - leaving it there is still valid, but we
    don't have to bother anymore.

    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     

31 Oct, 2008

2 commits

  • Conflicts:

    drivers/net/wireless/p54/p54common.c

    David S. Miller
     
  • Fixup i2o kernel-doc warnings:

    Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'bdev'
    Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'mode'
    Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'disk'
    Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'mode'
    Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'bdev'
    Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'mode'

    Signed-off-by: Randy Dunlap
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

28 Oct, 2008

1 commit

  • A number of places still use %02x:...:%02x because it's
    in debug statements or for no real reason. Make a few
    of them use %pM.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

24 Oct, 2008

2 commits

  • * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (21 commits)
    [SCSI] sd: fix computation of the full size of the device
    [SCSI] lib: string_get_size(): don't hang on zero; no decimals on exact
    [SCSI] sun3x_esp: Convert && to ||
    [SCSI] sd: remove command-size switching code
    [SCSI] 3w-9xxx: remove unnecessary local_irq_save/restore for scsi sg copy API
    [SCSI] 3w-xxxx: remove unnecessary local_irq_save/restore for scsi sg copy API
    [SCSI] fix netlink kernel-doc
    [SCSI] sd: Fix handling of NO_SENSE check condition
    [SCSI] export busy state via q->lld_busy_fn()
    [SCSI] refactor sdev/starget/shost busy checking
    [SCSI] mptfusion: Increase scsi-timeouts, similariy to the LSI 4.x driver.
    [SCSI] aic7xxx: Take the LED out of diagnostic mode on PM resume
    [SCSI] aic79xx: user visible misuse wrong SI units (not disk size!)
    [SCSI] ipr: use memory_read_from_buffer()
    [SCSI] aic79xx: fix shadowed variables
    [SCSI] aic79xx: fix shadowed variables, add statics
    [SCSI] aic7xxx: update *_shipped files
    [SCSI] aic7xxx: update .reg files
    [SCSI] aic7xxx: introduce "dont_generate_debug_code" keyword in aicasm parser
    [SCSI] scsi_dh: Initialize path state to be passive when path is not owned
    ...

    Linus Torvalds
     
  • Make SPI timeout 10s the same as SAS

    Signed-off-by: Bernd Schubert
    Acked-by: "Prakash, Sathya"
    Signed-off-by: James Bottomley

    Bernd Schubert
     

21 Oct, 2008

2 commits

  • Signed-off-by: Al Viro

    Al Viro
     
  • To keep the size of changesets sane we split the switch by drivers;
    to keep the damn thing bisectable we do the following:
    1) rename the affected methods, add ones with correct
    prototypes, make (few) callers handle both. That's this changeset.
    2) for each driver convert to new methods. *ALL* drivers
    are converted in this series.
    3) kill the old (renamed) methods.

    Note that it _is_ a flagday; all in-tree drivers are converted and by the
    end of this series no trace of old methods remain. The only reason why
    we do that this way is to keep the damn thing bisectable and allow per-driver
    debugging if anything goes wrong.

    New methods:
    open(bdev, mode)
    release(disk, mode)
    ioctl(bdev, mode, cmd, arg) /* Called without BKL */
    compat_ioctl(bdev, mode, cmd, arg)
    locked_ioctl(bdev, mode, cmd, arg) /* Called with BKL, legacy */

    Signed-off-by: Al Viro

    Al Viro
     

17 Oct, 2008

1 commit

  • The I2O ioctls assume 32bits. In itself that is fine as they are old
    cards and nobody uses 64bit. However on LKML it was noted this
    assumption is also made for allocated memory and is unsafe on 64bit
    systems.

    Fixing this is a mess. It turns out there is tons of crap buried in a
    header file that does racy 32/64bit filtering on the masks.

    So we:
    - Verify all callers of the racy code can sleep (i2o_dma_[re]alloc)
    - Move the code into a new i2o/memory.c file
    - Remove the gfp_mask argument so nobody can try and misuse the function
    - Wrap a mutex around the problem area (a single mutex is easy to do and
    none of this is performance relevant)
    - Switch the remaining problem kmalloc holdout to use i2o_dma_alloc

    Cc: Markus Lidel
    Cc: Vasily Averin
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

28 Jul, 2008

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (59 commits)
    [SCSI] replace __FUNCTION__ with __func__
    [SCSI] extend the last_sector_bug flag to cover more sectors
    [SCSI] qla2xxx: Update version number to 8.02.01-k6.
    [SCSI] qla2xxx: Additional NPIV corrections.
    [SCSI] qla2xxx: suppress uninitialized-var warning
    [SCSI] qla2xxx: use memory_read_from_buffer()
    [SCSI] qla2xxx: Issue proper ISP callbacks during stop-firmware.
    [SCSI] ch: fix ch_remove oops
    [SCSI] 3w-9xxx: add MSI support and misc fixes
    [SCSI] scsi_lib: use blk_rq_tagged in scsi_request_fn
    [SCSI] ibmvfc: Update driver version to 1.0.1
    [SCSI] ibmvfc: Add ADISC support
    [SCSI] ibmvfc: Miscellaneous fixes
    [SCSI] ibmvfc: Fix hang on module removal
    [SCSI] ibmvfc: Target refcounting fixes
    [SCSI] ibmvfc: Reduce unnecessary log noise
    [SCSI] sym53c8xx: free luntbl in sym_hcb_free
    [SCSI] scsi_scan.c: Release mutex in error handling code
    [SCSI] scsi_eh_prep_cmnd should save scmd->underflow
    [SCSI] sd: Support for SCSI disk (SBC) Data Integrity Field
    ...

    Linus Torvalds
     

27 Jul, 2008

2 commits


25 Jul, 2008

1 commit

  • Compile warning:
    ignoring return value of `sysfs_create_link', declared with attribute warn_unused_result.

    If sysfs_create_link failed, take care of the return value and do some
    error handle after the failure.

    Since sysfs_remove_link() will check whether a link exists, when removing the
    link in error path, we don't need to care whether a link was created.

    Signed-off-by: Wang Chen
    Cc: Markus Lidel
    Cc: Jens Axboe
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Wang Chen
     

22 Jul, 2008

1 commit


16 Jul, 2008

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (102 commits)
    [SCSI] scsi_dh: fix kconfig related build errors
    [SCSI] sym53c8xx: Fix bogus sym_que_entry re-implementation of container_of
    [SCSI] scsi_cmnd.h: remove double inclusion of linux/blkdev.h
    [SCSI] make struct scsi_{host,target}_type static
    [SCSI] fix locking in host use of blk_plug_device()
    [SCSI] zfcp: Cleanup external header file
    [SCSI] zfcp: Cleanup code in zfcp_erp.c
    [SCSI] zfcp: zfcp_fsf cleanup.
    [SCSI] zfcp: consolidate sysfs things into one file.
    [SCSI] zfcp: Cleanup of code in zfcp_aux.c
    [SCSI] zfcp: Cleanup of code in zfcp_scsi.c
    [SCSI] zfcp: Move status accessors from zfcp to SCSI include file.
    [SCSI] zfcp: Small QDIO cleanups
    [SCSI] zfcp: Adapter reopen for large number of unsolicited status
    [SCSI] zfcp: Fix error checking for ELS ADISC requests
    [SCSI] zfcp: wait until adapter is finished with ERP during auto-port
    [SCSI] ibmvfc: IBM Power Virtual Fibre Channel Adapter Client Driver
    [SCSI] sg: Add target reset support
    [SCSI] lib: Add support for the T10 (SCSI) Data Integrity Field CRC
    [SCSI] sd: Move scsi_disk() accessor function to sd.h
    ...

    Linus Torvalds
     

15 Jul, 2008

1 commit


12 Jul, 2008

3 commits


08 Jul, 2008

1 commit

  • The problem here is that if the ioc faults too early in the bring up
    sequence (as it usually does for an irq routing problem), ioc_reset gets
    called before the scsi host is even allocated. This causes an oops when
    it later schedules a renegotiation. Fix this by checking ioc->sh before
    trying to renegotiate.

    Cc: "Moore, Eric"
    Cc: Stable Tree
    Signed-off-by: James Bottomley

    James Bottomley
     

03 Jul, 2008

2 commits


21 Jun, 2008

1 commit


05 Jun, 2008

3 commits


27 May, 2008

1 commit

  • Following a hard reset of a SAS raid, one of the raid targets is occasionally
    missing. I tracked this down to a pretty obscure little bug.

    The LSI fusion drivers for SAS and Fibre Channel both use their respective
    transport layers. Those transport layers increment the target number
    assigned to new targets.

    The routine __scsi_scan_target uses the "this_id" element of the Scsi_Host
    structure to avoid scanning the scsi host adapter. Both fusion drivers set
    "this_id" from a value returned in a firmware PortFacts response. For my
    particular test case (SAS) the firmware id assigned to the initiator was
    173. After enough raid resets to cause the raid targets to go and come a
    sufficient number of times, the id assigned by the transport to a raid
    target would match the id assigned by the host adapter to the "this_id"
    field, resulting in that target not being scanned.

    Fix by not assigning this_id and not checking it in slave_configure.

    Signed-off-by: Michael Reed
    Acked-by: "Moore, Eric"
    Signed-off-by: James Bottomley

    Michael Reed