28 Nov, 2011
4 commits
-
TPS65910 can be used even if interrupt is unused.
Hence let probe succeed in case interrupt can't be
configured and let Kernel only to complain about itSigned-off-by: Afzal Mohammed
-
The tps65910.h file depends on linux/gpio.h. Move the include from the
source file to the tps65910.h header file.Signed-off-by: Kyle Manna
-
Fix a typo that clobbers other interrupts in an unobvious way.
Signed-off-by: Kyle Manna
-
Attempt to read the first register of the device, if there is no
device return -ENODEVSigned-off-by: Kyle Manna
Signed-off-by: Afzal Mohammed
27 Oct, 2011
2 commits
-
Adding member variables for USB internal LDOs in twl4030_platform_data
and registering them in twl-core.c if the variables are populated
from board-evm file.Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Sriramakrishnan A G
Signed-off-by: Vaibhav Hiremath -
This has to be done to enable U131 chip used to latch USB, Camera and
Audio lines.Should be done in generic way at board files.
Revert once generic implementation completed.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Sriramakrishnan A G
Signed-off-by: Vaibhav Hiremath
21 Sep, 2011
1 commit
-
In commit 659fb32d1b6("genirq: replace irq_gc_ack() with {set,clr}_bit
variants"), irq_gc_ack was renamed to irq_gc_ack_set_bit. The jz4740-adc
driver still uses the old name which results in a compile error.Signed-off-by: Lars-Peter Clausen
Signed-off-by: Samuel Ortiz
06 Sep, 2011
7 commits
-
The patch fixes the build failure:
drivers/mfd/omap-usb-host.c:1034:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1034:1: warning: type defaults to 'int' in
declaration of 'EXPORT_SYMBOL_GPL'
drivers/mfd/omap-usb-host.c:1034:1: warning: parameter names (without
types) in function declaration
drivers/mfd/omap-usb-host.c:1040:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1040:1: warning: type defaults to 'int' in
declaration of 'EXPORT_SYMBOL_GPL'
drivers/mfd/omap-usb-host.c:1040:1: warning: parameter names (without
types) in function declaration
drivers/mfd/omap-usb-host.c:1045:13: error: 'THIS_MODULE' undeclared
here (not in a function)
drivers/mfd/omap-usb-host.c:1050:15: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1050:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1050:1: warning: type defaults to 'int' in
declaration of 'MODULE_AUTHOR'
drivers/mfd/omap-usb-host.c:1050:15: warning: function declaration isn't
a prototype
drivers/mfd/omap-usb-host.c:1051:14: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1051:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1051:1: warning: type defaults to 'int' in
declaration of 'MODULE_ALIAS'
drivers/mfd/omap-usb-host.c:1051:14: warning: function declaration isn't
a prototype
drivers/mfd/omap-usb-host.c:1052:16: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1052:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1052:1: warning: type defaults to 'int' in
declaration of 'MODULE_LICENSE'
drivers/mfd/omap-usb-host.c:1052:16: warning: function declaration isn't
a prototype
drivers/mfd/omap-usb-host.c:1053:20: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1053:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1053:1: warning: type defaults to 'int' in
declaration of 'MODULE_DESCRIPTION'
drivers/mfd/omap-usb-host.c:1053:20: warning: function declaration isn't
a prototype
make[2]: *** [drivers/mfd/omap-usb-host.o] Error 1
CC fs/proc/namespaces.o
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....Signed-off-by: Ming Lei
Signed-off-by: Samuel Ortiz -
This code section seems to have been accidentally copy pasted.
It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
register and prevents the TLL mode from working correctly.Cc: stable@kernel.org
Signed-off-by: Anand Gadiyar
Cc: Keshava Munegowda
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz -
Required platform information is not handed to max8997-irq.c properly.
This patch enables to hand over such information to max8997-irq.c so
that max8997-irq functions properly.Signed-off-by: MyungJoo Ham
Signed-off-by: Kyungmin Park
Signed-off-by: Samuel Ortiz -
Fix regression introduced by commit
a2974732ca7614aaf0baf9d6dd3ad893d50ce1c5 (TPS65911: Add new irq
definitions) which caused irq_num to be incorrectly set for tps65910.Cc: stable@kernel.org
Signed-off-by: Johan Hovold
Acked-by: Graeme Gregory
Signed-off-by: Samuel Ortiz -
If the twl4030-madc device wasn't registered, and another device, such
as twl4030-madc-hwmon, calls twl4030_madc_conversion() a NULL pointer is
dereferenced.Signed-off-by: Kyle Manna
Signed-off-by: Samuel Ortiz -
Worst case this fixes the following error:
[ 72.086212] (NULL device *): conversion timeout!Best case it prevents a crash
Signed-off-by: Kyle Manna
Signed-off-by: Samuel Ortiz -
The kernel already has a function with this name declared
in asm-generic/gpio.h. So if this header leaks into wm8350/gpio.c
we getdrivers/mfd/wm8350-gpio.c:40:12: error: conflicting types for 'gpio_set_debounce'
include/asm-generic/gpio.h:156:12: note: previous declaration of 'gpio_set_debounce' was hereFix this by adding a wm8350_ prefix to the function.
Signed-off-by: Sascha Hauer
Acked-by: Mark Brown
Signed-off-by: Samuel Ortiz
01 Aug, 2011
26 commits
-
A mutex is locked on entry into twl4030_madc_conversion().
Immediate return on some error conditions leaves the
mutex locked.This patch ensures that mutex is always unlocked before
leaving the function.Signed-off-by: Sanjeev Premi
Cc: Keerthy
Signed-off-by: Samuel Ortiz -
twl6030_pwm: module license 'unspecified' taints kernel.
Signed-off-by: Randy Dunlap
Acked-by: Hemanth V
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz -
usbhs_disable function was invoking clk_enable() instead of
clk_disable(), thus only increasing the clock usage counter and
preventing this particular clock from being ever turned off.
Because of this, the power domain of omap4 the USB Host subsystem
would never reach lower power states.This patch calls clk_disable()
in usbhs_disable functionSigned-off-by: Keshava Munegowda
Signed-off-by: Samuel Ortiz -
This ensures we never have a window where we've handled an interrupt but
not told the hardware about it.Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Ensure that we never have a window where we've handled an interrupt (and
therefore need to be notified of new events) but haven't yet told the
interrupt controller that this is the case (so any new events will be
discarded).Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
In drivers/mfd/tps65910.c:tps65910_i2c_probe() there's potential for a
tiny optimization.We assign to init_data->irq and init_data->irq_base long before we
need them, and there are two potential exits from the function before
they are needed.Moving the assignments below these two potential exits means we
completely avoid doing them in these two (failure) cases.Signed-off-by: Jesper Juhl
Acked-by: Graeme Gregory
Signed-off-by: Samuel Ortiz -
There are a couple of situations where we leak init_data in
drivers/mfd/tps65910.c:tps65910_i2c_probe() - this patch should take
care of them.Signed-off-by: Jesper Juhl
Signed-off-by: Samuel Ortiz -
Add mfd core driver for AnalogicTech AAT2870.
The AAT2870 is communication through I2C and contains backlight and
regulator components.Signed-off-by: Jin Park
Signed-off-by: Samuel Ortiz -
We either hit one of the case's or the default in the switch statement
in get_i2c(), so the 'return ERR_PTR(-EINVAL);' at the end of the
function is just dead code - remove it.Signed-off-by: Jesper Juhl
Acked-by: MyungJoo Ham
Signed-off-by: Samuel Ortiz -
Having another TPS chip at the end of the Kconfig when all it's
relatives are grouped together in their own section seems totally
counter-intuitive. Move it, also in the Makefile.Signed-off-by: Linus Walleij
Signed-off-by: Samuel Ortiz -
Generating kerneldoc for STMPE result in warnings, so fix this by
adding missing documentation.Signed-off-by: Om Prakash
Reviewed-by: Rabin Vincent
Reviewed-by: Jonas Aberg
Reviewed-by: Srinidhi Kasagar
Signed-off-by: Linus Walleij
Signed-off-by: Samuel Ortiz -
If bytes == (TPS6591X_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).Signed-off-by: Axel Lin
Signed-off-by: Samuel Ortiz -
With the new generic clk API that should appear at some point we should be
able to support the clocking sensibly in Linux.Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Signed-off-by: Axel Lin
Signed-off-by: Samuel Ortiz -
The user has to select the I2C and SPI drivers individually and they select
the core driver for the device so there's no point in presenting the user
with an option for the core driver.Signed-off-by: Mark Brown
Acked-by: Randy Dunlap
Signed-off-by: Samuel Ortiz -
The GPIO IRQs aren't the first IRQs defined, we need to subtract the base
for the GPIOs as well to use them for array indexes.Signed-off-by: Dimitris Papastamos
Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Very similar to TPS65920
List of differences: http://www.ti.com/litv/pdf/swcu066bSigned-off-by: Oleg Drokin
Signed-off-by: Samuel Ortiz -
Purely for defensiveness.
Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
The tps65910_irq_exit() cleanup function was generating a warning from
sparse due to the lack of a prototype. This wasn't causing GCC warnings
as the driver wasn't cleaning up its IRQs on exit at all so there was no
use of an unprototyped function.Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Tunnel Creek has an additional watchdog core.
Signed-off-by: Alexander Stein
Signed-off-by: Samuel Ortiz -
This synchronize the subdevice entries for the AB8500 MFD driver
with the latest development of subdrivers for things like battery
charging and temperature monitoring.Signed-off-by: Linus Walleij
Signed-off-by: Samuel Ortiz -
Internal MFD device structs are marked as __devinitdata since the kernel
will allocate memory for the same when calling mfd_add_devices.Signed-off-by: Robert Rosengren
Reviewed-by: Mattias Wallin
Reviewed-by: Johan Palsson
Signed-off-by: Linus Walleij
Signed-off-by: Samuel Ortiz -
This module controls the interrupt handling for the tps65912.
The interrupt sources can be the following:- GPIO
- PWRON signal
- PWRHOLD signal
- Temperature detectionSigned-off-by: Margarita Olaya Cabrera
Acked-by: Samuel Ortiz
Acked-by: Liam Girdwood
Signed-off-by: Samuel Ortiz -
The tps65912 chip is a power management IC. It contains the following
components:- Regulators
- GPIO controllerThe core driver is registered as a platform driver, it provides communication
through I2C and SPI interfaces.Signed-off-by: Margarita Olaya Cabrera
Acked-by: Samuel Ortiz
Acked-by: Liam Girdwood
Signed-off-by: Samuel Ortiz -
This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.Signed-off-by: Peter Huewe
Signed-off-by: Samuel Ortiz -
This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.Signed-off-by: Peter Huewe
Signed-off-by: Samuel Ortiz
