04 Dec, 2008
1 commit
-
Conflicts:
fs/nfsd/nfs4recover.cManually fixed above to use new creds API functions, e.g.
nfs4_save_creds().Signed-off-by: James Morris
28 Nov, 2008
1 commit
-
udf_clear_inode() can leave behind buffers on mapping's i_private list (when
we truncated preallocation). Call invalidate_inode_buffers() so that the list
is properly cleaned-up before we return from udf_clear_inode(). This is ugly
and suggest that we should cleanup preallocation earlier than in clear_inode()
but currently there's no such call available since drop_inode() is called under
inode lock and thus is unusable for disk operations.Signed-off-by: Jan Kara
14 Nov, 2008
1 commit
-
Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().
Change some task->e?[ug]id to task_e?[ug]id(). In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.Signed-off-by: David Howells
Reviewed-by: James Morris
Acked-by: Serge Hallyn
Acked-by: Jan Kara
Signed-off-by: James Morris
23 Oct, 2008
2 commits
-
Signed-off-by: Al Viro
-
Switch all users of d_alloc_anon to d_obtain_alias.
Signed-off-by: Christoph Hellwig
Signed-off-by: Al Viro
14 Oct, 2008
1 commit
-
This is a much better version of a previous patch to make the parser
tables constant. Rather than changing the typedef, we put the "const" in
all the various places where its required, allowing the __initconst
exception for nfsroot which was the cause of the previous trouble.This was posted for review some time ago and I believe its been in -mm
since then.Signed-off-by: Steven Whitehouse
Cc: Alexander Viro
Signed-off-by: Linus Torvalds
09 Sep, 2008
1 commit
-
UDF currently doesn't set a llseek method for regular files, which
means it will fall back to default_llseek. This means no one can seek
beyond 2 Gigabytes on udf, and that there's not protection vs
the i_size updates from writers.Signed-off-by: Christoph Hellwig
Signed-off-by: Jan Kara
19 Aug, 2008
2 commits
-
I case we failed to allocate memory for inode when creating it, we did not
properly free block already allocated for this inode. Move memory allocation
before the block allocation which fixes this issue (thanks for the idea go to
Ingo Oeser ). Also remove a few superfluous
initializations already done in udf_alloc_inode().Reviewed-by: Ingo Oeser
Signed-off-by: Jan Kara -
A memory allocation inside alloc_mutex must not recurse back into the
filesystem itself because that leads to lock inversion between iprune_mutex and
alloc_mutex (and thus to deadlocks - see traces below). alloc_mutex is actually
needed only to update allocation statistics in the superblock so we can drop it
before we start allocating memory for the inode.tar D ffff81015b9c8c90 0 6614 6612
ffff8100d5a21a20 0000000000000086 0000000000000000 00000000ffff0000
ffff81015b9c8c90 ffff81015b8f0cd0 ffff81015b9c8ee0 0000000000000000
0000000000000003 0000000000000000 0000000000000000 0000000000000000
Call Trace:
[] __mutex_lock_slowpath+0x64/0x9b
[] mutex_lock+0xa/0xb
[] shrink_icache_memory+0x38/0x200
[] shrink_slab+0xe3/0x15b
[] try_to_free_pages+0x221/0x30d
[] isolate_pages_global+0x0/0x31
[] __alloc_pages_internal+0x252/0x3ab
[] cache_alloc_refill+0x22e/0x47b
[] kmem_cache_alloc+0x3b/0x61
[] cache_alloc_refill+0x2fe/0x47b
[] __kmalloc+0x76/0x9c
[] :udf:udf_new_inode+0x202/0x2e2
[] :udf:udf_create+0x2f/0x16d
[] :udf:udf_lookup+0xa6/0xad
...
kswapd0 D ffff81015b9d9270 0 125 2
ffff81015b903c28 0000000000000046 ffffffff8028cbb0 00000000fffffffb
ffff81015b9d9270 ffff81015b8f0cd0 ffff81015b9d94c0 000000000271b490
ffffe2000271b458 ffffe2000271b420 ffffe20002728dc8 ffffe20002728d90
Call Trace:
[] __set_page_dirty+0xeb/0xf5
[] get_dirty_limits+0x1d/0x22f
[] __mutex_lock_slowpath+0x64/0x9b
[] mutex_lock+0xa/0xb
[] :udf:udf_bitmap_free_blocks+0x47/0x1eb
[] :udf:udf_discard_prealloc+0xc6/0x172
[] :udf:udf_clear_inode+0x1e/0x48
[] clear_inode+0x6d/0xc4
[] dispose_list+0x56/0xee
[] shrink_icache_memory+0x1d0/0x200
[] shrink_slab+0xe3/0x15b
[] kswapd+0x346/0x447
...Reported-by: Tibor Tajti
Reviewed-by: Ingo Oeser
Signed-off-by: Jan Kara
27 Jul, 2008
1 commit
-
Kmem cache passed to constructor is only needed for constructors that are
themselves multiplexeres. Nobody uses this "feature", nor does anybody uses
passed kmem cache in non-trivial way, so pass only pointer to object.Non-trivial places are:
arch/powerpc/mm/init_64.c
arch/powerpc/mm/hugetlbpage.cThis is flag day, yes.
Signed-off-by: Alexey Dobriyan
Acked-by: Pekka Enberg
Acked-by: Christoph Lameter
Cc: Jon Tollefson
Cc: Nick Piggin
Cc: Matt Mackall
[akpm@linux-foundation.org: fix arch/powerpc/mm/hugetlbpage.c]
[akpm@linux-foundation.org: fix mm/slab.c]
[akpm@linux-foundation.org: fix ubifs]
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
24 Jun, 2008
1 commit
-
In some cases it could happen that some block passed test in
udf_check_anchor_block() even though udf_read_tagged() refused to read it later
(e.g. because checksum was not correct). This patch makes
udf_check_anchor_block() use udf_read_tagged() so that the checking is
stricter.This fixes the regression (certain disks unmountable) caused by commit
423cf6dc04eb79d441bfda2b127bc4b57134b41d.Signed-off-by: Tomas Janousek
Signed-off-by: Jan Kara
16 Jun, 2008
1 commit
-
Commit 706047a79725b585cf272fdefc234b31b6545c72, "udf: Fix compilation
warnings when UDF debug is on" inadvertently (I assume) enabled
debugging messages by default for UDF. This patch disables them again.Signed-off-by: Paul Collins
Signed-off-by: Jan Kara
09 May, 2008
1 commit
-
* 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-udf-2.6:
udf: Fix memory corruption when fs mounted with noadinicb option
udf: Make udf exportable
udf: fs/udf/partition.c:udf_get_pblock() mustn't be inline
07 May, 2008
2 commits
-
When UDF filesystem is mounted with noadinicb mount option, it
happens that we extend an empty directory with a block. A code in
udf_add_entry() didn't count with this possibility and used
uninitialized data leading to memory and filesystem corruption.
Add a check whether file already has some extents before operating
on them.Signed-off-by: Jan Kara
-
Cc: Christoph Hellwig
Signed-off-by: Rasmus Rohde
Signed-off-by: Jan Kara
30 Apr, 2008
1 commit
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
29 Apr, 2008
1 commit
-
This patch fixes the following build error with UML and gcc 4.3:
...
CC fs/udf/partition.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c: In function ‘udf_get_pblock_virt15’:
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c:32: sorry, unimplemented: inlining failed in call to ‘udf_get_pblock’: function body not available
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c:102: sorry, unimplemented: called from here
make[3]: *** [fs/udf/partition.o] Error 1Signed-off-by: Adrian Bunk
Signed-off-by: Jan Kara
28 Apr, 2008
1 commit
-
Let's use bsize instead.
fs/udf/namei.c:960:12: warning: symbol 'elen' shadows an earlier one
fs/udf/namei.c:937:15: originally declared hereSigned-off-by: Harvey Harrison
Cc: Jan Kara
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
17 Apr, 2008
22 commits
-
As pointed out by Sergey Vlasov, UDF implements its own version of
the CRC ITU-T V.41. Convert it to use the one in the library.Signed-off-by: Bob Copeland
Cc: Sergey Vlasov
Signed-off-by: Jan Kara -
Fix two compilation warnings (and actual bugs in message formatting)
when UDF debugging is turned on.Signed-off-by: Sebastian Manciulea
Signed-off-by: Jan Kara -
Fix mapping of blocks using VAT when it is stored in an inode.
UDF_I(inode)->i_data already points to the beginning of VAT header so there's
no need to add udf_ext0_offset(inode).Signed-off-by: Sebastian Manciulea
Signed-off-by: Jan Kara -
This patch implements parsing of metadata partitions and reading of Metadata
File thus allowing to read UDF 2.50 media. Error resilience is implemented
through accessing the Metadata Mirror File in case the data the Metadata File
cannot be read. The patch is based on the original patch by Sebastian Manciulea
and Mircea Fedoreanu .Signed-off-by: Sebastian Manciulea
Signed-off-by: Mircea Fedoreanu
Signed-off-by: Jan Kara -
According to OSTA UDF specification, only anchor blocks and primary volume
descriptors are placed on media relative to the last session. All other block
numbers are absolute (in the partition or the whole media). This seems to be
confirmed by multisession media created by other systems.Signed-off-by: Sebastian Manciulea
Signed-off-by: Jan Kara -
As we don't properly support writing to pseudooverwrite partition (we should
add entries to VAT and relocate blocks instead of just writing them), mount
filesystems with such partition as read-only.Signed-off-by: Jan Kara
-
We didn't handle VAT packed inside the inode - we tried to call udf_block_map()
on such file which lead to strange results at best. Add proper handling of
packed VAT as we do it with other packed files.Signed-off-by: Jan Kara
-
UDF media with VAT could have never worked because udf_fill_inode() didn't
know about case FILE_TYPE_VAT20. Fix this.Signed-off-by: Jan Kara
-
We incorrectly (way to strictly) checked version of VAT on loading and thus
refuse to mount correct media. There are just two format versions - below 2.0
and above 2.0 and we understand both. So update the version check accordingly.Signed-off-by: Jan Kara
-
Some of the computed positions of anchor block could be beyond the end of
device. Skip reading such blocks.Signed-off-by: Jan Kara
-
Add +1 and -1 to a list of blocks which can be the
real last recorded block on a UDF media. Sebastian Manciulea
claims this helps some drive + media combinations
he is able to test.Signed-off-by: Jan Kara
-
UDF anchor block detection is complicated by several things - there are several
places where the anchor point can be, some of them relative to the last
recorded block which some devices report wrongly. Moreover some devices on some
media seem to have 7 spare blocks sectors for every 32 blocks (at least as far
as I understand the old code) so we have to count also with that possibility.This patch splits anchor block detection into several functions so that it is
clearer what we actually try to do. We fix several bugs of the type "for such
and such media, we fail to check block blah" as a result of the cleanup.Signed-off-by: Jan Kara
-
This patch move processing of UDF virtual partitions close to the place
where other partition types are processed. As a result we now also
properly fill in partition access type.Signed-off-by: Jan Kara
-
Signed-off-by: Jan Kara
-
Report error when we fail to allocate memory for a bitmap and properly
release allocated memory and inodes for all the partitions in case of
mount failure and umount.Signed-off-by: Jan Kara
-
Cleanup processing of volume descriptor sequence so that it is more readable,
make code handle errors (e.g. media problems) better.Signed-off-by: Jan Kara
-
According to ECMA 167 rev. 3 (see 3/8.4.2.1), Anchor Volume Descriptor
Pointer should be recorded at two or more anchor points located at sectors
256, N, N - 256, where N - is a largest logical sector number at volume
space.So we should always try to detect N on UDF volume before trying to find
Anchor Volume Descriptor (i.e. calling to udf_find_anchor()).That said, all this patch does is updates the s_last_block even if the
udf_vrs() returns positive value.Originally written and tested by Yuri Per, ported on latest mainline by me.
Signed-off-by: Yuri Per
Signed-off-by: Pavel Emelyanov
Cc: Max Lyadvinsky
Cc: Vladimir Simonov
Cc: Andrew Neporada
Cc: Kirill Korotaev
Signed-off-by: Jan Kara -
There are several places in UDF where we declared temporary arrays of
UDF_NAME_LEN bytes on stack. This is not nice to stack usage so this patch
changes those places to use kmalloc() instead. Also clean up bail-out paths
in those functions when we are changing them.Signed-off-by: Jan Kara
-
We don't have to check whether a directory entry already exists in a directory
when creating a new one since we've already checked that earlier by lookup and
we are holding directory i_mutex all the time.Signed-off-by: Jan Kara
-
Mark udf_process_sequence() as noinline since stack usage is terrible
otherwise.Signed-off-by: Jan Kara
-
reorganize few code blocks in super.c which
were needlessly indented (and hard to read):so change from:
rettype fun()
{
init;
if (sth) {
long block of code;
}
}to:
rettype fun()
{
init;
if (!sth)
return;
long block of code;
}or
from:
rettype fun2()
{
init;
while (sth) {
init2();
if (sth2) {
long block of code;
}
}
}to:
rettype fun2()
{
init;
while (sth) {
init2();
if (!sth2)
continue;
long block of code;
}
}Signed-off-by: Marcin Slusarz
Signed-off-by: Jan Kara -
remove now unneeded kernel_timestamp type with conversion functions
Signed-off-by: Marcin Slusarz
Signed-off-by: Jan Kara
