06 Aug, 2010
1 commit
-
Fixed the nit pointed out by Jeff.
From: Suresh Jayaraman
Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugDataThis patch adds the features that are compiled in to the CIFS debugging data
as shown below:$cat /proc/fs/cifs/DebugData
Display Internal CIFS Data Structures for Debugging
---------------------------------------------------
CIFS Version 1.64
Features: dfs fscache posix spnego xattr
Active VFS Requests: 0
...This patch provides a definitive way to tell what features are currently
enabled in the running kernel. This could also help debugging.Signed-off-by: Suresh Jayaraman
Cc: Jeff Layton
Signed-off-by: Steve French
27 Apr, 2010
1 commit
-
...since that more accurately describes what that variable holds.
Signed-off-by: Jeff Layton
Signed-off-by: Steve French
21 Apr, 2010
1 commit
-
Neaten cERROR and cFYI macros, reduce text space
~2.5KConvert '__FILE__ ": " fmt' to '"%s: " fmt', __FILE__' to save text space
Surround macros with do {} while
Add parentheses to macros
Make statement expression macro from macro with assign
Remove now unnecessary parentheses from cFYI and cERROR usesdefconfig with CIFS support old
$ size fs/cifs/built-in.o
text data bss dec hex filename
156012 1760 148 157920 268e0 fs/cifs/built-in.odefconfig with CIFS support old
$ size fs/cifs/built-in.o
text data bss dec hex filename
153508 1760 148 155416 25f18 fs/cifs/built-in.oallyesconfig old:
$ size fs/cifs/built-in.o
text data bss dec hex filename
309138 3864 74824 387826 5eaf2 fs/cifs/built-in.oallyesconfig new
$ size fs/cifs/built-in.o
text data bss dec hex filename
305655 3864 74824 384343 5dd57 fs/cifs/built-in.oSigned-off-by: Joe Perches
Signed-off-by: Steve French
10 Jul, 2009
1 commit
-
Acked-by: Jeff Layton
Signed-off-by: Steve French
31 Mar, 2009
1 commit
-
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.->read_proc/->write_proc were just fixed to not require ->owner for
protection.rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.Removing ->owner will also make PDE smaller.
So, let's nuke it.
Kudos to Jeff Layton for reminding about this, let's say, oversight.
http://bugzilla.kernel.org/show_bug.cgi?id=12454
Signed-off-by: Alexey Dobriyan
12 Mar, 2009
1 commit
-
In contrast to the now-obsolete smbfs, cifs does not send SMB_COM_FLUSH
in response to an explicit fsync(2) to guarantee that all volatile data
is written to stable storage on the server side, provided the server
honors the request (which, to my knowledge, is true for Windows and
Samba with 'strict sync' enabled).
This patch modifies the cifs_fsync implementation to restore the
fsync-behavior of smbfs by triggering SMB_COM_FLUSH after sending
outstanding data on the client side to the server.Signed-off-by: Horst Reiterer
Acked-by: Jeff Layton
Signed-off-by: Steve French
17 Nov, 2008
2 commits
-
Signed-off-by: Steve French
-
Use a similar approach to the SMB session sharing. Add a list of tcons
attached to each SMB session. Move the refcount to non-atomic. Protect
all of the above with the cifs_tcp_ses_lock. Add functions to
properly find and put references to the tcons.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
15 Nov, 2008
2 commits
-
We do this by abandoning the global list of SMB sessions and instead
moving to a per-server list. This entails adding a new list head to the
TCP_Server_Info struct. The refcounting for the cifsSesInfo is moved to
a non-atomic variable. We have to protect it by a lock anyway, so there's
no benefit to making it an atomic. The list and refcount are protected
by the global cifs_tcp_ses_lock.The patch also adds a new routines to find and put SMB sessions and
that properly take and put references under the lock.Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
The code that allows these structs to be shared is extremely racy.
Disable the sharing of SMB and tcon structs for now until we can
come up with a way to do this that's race free.We want to continue to share TCP sessions, however since they are
required for multiuser mounts. For that, implement a new (hopefully
race-free) scheme. Add a new global list of TCP sessions, and take
care to get a reference to it whenever we're dealing with one.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
14 Nov, 2008
1 commit
-
Also adds two lines missing from the previous patch (for the need reconnect flag in the
/proc/fs/cifs/DebugData handling)The new global_cifs_sock_list is added, and initialized in init_cifs but not used yet.
Jeff Layton will be adding code in to use that and to remove the GlobalTcon and GlobalSMBSession
lists.CC: Jeff Layton
CC: Shirish Pargaonkar
Signed-off-by: Steve French
09 Aug, 2008
1 commit
-
Signed-off-by: Steve French
24 Jul, 2008
3 commits
-
Signed-off-by: Steve French
-
Signed-off-by: Steve French
-
Cc: Steven French
Signed-off-by: Andrew Morton
Signed-off-by: Steve French
29 Apr, 2008
1 commit
-
Use creation by full path instead: "fs/foo".
Signed-off-by: Alexey Dobriyan
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 Feb, 2008
1 commit
-
Signed-off-by: Steve French
13 Feb, 2008
1 commit
-
Christoph had noticed too many ifdefs in the CIFS code making it
hard to read. This patch removes about a quarter of them from
the C files in cifs by improving a few key ifdefs in the .h files.Signed-off-by: Steve French
08 Feb, 2008
1 commit
-
Signed-off-by: Steve French
05 Oct, 2007
1 commit
-
Fixes two problems:
1) we dropped down to negotiating lanman if we did not recognize the
mechanism (krb5 e.g.)
2) we did not stop cifsd (thus will fail when doing rmod cifs with
slab free errors) when we fail tcon but have a bad session (which is
the case in which signing is required but we don't allow signing on
the client)It also turns on extended security flag in the header when passing
"sec=krb5" on mount command (although kerberos support is not done of
course)Acked-by: Jeff Layton
CC: Shaggy
Signed-off-by: Steve French
15 Sep, 2007
2 commits
-
Signed-off-by: Steve French
-
Potential problem was noticed by Cyrill Gorcunov
CC: Cyrill Gorcunov
Signed-off-by: Steve French
13 Jul, 2007
1 commit
-
This should be the last big batch of whitespace/formatting fixes.
checkpatch warnings for the cifs directory are down about 90% and
many of the remaining ones are harder to remove or make the code
harder to read.Signed-off-by: Steve French
29 Jun, 2007
1 commit
-
We were checking the wrong (old) global variable to determine
whether to override server and force signing on the SMB
connection.Acked-by: Dave Kleikamp
Signed-off-by: Steve French
25 Jun, 2007
1 commit
-
More whitespace problems found by checkpatch
Signed-off-by: Steve French
06 Jun, 2007
1 commit
-
Various coding style problems found by running the new
checkpatch.pl script against fs/cifs. 3 more files
fixed up.Signed-off-by: Steve French
22 Jan, 2007
1 commit
-
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Steve French
06 Jun, 2006
1 commit
-
Signed-off-by: Steve French
05 Jun, 2006
1 commit
-
Signed-off-by: Steve French
03 Jun, 2006
1 commit
-
disabled by default, but can be enabled via proc for servers which
require such support. Also includes support for setting security
flags for cifs. See fs/cifs/READMESigned-off-by: Steve French
02 Jun, 2006
1 commit
01 Jun, 2006
1 commit
13 Dec, 2005
1 commit
-
Signed-off-by: Steve French
04 Dec, 2005
2 commits
-
when CONFIG_CIFS_STATS2 is on (helps in debugging performance)
Signed-off-by: Steve French
-
better performance debugging.
Signed-off-by: Steve French
12 Oct, 2005
2 commits
-
Signed-off-by: Steve French (sfrench@us.ibm.com)
-
New cifs_writepages routine was not updated bytes written in cifs stats.
Also added ability to clear /proc/fs/cifs/Stats by writing (0 or 1) to it.
Signed-off-by: Steve French
11 Oct, 2005
2 commits
-
Signed-off-by: Steve French (sfrench@us.ibm.com)
-
ever longer amounts (up to 15 seconds). This improves performance
especially when using large wsize.Signed-off-by: Steve French (sfrench@us.ibm.com)
08 Oct, 2005
1 commit
-
These changes to debug code and new stats are helpful in
debugging potential tcp performance/configuration problems under cifs.Signed-off-by: Steve French