09 Sep, 2010

1 commit

  • cifs_demultiplex_thread sets the addr.sockAddr.sin_port without any
    regard for the socket family. While it may be that the error in question
    here never occurs on an IPv6 socket, it's probably best to be safe and
    set the port properly if it ever does.

    Break the port setting code out of cifs_fill_sockaddr and into a new
    function, and call that from cifs_demultiplex_thread.

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff Layton
     

06 Aug, 2010

1 commit

  • Make cifs_convert_address() take a const src pointer and a length so that all
    the strlen() calls in their can be cut out and to make it unnecessary to modify
    the src string.

    Also return the data length from dns_resolve_server_name_to_ip() so that a
    strlen() can be cut out of cifs_compose_mount_options() too.

    Acked-by: Jeff Layton
    Signed-off-by: David Howells
    Signed-off-by: Steve French

    David Howells
     

02 Aug, 2010

2 commits

  • Seems like a more sensible mapping than -EIO.

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff Layton
     
  • This patch should replace the patch I sent a couple of weeks ago to
    set the port in cifs_convert_address.

    Currently we set this in cifs_find_tcp_session, but that's more of a
    side effect than anything. Add a new function called cifs_fill_sockaddr.
    Have it call cifs_convert_address and then set the port.

    This also allows us to skip passing in the port as a separate parm to
    cifs_find_tcp_session.

    Also, change cifs_convert_address take a struct sockaddr * rather than
    void * to make it clearer how this function should be called.

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff Layton
     

21 Apr, 2010

1 commit

  • Neaten cERROR and cFYI macros, reduce text space
    ~2.5K

    Convert '__FILE__ ": " fmt' to '"%s: " fmt', __FILE__' to save text space
    Surround macros with do {} while
    Add parentheses to macros
    Make statement expression macro from macro with assign
    Remove now unnecessary parentheses from cFYI and cERROR uses

    defconfig with CIFS support old
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    156012 1760 148 157920 268e0 fs/cifs/built-in.o

    defconfig with CIFS support old
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    153508 1760 148 155416 25f18 fs/cifs/built-in.o

    allyesconfig old:
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    309138 3864 74824 387826 5eaf2 fs/cifs/built-in.o

    allyesconfig new
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    305655 3864 74824 384343 5dd57 fs/cifs/built-in.o

    Signed-off-by: Joe Perches
    Signed-off-by: Steve French

    Joe Perches
     

25 Jun, 2009

1 commit

  • This patch has CIFS look for a '%' in an IPv6 address. If one is
    present then it will try to treat that value as a numeric interface
    index suitable for stuffing into the sin6_scope_id field.

    This should allow people to mount servers on IPv6 link-local addresses.

    Signed-off-by: Jeff Layton
    Acked-by: David Holder
    Signed-off-by: Steve French

    Jeff Layton
     

15 Jun, 2009

1 commit


13 Jun, 2009

1 commit


28 May, 2009

2 commits


01 May, 2009

1 commit


13 May, 2008

1 commit


09 May, 2008

1 commit


13 Feb, 2008

1 commit


08 Feb, 2008

1 commit


06 Nov, 2007

1 commit


01 Nov, 2007

1 commit

  • Kernel bugzilla bug #9228

    If mount helper (mount.cifs) missing, mounts with form like
    //10.11.12.13/c$ would not work (only mounts with slash e.g.
    //10.11.12.13\\c$ would work) due to problem with slash supposed
    to be converted to backslash by the mount helper (which is not
    there).

    If we fail on converting an IPv4 address in in4_pton then
    try to canonicalize the first slash (ie between sharename
    and host ip address) if necessary. If we have to retry
    to check for IPv6 address the slash is already converted
    if necessary.

    Signed-off-by: Steve French

    Steve French
     

26 Oct, 2007

1 commit


19 Oct, 2007

1 commit


18 Oct, 2007

1 commit


18 Jul, 2007

1 commit


16 Jul, 2007

1 commit


13 Jul, 2007

1 commit

  • This should be the last big batch of whitespace/formatting fixes.
    checkpatch warnings for the cifs directory are down about 90% and
    many of the remaining ones are harder to remove or make the code
    harder to read.

    Signed-off-by: Steve French

    Steve French
     

10 Jul, 2007

1 commit


08 Jul, 2007

2 commits


07 Jul, 2007

1 commit


25 Apr, 2007

1 commit

  • IPv6 support was started a few years ago in the cifs client, but lacked a
    kernel helper function for parsing the ascii form of the ipv6 address. Now
    that that is added (and now IPv6 is the default that some OS use now) it
    was fairly easy to finish the cifs ipv6 support. This requires that
    CIFS_EXPERIMENTAL be enabled and (at least until the mount.cifs module is
    modified to use a new ipv6 friendly call instead of gethostbyname) and the
    ipv6 address be passed on the mount as "ip=" mount option.

    Thanks

    Signed-off-by: Steve French

    Steve French
     

12 Oct, 2006

2 commits


11 Oct, 2006

1 commit


07 Oct, 2006

1 commit


28 Sep, 2006

1 commit


12 Aug, 2006

1 commit

  • Allow Windows blocking locks to be cancelled via a
    CANCEL_LOCK call. TODO - restrict this to servers
    that support NT_STATUS codes (Win9x will probably
    not support this call).

    Signed-off-by: Jeremy Allison
    Signed-off-by: Steve French
    (cherry picked from 570d4d2d895569825d0d017d4e76b51138f68864 commit)

    Jeremy Allison
     

03 Jun, 2006

1 commit


02 Jun, 2006

1 commit


30 Nov, 2005

1 commit


12 Oct, 2005

1 commit


23 Sep, 2005

1 commit


22 Sep, 2005

1 commit