09 Jan, 2011

1 commit


07 Mar, 2010

1 commit


11 Jan, 2010

1 commit

  • The id_table field of the struct pci_driver is constant in
    so it is worth to make pci_device_id also constant.

    The semantic match that finds this kind of pattern is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r@
    identifier I1, I2, x;
    @@
    struct I1 {
    ...
    const struct I2 *x;
    ...
    };
    @s@
    identifier r.I1, y;
    identifier r.x, E;
    @@
    struct I1 y = {
    .x = E,
    };
    @c@
    identifier r.I2;
    identifier s.E;
    @@
    const struct I2 E[] = ... ;
    @depends on !c@
    identifier r.I2;
    identifier s.E;
    @@
    + const
    struct I2 E[] = ...;
    //

    Signed-off-by: Márton Németh
    Cc: Julia Lawall
    Signed-off-by: Jean Delvare

    Márton Németh
     

15 Sep, 2009

1 commit


07 Jan, 2009

1 commit

  • Check for ACPI resource conflicts in hwmon drivers. I've included
    all Super-I/O and PCI drivers.

    I've voluntarily left out:
    * Vendor-specific drivers: if they conflicted on any system, this would
    pretty much mean that they conflict on all systems, and we would know
    by now.
    * Legacy ISA drivers (lm78 and w83781d): they only support chips found
    on old designs were ACPI either wasn't supported or didn't deal with
    thermal management.
    * Drivers accessing the I/O resources indirectly (e.g. through SMBus):
    the checks are already done where they belong, i.e. in the bus drivers.

    Signed-off-by: Jean Delvare
    Acked-by: David Hubbard

    Jean Delvare
     

17 Feb, 2008

2 commits


08 Feb, 2008

1 commit


15 Oct, 2007

1 commit


10 Oct, 2007

1 commit


31 Jul, 2007

1 commit

  • On Sun, 22 Jul 2007 00:30:56 +0200, Gabriel C wrote:
    > I noticed this warnings on current git:
    >
    > drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used
    > drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used
    > drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used
    > drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used
    > drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not used

    Signed-off-by: Jean Delvare
    Signed-off-by: Mark M. Hoffman

    Jean Delvare
     

20 Jul, 2007

2 commits

  • Fix a potential race condition when some hardware monitoring platform
    drivers are being unloaded. I believe that the driver data pointer
    shouldn't be cleared before all the sysfs files are removed, otherwise
    a sysfs callback might attempt to dereference a NULL pointer. I'm not
    sure exactly what the driver core protects drivers against, so let's
    play it safe.

    While we're here, clear the driver data pointer when probe fails, so
    as to not leave an invalid pointer behind us.

    Signed-off-by: Jean Delvare
    Signed-off-by: Mark M. Hoffman

    Jean Delvare
     
  • Convert the vt8231 driver from the nonsensical i2c-isa hack to a
    regular platform driver.

    Signed-off-by: Roger Lucas
    Signed-off-by: Jean Delvare
    Signed-off-by: Mark M. Hoffman

    Roger Lucas
     

14 Feb, 2007

1 commit


29 Sep, 2006

1 commit

  • vt8231: Fix unchecked return status

    Check the return status from device_create_file() and also use
    the newer and cleaner sysfs creation functions.

    Signed-off-by: Roger Lucas
    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Roger Lucas
     

27 Sep, 2006

1 commit

  • i2c-isa: Restore driver owner

    Commit 2b48716d1d2f2edb1e7cbc5ecf1cb2cb39373e33 back in January
    2006 was a bit overzealous. It removed .owner from all i2c drivers,
    including i2c-isa ones, while they still need it.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     

24 Mar, 2006

1 commit

  • convert drivers/hwmon/*.c semaphore use to mutexes.

    the conversion was generated via scripts, and the result was validated
    automatically via a script as well.

    all affected hwmon drivers were build-tested.

    Signed-off-by: Ingo Molnar
    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Ingo Molnar
     

14 Feb, 2006

1 commit


10 Jan, 2006

1 commit


06 Jan, 2006

3 commits