09 Jul, 2011
8 commits
-
Bump package revision number!
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Change a missed reference to the `list' command, and update the output
from `usbip bind ...' and `usbip list -r ...'Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
The remote devices listed are, technically, exportable and not
necessarily exported.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Change spacing to provide better indentation for readability.
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
A bug that I created due to using simply expanding variables in the
makefiles. Although only unexpanded paths are at issue here, I decided
to use recursively expanding variables on all of the parameterized
values.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Change and add new usbip_net_ prefix to every function in the network
code for easier identification.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Reorganize, rename [for clarity and to remove stub_driver
references], modify output messages, and cleanup coding style;
nevertheless, the actual implementation is pretty much untouched.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Fix usbip printk format warning for size_t:
drivers/staging/usbip/stub_tx.c:236: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'size_t'
Signed-off-by: Randy Dunlap
Signed-off-by: Greg Kroah-Hartman
06 Jul, 2011
29 commits
-
When build userspace code, got the following error message:
make[2]: Entering directory `/usr/src/staging-2.6/drivers/staging/usbip/userspace/src'
CC usbip.o
...
CCLD usbip
CC usbipd.o
usbipd.c:30:25: fatal error: stub_driver.h: No such file or directory
compilation terminated.
make[2]: *** [usbipd.o] Error 1
make[2]: Leaving directory `/usr/src/staging-2.6/drivers/staging/usbip/userspace/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/staging-2.6/drivers/staging/usbip/userspace'
make: *** [all] Error 2Due to commit 756d6726 and a16941ae, stub_driver had been changed
into host_driver, so update header filename and functions name to
fix these build errorsSigned-off-by: David Chang
CC: Joe Perches
Cc: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Fix regression problem in linux-next: post_reset and pre_reset are no longer
included in linux-next while they are in linux-3.0rc5.Signed-off-by: Arjan Mels
Cc: usbip-devel
Signed-off-by: Greg Kroah-Hartman -
When unbinding a device on the host which was still attached on the
client, I got a NULL pointer dereference on the client. This turned out
to be due to kthread_stop() being called on an already dead kthread.Here is how I was able to reproduce the problem:
server:# usbip bind -b 1-2
client:# usbip attach -h server -b 1-2
server:# usbip unbind -b 1-2This patch fixes the problem by checking the kthread before attempting
to kill it, as it is done on the opposite side in
stub_shutdown_connection().Signed-off-by: Tobias Klauser
Cc: stable
Signed-off-by: Greg Kroah-Hartman -
Change package name to usbip-utils, email address to linux-usb, and
bump minor version number.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Change messges to debug, and fix a few coding style issues.
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Officially change stub_driver to usbip_host_driver. And, reorganize
usbip_host_driver.c while also cleaning up coding style.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Rename stub_driver.? to usbip_host_driver.?
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Delay the printing of the output header until the list is received
from the remote host. This allows notification that the host does not
have any exportable devices.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Edit dbg and normal output messages for consistency and better
feedback.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Modify unbind to use libsysfs, and include a check to verify that the
device is actually using usbip-host before proceeding. The output
messages have been changed to be consistent with `usbip bind'.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Rewrite functions in terms of libsysfs, which eliminates a lot of
helper functions simplifying the file layout. Now, the two processes
taking place here, an unbind of the old driver and a bind of
usbip-host, are single functions and have been renamed along with the
controlling function. A check to see if the device is already bound to
usbip-host is now included.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Rewrite the function to use libsysfs.
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Removes all of the helper functions that used a lot of hard-coded
values intead of libsysfs. Most of these functions were unused
anyway.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
When a bad option is given, display a message stating such and output
usage. When a bad command is given, output command help.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
The library should not be displaying random messages intermixed with
those from the programs that use them. So, instead, change all of the
output from the library to debug only, and allow the programs to
decide what to tell the user. This also changes the messages to use
the same form, which makes understanding them easier.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Remove the library version of usbip.h because its sole purpose was to
include other headers, which is bad practice. Also modify include
guards for consistency.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Add option for logging with syslog, and default to use stderr for
error and info messages.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Set the program name to "libusbip" to identify that the message is
from the library code.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Remove unnecessary headers from the file, and add the now missing
headers into the files that actually need them.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Relocate enums to follow logging macros.
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Provide better abstraction for easier modification, and align the
macros for readability. Remove notice() because it is not used.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Modify $FILES to account for the new directory layout. Also, sort the
list of files within the variable to make it human-readable.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Update examples to correspond with the new usbip-utils; edit grammar;
and cleanup format for consistency.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Add myself to the AUTHORS file.
Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Inclusion of the usb.ids file is redundant. USBIDS_DIR is set in
configure.ac to a default of /usr/share/hwdata/. This can be
overridden using `./configure --with-usbids-dir='.Signed-off-by: matt mooney
Signed-off-by: Greg Kroah-Hartman -
Use memcpy() function to save port status instead of
a handwritten for loop.Signed-off-by: Márton Németh
Signed-off-by: Greg Kroah-Hartman -
At the beginning of vhci_hub_control() function the port
status is saved to show what are the differences between the
previous and the new status. Change the dump function to
really show the differences in the status bit changes: put
a '+' sign before the symbolic name of a bit where a bit
was set, a '-' sign where the bit was cleared and a SPACE
where the bit was not changed. This is similar to the way
"diff -u" shows the changes and easy to understand.Signed-off-by: Márton Németh
Cc: Joe Perches
Signed-off-by: Greg Kroah-Hartman -
The wIndex parameter of vhci_hub_control() is always zero when the
request type is GetHubDescriptor, see drivers/usb/core/hub.c::get_hub_descriptor()
and Universal Serial Bus Specification revision 2.0 (April 27, 2000) Section
11.24.2.5 "Get Hub Descriptor". This means the variable rhport will not contain
any useful index. Only use valid rhport values.Signed-off-by: Márton Németh
Signed-off-by: Greg Kroah-Hartman -
This fixes out-of-tree builds ($builddir != $srcdir). In such cases,
libusbip.la cannot be found because it is generated in the build
directory and not the source directory.Signed-off-by: Tobias Klauser
Acked-by: matt mooney
Signed-off-by: Greg Kroah-Hartman
29 Jun, 2011
1 commit
-
Just spelling fixes.
Signed-off-by: Joe Perches
Signed-off-by: Greg Kroah-Hartman
10 Jun, 2011
1 commit
-
This was done to resolve the conflicts that were in a number of files
due to changes done upstream with others done in the staging-next
branch.Signed-off-by: Greg Kroah-Hartman
08 Jun, 2011
1 commit
-
In this file, in certain places, newline characters in pr_debug() calls had
whitespace before them. This patch removes this extraneous whitespace.Signed-off-by: Akshay Joshi
Signed-off-by: Greg Kroah-Hartman
