21 Sep, 2011

1 commit

  • Commit a6b7a407865aab9f849dd99a71072b7cd1175116 removed
    linux/interrupt.h from netdevice.h. This fixes below build failure

    drivers/net/pxa168_eth.c: In function 'pxa168_eth_collect_events':
    drivers/net/pxa168_eth.c:866: error: 'IRQ_NONE' undeclared (first use in this function)
    drivers/net/pxa168_eth.c:866: error: (Each undeclared identifier is reported only once
    drivers/net/pxa168_eth.c:866: error: for each function it appears in.)
    drivers/net/pxa168_eth.c: At top level:
    drivers/net/pxa168_eth.c:913: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'pxa168_eth_int_handler'
    drivers/net/pxa168_eth.c: In function 'pxa168_eth_open':
    drivers/net/pxa168_eth.c:1133: error: implicit declaration of function 'request_irq'
    drivers/net/pxa168_eth.c:1133: error: 'pxa168_eth_int_handler' undeclared (first use in this function)
    drivers/net/pxa168_eth.c:1134: error: 'IRQF_DISABLED' undeclared (first use in this function)
    drivers/net/pxa168_eth.c:1160: error: implicit declaration of function 'free_irq'

    Signed-off-by: Tanmay Upadhyay
    Signed-off-by: David S. Miller

    Tanmay Upadhyay
     

26 Jul, 2011

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)
    fs: Merge split strings
    treewide: fix potentially dangerous trailing ';' in #defined values/expressions
    uwb: Fix misspelling of neighbourhood in comment
    net, netfilter: Remove redundant goto in ebt_ulog_packet
    trivial: don't touch files that are removed in the staging tree
    lib/vsprintf: replace link to Draft by final RFC number
    doc: Kconfig: `to be' -> `be'
    doc: Kconfig: Typo: square -> squared
    doc: Konfig: Documentation/power/{pm => apm-acpi}.txt
    drivers/net: static should be at beginning of declaration
    drivers/media: static should be at beginning of declaration
    drivers/i2c: static should be at beginning of declaration
    XTENSA: static should be at beginning of declaration
    SH: static should be at beginning of declaration
    MIPS: static should be at beginning of declaration
    ARM: static should be at beginning of declaration
    rcu: treewide: Do not use rcu_read_lock_held when calling rcu_dereference_check
    Update my e-mail address
    PCIe ASPM: forcedly -> forcibly
    gma500: push through device driver tree
    ...

    Fix up trivial conflicts:
    - arch/arm/mach-ep93xx/dma-m2p.c (deleted)
    - drivers/gpio/gpio-ep93xx.c (renamed and context nearby)
    - drivers/net/r8169.c (just context changes)

    Linus Torvalds
     

11 Jul, 2011

1 commit


22 Jun, 2011

1 commit

  • Unnecessary casts of void * clutter the code.

    These are the remainder casts after several specific
    patches to remove netdev_priv and dev_priv.

    Done via coccinelle script (and a little editing):

    $ cat cast_void_pointer.cocci
    @@
    type T;
    T *pt;
    void *pv;
    @@

    - pt = (T *)pv;
    + pt = pv;

    Signed-off-by: Joe Perches
    Acked-by: Sjur Brændeland
    Acked-By: Chris Snook
    Acked-by: Jon Mason
    Acked-by: Geert Uytterhoeven
    Acked-by: David Dillow
    Signed-off-by: David S. Miller

    Joe Perches
     

21 Jun, 2011

3 commits


10 Jun, 2011

1 commit


31 Mar, 2011

1 commit


12 Dec, 2010

1 commit

  • flush_scheduled_work() is on its way out. This patch contains simple
    conversions to replace flush_scheduled_work() usage with direct
    cancels and flushes.

    Directly cancel the used works on driver detach and flush them in
    other cases.

    The conversions are mostly straight forward and the only dangers are,

    * Forgetting to cancel/flush one or more used works.

    * Cancelling when a work should be flushed (ie. the work must be
    executed once scheduled whether the driver is detaching or not).

    I've gone over the changes multiple times but it would be much
    appreciated if you can review with the above points in mind.

    Signed-off-by: Tejun Heo
    Cc: "David S. Miller"
    Cc: Jay Cliburn
    Cc: Michael Chan
    Cc: Divy Le Ray
    Cc: e1000-devel@lists.sourceforge.net
    Cc: Vasanthy Kolluri
    Cc: Samuel Ortiz
    Cc: Lennert Buytenhek
    Cc: Andrew Gallatin
    Cc: Francois Romieu
    Cc: Ramkrishna Vepa
    Cc: Matt Carlson
    Cc: David Brownell
    Cc: Shreyas Bhatewara
    Cc: netdev@vger.kernel.org

    Tejun Heo
     

11 Dec, 2010

1 commit


01 Oct, 2010

1 commit


10 Sep, 2010

1 commit


03 Sep, 2010

1 commit


02 Sep, 2010

2 commits


25 Aug, 2010

4 commits

  • Casting "pep->tx_desc_dma" to to a struct tx_desc pointer makes gcc
    complain:

    drivers/net/pxa168_eth.c:657: warning:
    cast to pointer from integer of different size

    Signed-off-by: Dan Carpenter
    Signed-off-by: David S. Miller

    Dan Carpenter
     
  • The phy_mii_ioctl() function changed recently. It now takes a struct
    ifreq pointer directly.

    Signed-off-by: Dan Carpenter
    Signed-off-by: David S. Miller

    Dan Carpenter
     
  • A couple issues here:
    * Some resources weren't released.
    * If alloc_etherdev() failed it would have caused a NULL dereference
    because "pep" would be null when we checked "if (pep->clk)".
    * Also it's better to propagate the error codes from mdiobus_register()
    instead of just returning -ENOMEM.

    Signed-off-by: Dan Carpenter
    Signed-off-by: David S. Miller

    Dan Carpenter
     
  • "pep->pd" isn't checked consistently in this function. For example it's
    dereferenced unconditionally on the next line after the end of the if
    condition. This function is only called from pxa168_eth_probe() and
    pep->pd is always non-NULL so I removed the check.

    Signed-off-by: Dan Carpenter
    Signed-off-by: David S. Miller

    Dan Carpenter
     

19 Aug, 2010

1 commit