18 Feb, 2018
2 commits
-
The local variable "ret" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.Signed-off-by: Markus Elfring
Signed-off-by: Tejun Heo -
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Tejun Heo
29 Jun, 2016
1 commit
-
Note that `&acdev->host->lock' and `qc->ap->lock' denote the same lock, and it's
particularly confusing to spin_lock on the former but spin_unlock on the latter.Signed-off-by: Iago Abal
Signed-off-by: Tejun Heo
02 Sep, 2015
1 commit
-
Pull libata updates from Tejun Heo:
"Nothing interesting. A couple device specific minor updates and a
kernel doc change"* 'for-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata:
ata: pata_arasam_cf: Use devm_clk_get
libata: fix libata-core.c kernel-doc warning
ata: sata_rcar: Remove obsolete sata-r8a779* platform_device_id entries
23 Aug, 2015
1 commit
-
This patch introduces the use of managed resource function
devm_clk_get instead of clk_get and removes corresponding call
to clk_put in the remove function.To be compatible with the change various gotos are replaced with
direct returns, and unneeded label is dropped.Signed-off-by: Vaishali Thakkar
Signed-off-by: Tejun Heo
18 Jul, 2015
1 commit
-
Switch to my kernel.org alias instead of a badly named gmail address,
which I rarely use.Signed-off-by: Viresh Kumar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
16 Oct, 2014
1 commit
-
The drivers should use dmaengine_terminate_all() API instead of accessing
the device_control which will be deprecated soonAcked-by: Viresh Kumar
Signed-off-by: Vinod Koul
15 Apr, 2014
1 commit
-
Add missing cf_exit() and clk_put() calls to ata_host_activate()
failure path.Cc: Viresh Kumar
Cc: Shiraz Hashim
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Viresh Kumar
Signed-off-by: Tejun Heo
27 Mar, 2014
1 commit
-
Unreferenced casts of void * types are unnecessary so remove them.
Signed-off-by: Joe Perches
Signed-off-by: Tejun Heo
23 Nov, 2013
1 commit
-
Add the missing clk_disable_unprepare() before return from cf_init()
in the error handling case.Signed-off-by: Wei Yongjun
Signed-off-by: Tejun Heo
Acked-by: Viresh Kumar
15 Nov, 2013
1 commit
-
Remove no longer needed DMA unmap flags:
- DMA_COMPL_SKIP_SRC_UNMAP
- DMA_COMPL_SKIP_DEST_UNMAP
- DMA_COMPL_SRC_UNMAP_SINGLE
- DMA_COMPL_DEST_UNMAP_SINGLECc: Vinod Koul
Cc: Tomasz Figa
Cc: Dave Jiang
Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: Kyungmin Park
Acked-by: Jon Mason
Acked-by: Mark Brown
[djbw: clean up straggling skip unmap flags in ntb]
Signed-off-by: Dan Williams
09 Aug, 2013
1 commit
-
These local symbols are used only in this file.
Fix the following sparse warnings:drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static?
drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?Signed-off-by: Jingoo Han
Acked-by: Viresh Kumar
Signed-off-by: Tejun Heo
24 May, 2013
1 commit
-
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.Signed-off-by: Jingoo Han
Signed-off-by: Tejun Heo
20 Apr, 2013
1 commit
-
This adds a complete DT binding for the arasan device driver. There is
currently only one user, which is the spear13xx platform, so we don't
actually have to parse all the properties until another user comes in,
but this does use the generic DMA binding to find the DMA channel.The patch is untested so far and is part of a series to convert
the spear platform over to use the generic DMA binding, so it
should stay with the rest of the series.Signed-off-by: Arnd Bergmann
Acked-by: Viresh Kumar
Cc: Vinod Koul
Cc: Jeff Garzik
Cc: devicetree-discuss@lists.ozlabs.org
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Cc: Jeff Garzik
Cc: Viresh Kumar
Signed-off-by: Greg Kroah-Hartman
29 Nov, 2012
1 commit
-
'acdev->qc', 'acdev->qc->ap', and 'acdev->qc->tf' expressions are used multiple
times in this function, so it makes sense to use the local variables for them.Signed-off-by: Sergei Shtylyov
Acked-by: Viresh Kumar
Signed-off-by: Jeff Garzik
16 Nov, 2012
2 commits
-
This will fix warnings like following when CONFIG_PM_SLEEP is not set:
warning: 'xxx_suspend' defined but not used [-Wunused-function]
warning: 'xxx_resume' defined but not used [-Wunused-function]Because
SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM).
Cc: Viresh Kumar
Cc: linux-ide@vger.kernel.org
Signed-off-by: Yuanhan Liu
Signed-off-by: Fengguang Wu
Signed-off-by: Jeff Garzik -
PATA arasan driver expects the clock to be set to 166 MHz for proper
functioning. This patch sets clk to 166 MHz in probe.Signed-off-by: Vipul Kumar Samar
Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik
13 Sep, 2012
2 commits
-
SPEAr platforms now support DT and so must convert all drivers to support DT.
This patch adds DT probing support for Arasan Compact Flash controller and
updates its documentation too.Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik -
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik
31 Jul, 2012
1 commit
-
With addition of dummy clk_*() calls for non CONFIG_HAVE_CLK cases in
clk.h, there is no need to have clk code enclosed in #ifdef
CONFIG_HAVE_CLK, #endif macros.Signed-off-by: Viresh Kumar
Cc: Jeff Garzik
Cc: Russell King
Cc: Mike Turquette
Cc: Sergei Shtylyov
Cc: viresh kumar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
21 Jun, 2012
1 commit
-
viresh.kumar@st.com email-id doesn't exist anymore as I have left the
company. Replace ST's id with viresh.linux@gmail.com.It also updates .mailmap file to fix address for 'git shortlog'
Signed-off-by: Viresh Kumar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
04 May, 2012
1 commit
-
#ifdef, #endif is not required in definition/usage of arasan_cf_pm_ops. So, move
this definition and its usage outside of them.Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik
14 Mar, 2012
1 commit
-
This patch adds in Hibernation related callbacks. Also we don't really need to
free DMA channel on suspend.Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik
09 Jan, 2012
1 commit
-
This patch converts the drivers in drivers/ata/* to use the
module_platform_driver() macro which makes the code smaller and a bit
simpler.Cc: Viresh Kumar
Cc: Jeff Garzik
Cc: Arnaud Patard
Cc: Alessandro Zummo
Cc: Sylvain Munaut
Cc: Anton Vorontsov
Cc: Marek Vasut
Cc: Florian Fainelli
Cc: Mark Miesfeld
Cc: Ashish Kalra
Cc: Paul Mundt
Signed-off-by: Axel Lin
Signed-off-by: Jeff Garzik
15 Oct, 2011
1 commit
-
The suspend()/resume() methods already get the right 'struct device' to get the
driver data from -- there's no need to get to the 'struct platform_device' that
contains that 'struct device' just to call dev_get_drvdata()...Acked-by: Viresh Kumar
Signed-off-by: Sergei Shtylyov
Signed-off-by: Jeff Garzik
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
14 Mar, 2011
3 commits
-
Some DMA controllers (eg: drivers/dma/dw_dmac*) allow platform specific
configuration for dma transfers. User drivers need to set chan->private field
of channel with pointer to configuration data. This patch takes dma_priv data
from platform data and passes it to chan->private_data, in order to pass
platform specific configuration to DMAC controller.Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik -
Signed-off-by: Jeff Garzik
-
The Arasan CompactFlash Device Controller has three basic modes of
operation: PC card ATA using I/O mode, PC card ATA using memory mode, PC card
ATA using true IDE modes.Currently driver supports only True IDE mode.
Signed-off-by: Viresh Kumar
Signed-off-by: Jeff Garzik