13 Oct, 2018
1 commit
-
Reviewed-by: Johan Hovold
Signed-off-by: Al Viro
25 Jun, 2018
1 commit
-
Negative error code will be larger than sizeof().
Note that none of these bugs prevent errors from being detected, even if
the ir-usb one would cause a less precise debug message to printed.Signed-off-by: Chengguang Xu
[ johan: add comment about implications ]
Signed-off-by: Johan Hovold
04 Nov, 2017
2 commits
-
Several GPL-2.0 drivers used "GPL" rather than "GPL v2" in their
MODULE_LICENSE macros; fix the macros to match the licenses.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.Update the drivers/usb/ and include/linux/usb* files with the correct
SPDX license identifier based on the license text in the file itself.
The SPDX identifier is a legally binding shorthand, which can be used
instead of the full boiler plate text.This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.Cc: Thomas Gleixner
Cc: Kate Stewart
Cc: Philippe Ombredanne
Signed-off-by: Greg Kroah-Hartman
Acked-by: Felipe Balbi
Acked-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
26 Jan, 2017
1 commit
-
Do not report ASYNC_SKIP_TEST or ASYNC_AUTO_IRQ as being set in
TIOCGSERIAL handlers as these flags are not supported and do not really
make any sense for USB serial devices in the first place.Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Johan Hovold
16 Jan, 2017
1 commit
-
Make sure to detect short control-message transfers rather than continue
with zero-initialised data when retrieving modem status and during
device initialisation.Fixes: 52af95459939 ("USB: add USB serial ssu100 driver")
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Johan Hovold
12 Nov, 2016
1 commit
-
Drop invalid user-pointer checks from ioctl handlers.
A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.Signed-off-by: Johan Hovold
19 Nov, 2014
1 commit
-
Fix reporting of overrun errors, which should only be reported once
using the inserted null character.Fixes: 6b8f1ca5581b ("USB: ssu100: set tty_flags in ssu100_process_packet")
Cc: stable
Signed-off-by: Johan Hovold
09 Jan, 2014
1 commit
-
None of these files are actually using any __init type directives
and hence don't need to include . Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.Signed-off-by: Paul Gortmaker
Signed-off-by: Greg Kroah-Hartman
04 Jan, 2014
1 commit
-
Remove redundant ioctl debugging from subdrivers. The ioctl request code
has already been logged by usb-serial core.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
18 Jun, 2013
1 commit
-
This moves the allocation of minor device numbers from a static array to
be dynamic, using the idr interface. This means that you could
potentially get "gaps" in a minor number range for a single USB serial
device with multiple ports, but all should still work properly.We remove the 'minor' field from the usb_serial structure, as it no
longer makes any sense for it (use the field in the usb_serial_port
structure if you really want to know this number), and take the fact
that we were overloading a number in this field to determine if we had
initialized the minor numbers or not, and just use a flag variable
instead.Note, we still have the limitation of 255 USB to serial devices in the
system, as that is all we are registering with the TTY layer at this
point in time.Tested-by: Tobias Winter
Reviewed-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
26 Mar, 2013
4 commits
-
Switch to the generic TIOCMIWAIT implementation.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
The generic close operation will be used if the close field is left
uninitialised.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
The disconnect callback is set to the generic implementation by
usb-serial core if NULL.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
22 Mar, 2013
1 commit
-
Use the port wait queue and make sure to check the serial disconnected
flag before accessing private port data after waking up.This is is needed as the private port data (including the wait queue
itself) can be gone when waking up after a disconnect.Cc: stable
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
22 Feb, 2013
1 commit
-
Pull tty/serial patches from Greg Kroah-Hartman:
"Here's the big tty/serial driver patches for 3.9-rc1.More tty port rework and fixes from Jiri here, as well as lots of
individual serial driver updates and fixes.All of these have been in the linux-next tree for a while."
* tag 'tty-3.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: (140 commits)
tty: mxser: improve error handling in mxser_probe() and mxser_module_init()
serial: imx: fix uninitialized variable warning
serial: tegra: assume CONFIG_OF
TTY: do not update atime/mtime on read/write
lguest: select CONFIG_TTY to build properly.
ARM defconfigs: add missing inclusions of linux/platform_device.h
fb/exynos: include platform_device.h
ARM: sa1100/assabet: include platform_device.h directly
serial: imx: Fix recursive locking bug
pps: Fix build breakage from decoupling pps from tty
tty: Remove ancient hardpps()
pps: Additional cleanups in uart_handle_dcd_change
pps: Move timestamp read into PPS code proper
pps: Don't crash the machine when exiting will do
pps: Fix a use-after free bug when unregistering a source.
pps: Use pps_lookup_dev to reduce ldisc coupling
pps: Add pps_lookup_dev() function
tty: serial: uartlite: Support uartlite on big and little endian systems
tty: serial: uartlite: Fix sparse and checkpatch warnings
serial/arc-uart: Miscll DT related updates (Grant's review comments)
...Fix up trivial conflicts, mostly just due to the TTY config option
clashing with the EXPERIMENTAL removal.
14 Feb, 2013
1 commit
-
Make sure serial-driver dtr_rts is called with disc_mutex held after
checking the disconnected flag.Due to a bug in the tty layer, dtr_rts may get called after a device has
been disconnected and the tty-device unregistered. Some drivers have had
individual checks for disconnect to make sure the disconnected interface
was not accessed, but this should really be handled in usb-serial core
(at least until the long-standing tty-bug has been fixed).Note that the problem has been made more acute with commit 0998d0631001
("device-core: Ensure drvdata = NULL when no driver is bound") as the
port data is now also NULL when dtr_rts is called resulting in further
oopses.Reported-by: Chris Ruehl
Cc: stable
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
16 Jan, 2013
3 commits
-
Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.Now, the one where most of tty_port_tty_get gets removed:
tty_flip_buffer_push.IOW we also closed all the races in drivers not using tty_port_tty_get
at all yet.Also we move tty_flip_buffer_push declaration from include/linux/tty.h
to include/linux/tty_flip.h to all others while we are changing it
anyway.Signed-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman -
Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.tty_insert_flip_char is the next one to proceed. This one is used all
over the code, so the patch is huge.Signed-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman -
Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty pointer in
many call sites. Only tty_port will be needed and hence no more
tty_port_tty_get calls in those paths.Now 4 string flipping ones are on turn:
* tty_insert_flip_string_flags
* tty_insert_flip_string_fixed_flag
* tty_prepare_flip_string
* tty_prepare_flip_string_flagsSigned-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman
01 Nov, 2012
1 commit
-
Remove all MODULE_VERSION macros and driver-version information (except
for garmin_gps which uses it in a status reply).It is the kernel version that matters and not some private version
scheme which rarely even gets updated.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2012
1 commit
-
Fix port-data memory leak by replacing attach and release with
port_probe and port_remove.Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.Compile-only tested.
Cc:
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
02 Oct, 2012
1 commit
-
Pull USB changes from Greg Kroah-Hartman:
"Here is the big USB pull request for 3.7-rc1There are lots of gadget driver changes (including copying a bunch of
files into the drivers/staging/ccg/ directory so that the other gadget
drivers can be fixed up properly without breaking that driver), and we
remove the old obsolete ub.c driver from the tree.There are also the usual XHCI set of updates, and other various driver
changes and updates. We also are trying hard to remove the old dbg()
macro, but the final bits of that removal will be coming in through
the networking tree before we can delete it for good.All of these patches have been in the linux-next tree.
Signed-off-by: Greg Kroah-Hartman "
Fix up several annoying - but fairly mindless - conflicts due to the
termios structure having moved into the tty device, and often clashing
with dbg -> dev_dbg conversion.* tag 'usb-3.6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (339 commits)
USB: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
USB: uas: fix gcc warning
USB: uas: fix locking
USB: Fix race condition when removing host controllers
USB: uas: add locking
USB: uas: fix abort
USB: uas: remove aborted field, replace with status bit.
USB: uas: fix task management
USB: uas: keep track of command urbs
xhci: Intel Panther Point BEI quirk.
powerpc/usb: remove checking PHY_CLK_VALID for UTMI PHY
USB: ftdi_sio: add TIAO USB Multi-Protocol Adapter (TUMPA) support
Revert "usb : Add sysfs files to control port power."
USB: serial: remove vizzini driver
usb: host: xhci: Fix Null pointer dereferencing with 71c731a for non-x86 systems
Increase XHCI suspend timeout to 16ms
USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq
USB: sierra_ms: don't keep unused variable
fsl/usb: Add support for USB controller version 2.4
USB: qcaux: add Pantech vendor class match
...
15 Sep, 2012
2 commits
-
Now that the dbg() macro is no longer being used in the driver,
the debug module parameter doesn't do anything at all. So remove
it so as to not confuse people.CC: Alan Stern
CC: Rusty Russell
CC: Mauro Carvalho Chehab
Signed-off-by: Greg Kroah-Hartman -
dbg() was a very old USB-serial-specific macro.
This patch removes it from being used in the
driver and uses dev_dbg() instead.CC: Alan Stern
CC: Rusty Russell
CC: Mauro Carvalho Chehab
Signed-off-by: Greg Kroah-Hartman
17 Jul, 2012
1 commit
-
This will let us sort out a whole pile of tty related races. The
alternative would be to keep points and refcount the termios objects.
However
1. They are tiny anyway
2. Many devices don't use the stored copies
3. We can remove a pty special caseSigned-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
09 May, 2012
1 commit
-
This reworks the usb_serial_register_drivers() and
usb_serial_deregister_drivers() to not need a pointer to a struct
usb_driver anymore. The usb_driver structure is now created dynamically
and registered and unregistered as needed.This saves lines of code in each usb-serial driver. All in-kernel users
of these functions were also fixed up at this time. The pl2303 driver
was tested that everything worked properly.Thanks for the idea to do this from Alan Stern.
Cc: Adhir Ramjiawan
Cc: Alan Stern
Cc: Al Borchers
Cc: Aleksey Babahin
Cc: Andrew Morton
Cc: Andrew Worsley
Cc: Bart Hartgers
Cc: Bill Pemberton
Cc: Dan Carpenter
Cc: Dan Williams
Cc: Donald Lee
Cc: Eric Dumazet
Cc: "Eric W. Biederman"
Cc: Felipe Balbi
Cc: Gary Brubaker
Cc: Jesper Juhl
Cc: Jiri Kosina
Cc: Johan Hovold
Cc: Julia Lawall
Cc: Kautuk Consul
Cc: Kuninori Morimoto
Cc: Lonnie Mendez
Cc: Matthias Bruestle and Harald Welte
Cc: Matthias Urlichs
Cc: Mauro Carvalho Chehab
Cc: Michal Sroczynski
Cc: "Michał Wróbel"
Cc: Oliver Neukum
Cc: Paul Gortmaker
Cc: Peter Berger
Cc: Preston Fick
Cc: "Rafael J. Wysocki"
Cc: Rigbert Hamisch
Cc: Rusty Russell
Cc: Simon Arlott
Cc: Support Department
Cc: Thomas Tuttle
Cc: Uwe Bonnes
Cc: Wang YanQing
Cc: William Greathouse
Signed-off-by: Greg Kroah-Hartman
08 May, 2012
3 commits
-
This is now set by the usb-serial core, no need for the driver to
individually set it.Thanks to Alan Stern for the idea to get rid of it.
Cc: William Greathouse
Cc: Matthias Bruestle and Harald Welte
Cc: Lonnie Mendez
Cc: Peter Berger
Cc: Al Borchers
Cc: Gary Brubaker
Cc: Oliver Neukum
Cc: Matthias Urlichs
Cc: Support Department
Cc: Rusty Russell
Cc: Alan Stern
Cc: Mauro Carvalho Chehab
Cc: Kautuk Consul
Cc: Bill Pemberton
Cc: Paul Gortmaker
Cc: Bart Hartgers
Cc: Johan Hovold
Cc: Preston Fick
Cc: Uwe Bonnes
Cc: Simon Arlott
Cc: Andrew Worsley
Cc: "Michał Wróbel"
Cc: Andrew Morton
Cc: Eric Dumazet
Cc: "Eric W. Biederman"
Cc: Felipe Balbi
Cc: Aleksey Babahin
Cc: Dan Carpenter
Cc: Jiri Kosina
Cc: Donald Lee
Cc: Julia Lawall
Cc: Michal Sroczynski
Cc: Wang YanQing
Cc: Dan Williams
Cc: Thomas Tuttle
Cc: Rigbert Hamisch
Cc: "Rafael J. Wysocki"
Cc: Kuninori Morimoto
Cc: Jesper Juhl
Cc: Adhir Ramjiawan
Signed-off-by: Greg Kroah-Hartman -
This is now set by the usb-serial core, no need for the driver to
individually set it.Thanks to Alan Stern for the idea to get rid of it.
Cc: William Greathouse
Cc: Matthias Bruestle and Harald Welte
Cc: Lonnie Mendez
Cc: Peter Berger
Cc: Al Borchers
Cc: Gary Brubaker
Cc: Oliver Neukum
Cc: Matthias Urlichs
Cc: Support Department
Cc: Rusty Russell
Cc: Alan Stern
Cc: Mauro Carvalho Chehab
Cc: Kautuk Consul
Cc: Bill Pemberton
Cc: Paul Gortmaker
Cc: Bart Hartgers
Cc: Johan Hovold
Cc: Preston Fick
Cc: Uwe Bonnes
Cc: Simon Arlott
Cc: Andrew Worsley
Cc: "Michał Wróbel"
Cc: Andrew Morton
Cc: Eric Dumazet
Cc: "Eric W. Biederman"
Cc: Felipe Balbi
Cc: Aleksey Babahin
Cc: Dan Carpenter
Cc: Jiri Kosina
Cc: Donald Lee
Cc: Julia Lawall
Cc: Michal Sroczynski
Cc: Wang YanQing
Cc: Dan Williams
Cc: Thomas Tuttle
Cc: Rigbert Hamisch
Cc: "Rafael J. Wysocki"
Cc: Kuninori Morimoto
Cc: Jesper Juhl
Cc: Adhir Ramjiawan
Signed-off-by: Greg Kroah-Hartman -
This patch (as1551) cleans up the PM-related entries in the usb_driver
structures of the various USB serial driver modules. Those entries
are now filled in by the usb-serial core during driver registration,
so they don't need to be initialized explicitly in the source code.The same is true of the one remaining no_dynamic_id entry.
reset_resume remains a small problem, because the serial core doesn't
support it. The patch ignores these entries.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman
04 May, 2012
1 commit
-
dbg() was used a lot a long time ago to trace code flow. Now that we have
ftrace, this isn't needed at all, so remove these calls.CC: Rusty Russell
CC: Alan Stern
CC: Mauro Carvalho Chehab
Signed-off-by: Greg Kroah-Hartman
29 Feb, 2012
1 commit
-
This converts the ssu100.c driver to use the module_usb_serial_driver() call
instead of having to have a module_init/module_exit function, saving a lot
of duplicated code.CC: Rusty Russell
CC: Alan Stern
CC: Mauro Carvalho Chehab
Signed-off-by: Greg Kroah-Hartman
25 Feb, 2012
1 commit
-
This patch (as1528) modifies the following usb-serial drivers to
utilize the new usb_serial_{de}register_drivers() routines:qcaux, qcserial, safe_serial, siemens_mpi, sierra,
spcp8x5, ssu100, and symbolserial.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman
13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
18 Feb, 2011
3 commits
-
We don't use it so we can trim it from here as we try and stamp the file
object dependencies out of the serial code.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
Doing tiocmget was such fun we should do tiocmset as well for the same
reasonsSigned-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
We don't actually need this and it causes problems for internal use of
this functionality. Currently there is a single use of the FILE * pointer.
That is the serial core which uses it to check tty_hung_up_p. However if
that is true then IO_ERROR is also already set so the check may be removed.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
11 Nov, 2010
1 commit
-
The max_packet_size logic is taken from ftdi_sio, but it's not needed
for this device. This also makes proces_read_urb simpler.Signed-off-by: Bill Pemberton
Signed-off-by: Greg Kroah-Hartman
23 Oct, 2010
1 commit
-
Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman