29 May, 2019

1 commit

• 9bec226d8   media: v4l2-pci-skeleton.c: fix doc warning ... Browse Code »

  Document the 'field' field to fix this warning:

  samples/v4l/v4l2-pci-skeleton.c:80: warning: Function parameter or member 'field' not described in 'skeleton'

  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2019-05-29 01:14:28 +0800  

21 May, 2019

1 commit

• ec8f24b7f   treewide: Add SPDX license identifier - Makefile/Kconfig ... Browse Code »

  Add SPDX license identifiers to all Make/Kconfig files which:

  - Have no license information of any form

  These files fall under the project license, GPL v2 only. The resulting SPDX
  license identifier is:

  GPL-2.0-only

  Signed-off-by: Thomas Gleixner
  Signed-off-by: Greg Kroah-Hartman

  Thomas Gleixner

  2019-05-21 16:50:46 +0800  

26 Jan, 2019

1 commit

• 60b652795   media: v4l2-pci-skeleton.c: fix outdated irq code ... Browse Code »

  Fix the outdated irq example code. It is under an #ifdef TODO
  so it is never actually compiled and this code was never compiled.

  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2019-01-26 04:47:06 +0800  

04 Dec, 2018

1 commit

• b52b88ce5   media: v4l2-pci-skeleton: replace vb2_buffer with vb2_v4l2_buffer ... Browse Code »

  Commit 2d7007153f0c ("[media] media: videobuf2: Restructure vb2_buffer")
  replaced vb2_buffer with vb2_v4l2_buffer in all v4l2 drivers. The
  restructuring skipped the v4l2-pci-skeleton, probably because it resides
  outside the drivers directory.

  The v4l2_buf_ops assume that the passed buffer is a vb2_v4l2_buffer.
  This is not the case if the skel_buffer is based on vb2_buffer instead
  of vb2_v4l2_buffer.

  Replace vb2_buffer with vb2_v4l2_buffer in the skeleton to make sure
  that future drivers that are based on the skeleton use vb2_v4l2_buffer.

  Signed-off-by: Michael Tretter
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Michael Tretter

  2018-12-04 03:41:51 +0800  

05 Oct, 2017

1 commit

• 15a35ca66   [media] media: v4l2-pci-skeleton: Fix error handling path in 'skeleton_probe()' ... Browse Code »

  If this memory allocation fails, we must release some resources, as
  already done in the code below and above.

  Signed-off-by: Christophe JAILLET
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Christophe JAILLET

  2017-10-05 03:55:02 +0800  

20 Aug, 2017

1 commit

• aa7d01fd7   media: v4l2-pci-skeleton: constify vb2_ops structures ... Browse Code »

  These vb2_ops structures are only stored in the ops field of a
  vb2_queue structure, which is declared as const. Thus the vb2_ops
  structures themselves can be const.

  Done with the help of Coccinelle.

  //
  @r disable optional_qualifier@
  identifier i;
  position p;
  @@
  static struct vb2_ops i@p = { ... };

  @ok@
  identifier r.i;
  struct vb2_queue e;
  position p;
  @@
  e.ops = &i@p;

  @bad@
  position p != {r.p,ok.p};
  identifier r.i;
  struct vb2_ops e;
  @@
  e@i@p

  @depends on !bad disable optional_qualifier@
  identifier r.i;
  @@
  static
  +const
  struct vb2_ops i = { ... };
  //

  Signed-off-by: Julia Lawall
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Julia Lawall

  2017-08-20 20:03:09 +0800  

09 Jul, 2016

2 commits

• 36c0f8b32   [media] vb2: replace void *alloc_ctxs by struct device *alloc_devs ... Browse Code »

  Make this a proper typed array. Drop the old allocate context code since
  that is no longer used.

  Note that the memops functions now get a struct device pointer instead of
  the struct device ** that was there initially (actually a void pointer to
  a struct containing only a struct device pointer).

  This code is now a lot cleaner.

  Signed-off-by: Hans Verkuil
  Reviewed-by: Laurent Pinchart
  Cc: Sakari Ailus
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2016-07-09 01:45:07 +0800  
• 8f10c2db7   [media] v4l2-pci-skeleton: set q->dev instead of allocating a context ... Browse Code »

  Stop using alloc_ctx as that is now no longer needed.

  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2016-07-09 01:34:57 +0800  

10 May, 2016

1 commit

• 0185f8501   [media] samples: v4l: from Documentation to samples directory ... Browse Code »

  With the new autoksyms support, we can run into a situation where
  the v4l pci skeleton module is the only one using some exported
  symbols that get dropped because they are never referenced by
  the kernel otherwise, causing a build problem:

  ERROR: "vb2_dma_contig_memops" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "vb2_dma_contig_init_ctx_attrs" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_match_dv_timings" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_find_dv_timings_cap" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_valid_dv_timings" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_enum_dv_timings_cap" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "vb2_dma_contig_cleanup_ctx" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!

  Specifically, we do look in the samples directory for users of
  symbols, but not the Documentation directory.

  This solves the build problem by moving the connector sample into
  the same directory as the other samples.

  Fixes: 23121ca2b56b ("kbuild: create/adjust generated/autoksyms.h")

  Signed-off-by: Arnd Bergmann

  Arnd Bergmann

  2016-05-10 05:34:37 +0800