31 Aug, 2016
1 commit
-
This patch fixes two minor issues:
(1) An inaccurate comment
(2) A spelling mistake in dev_err message ("upgarde" -> "upgrade")Reported-by: Joe Perches
Reported-by: Colin Ian King
Signed-off-by: Eli Billauer
Signed-off-by: Greg Kroah-Hartman
01 May, 2016
1 commit
-
If devm_add_action() fails we are explicitly calling dma_unmap_single(),
pci_unmap_single() and kfree(). Lets use the helper
devm_add_action_or_reset() and return directly in case of error, as we
know that the cleanup function has been already called by the helper if
there was any error. At that same time remove the variable rc which
becomes unused now.Signed-off-by: Sudip Mukherjee
Signed-off-by: Greg Kroah-Hartman
06 Mar, 2016
1 commit
-
A couple of fields in a data structure, which is used by the driver only,
were not initialized properly during the driver's setup.The primary issue with this bug was that channel->wr_buf_size remained zero,
so calls to dma_sync_single_for_cpu() took place with zero size, and
consequently did nothing.This had a rather minimal practical impact, because
(a) these calls are NOPs on Intel/AMD platforms, as well as other platforms
with coherent cache, and
(b) it's extremely rare that any cache line would survive between two reads
from a given DMA bufferHence no significant practical difference is expected with this patch.
Signed-off-by: Eli Billauer
Signed-off-by: Greg Kroah-Hartman
06 Aug, 2015
1 commit
-
Until now, only 32-bit DMA addressing was allowed, following a report on
some old Intel machine that dropped 64-bit PCIe packets, even though
pci_set_dma_mask() was successful with DMA_BIT_MASK(64).But then came TI's Keystone II chip (ARM Cortex A15 + DSPs), which refuses
32-bit DMA addressing (for good reasons). So 64-bit DMA is allowed as a
fallback option.Signed-off-by: Eli Billauer
Signed-off-by: Greg Kroah-Hartman
25 May, 2015
1 commit
-
If NO_DMA=y:
drivers/built-in.o: In function `xilly_of_unmap':
xillybus_of.c:(.text+0xa860e): undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `xilly_map_single_of':
xillybus_of.c:(.text+0xa8668): undefined reference to `dma_map_single'
xillybus_of.c:(.text+0xa8676): undefined reference to `dma_mapping_error'
xillybus_of.c:(.text+0xa86ca): undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `xilly_dma_sync_single_for_device_of':
xillybus_of.c:(.text+0xa8700): undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `xilly_dma_sync_single_for_cpu_of':
xillybus_of.c:(.text+0xa8726): undefined reference to `dma_sync_single_for_cpu'Signed-off-by: Geert Uytterhoeven
Acked-by: Eli Billauer
--
v2:
- Add Acked-by, send to char and misc drivers maintainers.
Signed-off-by: Greg Kroah-Hartman
03 Apr, 2015
1 commit
-
The API allows the application to flush a host-to-FPGA stream by calling
write() with the data count set to zero. Before this patch, copy_from_user()
was called with a non-zero byte count, which possibly made it attempt to read
from unmapped user memory. Such attempts caused the driver to return -EFAULT
instead of 0, even though the desired operation went through fine.This patch ensures the driver returns 0 on a successful flush.
Signed-off-by: Eli Billauer
Signed-off-by: Greg Kroah-Hartman
17 Mar, 2015
1 commit
-
of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)Signed-off-by: Fabian Frederick
Signed-off-by: Greg Kroah-Hartman
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
24 Sep, 2014
1 commit
-
This driver has been functional and stable throughout the year it has spent
in the staging area. It has been patched for minor bugs, coding style issues
and improvements during this period.This is the second submission of this move-out, after making several style
improvements, as suggested by Dan Carpenter.Signed-off-by: Eli Billauer
Signed-off-by: Greg Kroah-Hartman