15 May, 2014

2 commits

  • Managed resources are becoming more and more popular in drivers. Let's
    implement managed polled input devices, to complement managed regular input
    devices.

    Similarly to managed regular input devices only one new call
    devm_input_allocate_polled_device() is added and the rest of APIs is
    modified to work with both managed and non-managed devices.

    Reviewed-by: David Herrmann
    Tested-by: Alexander Shiyan
    Signed-off-by: Dmitry Torokhov

    Dmitry Torokhov
     
  • Polled device's attributes controlling polling rate and whether polling is
    enabled are attached to input device. We should have device core
    instantiate them for us, so that they are created by the time new device
    notification is sent to userspace, instead of doing it ourselves
    afterwards.

    Tested-by: Alexander Shiyan
    Signed-off-by: Dmitry Torokhov

    Dmitry Torokhov
     

29 Nov, 2011

1 commit


10 Nov, 2011

1 commit

  • With commit 67d0a0754455f89ef3946946159d8ec9e45ce33a we mark strict_strtox
    as obsolete. Convert all remaining such uses in drivers/input/.

    Also change long to appropriate types, and return error conditions
    from kstrtox separately, as Dmitry sugguests.

    Signed-off-by: JJ Ding
    Signed-off-by: Dmitry Torokhov

    JJ Ding
     

01 Nov, 2011

1 commit


09 Aug, 2011

1 commit

  • To allow open/ioctl(EVIOCGABS)/close use pattern for polled devices read
    the device in context of open() call instead of offloading the first read
    to a workqueue. This will ensure that once call to open() returns device
    would have cached reasonably recent axis values that can be retrieved via
    appropriate ioctl.

    Signed-off-by: Dmitry Torokhov

    Dmitry Torokhov
     

28 Apr, 2011

1 commit


01 Feb, 2011

1 commit


01 Dec, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

20 Feb, 2010

1 commit

  • When polled input device is opened and closed and there are no other
    users of polled device, the workqueue is created and destroyed in
    every open / close operation. It is probable that at some point
    dynamic allocation of internal parts of the workqueue cause changes to the
    workqueue.

    When a work is queued to the workqueue the work struct contains pointers
    to the workqueue data. If the workqueue has been changed and the work
    has never been queued to the new workqueue, work-struct contains pointers
    to the non-existing workqueue. This will cause crash at the work
    cancellation during device close since cancellation of a work assumes
    that the workqueue exists.

    To prevent that, work struct is cleaned up at device close. This keeps
    work struct clean for the next use.

    Signed-off-by: Samu Onkalo
    Signed-off-by: Dmitry Torokhov

    Samu Onkalo
     

08 Dec, 2009

1 commit


24 Nov, 2009

2 commits


20 Nov, 2009

1 commit

  • Sysfs entry for reading and setting of the polling interval. If the
    interval is set to 0, polling is stopped. Polling is restarted when
    interval is changed to non-zero.

    sysfs entries:
    poll = current polling interval in msec (RW)
    max = max allowed polling interval (RO)
    min = min allowed polling interval (RO)

    Minimum and maximum limit for interval can be set while setting up the
    device.

    Interval can be adjusted even if the input device is not currently open.

    [dtor@mail.ru: add kernel doc markup for the new fields]
    Signed-off-by: Samu Onkalo
    Signed-off-by: Dmitry Torokhov

    Samu Onkalo
     

18 Oct, 2009

1 commit


02 Apr, 2008

1 commit


21 Jan, 2008

1 commit

  • Rounding doesn't matter for the first tick, but we want
    succeeding ticks to be aligned on second boundary if poll
    interval is large enough.

    Also: cancel_rearming_delayed_workqueue is marked as obsolete
    in workqueue.h so use cancel_delayed_work_sync.

    Signed-off-by: Stephen Hemminger
    Acked-by: Arjan van de Ven
    Signed-off-by: Dmitry Torokhov

    Stephen Hemminger
     

26 Sep, 2007

1 commit


13 Jun, 2007

1 commit

  • To work around deficiences in Kconfig that allows to "select"
    a symbol without automatically selecting all dependencies for
    that symbol move input-polldev from drivers/input/misc to
    drivers/input thus removing extra dependency on CONFIG_INPUT_MISC.

    Signed-off-by: Dmitry Torokhov

    Dmitry Torokhov