01 May, 2008

1 commit


05 Mar, 2008

1 commit

  • extern does not belong in C files, move declaration to linux/debugfs.h
    fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static?
    fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

    Signed-off-by: Harvey Harrison
    Signed-off-by: Greg Kroah-Hartman

    Harvey Harrison
     

09 Feb, 2008

1 commit

  • Sometimes simple attributes might need to return an error, e.g. for
    acquiring a mutex interruptibly. In fact we have that situation in
    spufs already which is the original user of the simple attributes. This
    patch merged the temporarily forked attributes in spufs back into the
    main ones and allows to return errors.

    [akpm@linux-foundation.org: build fix]
    Signed-off-by: Christoph Hellwig
    Cc:
    Cc: Arnd Bergmann
    Cc: Greg KH
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

25 Jan, 2008

5 commits


21 Oct, 2007

1 commit


16 Oct, 2007

1 commit

  • Fix filesystems docbook warnings.

    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'name'
    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'mode'
    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'parent'
    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'value'
    Warning(linux-2.6.23-git8//include/linux/jbd.h:404): No description found for parameter 'h_lockdep_map'

    Signed-off-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

13 Oct, 2007

1 commit


19 Jul, 2007

1 commit

  • Hi,

    This patch kills the pointless debugfs rmdir() printk() when called on a
    non-empty directory. blktrace will sometimes have to call it a few times
    when forcefully ending a trace, which polutes the log with pointless
    warnings.

    Rationale:

    - It's more code to work-around this "problem" in the debugfs users, and
    you would have to add code to check for empty directories to do so (or
    assume that debugfs is using simple_ helpers, but that would be a
    layering violation).

    - Other rmdir() implementations don't complain about something this
    silly.

    Signed-off-by: Jens Axboe
    Signed-off-by: Greg Kroah-Hartman

    Jens Axboe
     

12 Jul, 2007

1 commit


03 May, 2007

1 commit


28 Apr, 2007

1 commit

  • I went to use this the other day, only to find it didn't exist.

    It's a straight copy of the debugfs u32 code, then s/u32/u64/. A quick
    test shows it seems to be working.

    Signed-off-by: Michael Ellerman
    Signed-off-by: Greg Kroah-Hartman

    Michael Ellerman
     

17 Feb, 2007

2 commits

  • Just mention which error will be returned if debugfs is disabled. Callers
    should be able to figure out themselves what they need to check.

    Signed-off-by: Cornelia Huck
    Signed-off-by: Greg Kroah-Hartman

    Cornelia Huck
     
  • debugfs: implement symbolic links

    Implement a new function debugfs_create_symlink() which can be used
    to create symbolic links in debugfs. This function can be useful
    for people moving functionality from /proc to debugfs (e.g. the
    gcov-kernel patch).

    Signed-off-by: Peter Oberparleiter
    Signed-off-by: Greg Kroah-Hartman

    Peter Oberparleiter
     

13 Feb, 2007

1 commit

  • Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

14 Dec, 2006

5 commits

  • Fix file and directory removal in debugfs. Add inotify support for file removal.

    The following scenario :
    create dir a
    create dir a/b

    cd a/b (some process goes in cwd a/b)

    rmdir a/b
    rmdir a

    fails due to the fact that "a" appears to be non empty. It is because
    the "b" dentry is not deleted from "a" and still in use. The same
    problem happens if "b" is a file. d_delete is nice enough to know when
    it needs to unhash and free the dentry if nothing else is using it or,
    if someone is using it, to remove it from the hash queues and wait for
    it to be deleted when it has no users.

    The nice side-effect of this fix is that it calls the file removal
    notification.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • Correct dentry count to handle creation errors.

    This patch puts a dput at the file creation instead of the file removal :
    lookup_one_len already returns a dentry with reference count of 1. Then,
    the dget() in simple_mknod increments it when the dentry is associated
    with a file. In a scenario where simple_create or simple_mkdir returns
    an error, this would lead to an unwanted increment of the reference
    counter, therefore making file removal impossible.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • Fix error handling of file and directory creation in DebugFS.

    The error path should release the file system because no _remove will be called
    for this erroneous creation.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • Minor coding style fixes along the way : 80 cols and a white space.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • Add inotify create and mkdir events to DebugFS.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     

26 Nov, 2006

1 commit


17 Nov, 2006

1 commit


04 Oct, 2006

1 commit


01 Oct, 2006

1 commit


27 Sep, 2006

2 commits

  • This eliminates the i_blksize field from struct inode. Filesystems that want
    to provide a per-inode st_blksize can do so by providing their own getattr
    routine instead of using the generic_fillattr() function.

    Note that some filesystems were providing pretty much random (and incorrect)
    values for i_blksize.

    [bunk@stusta.de: cleanup]
    [akpm@osdl.org: generic_fillattr() fix]
    Signed-off-by: "Theodore Ts'o"
    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Theodore Ts'o
     
  • The following patches reduce the size of the VFS inode structure by 28 bytes
    on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
    in the inode size on a UP kernel that is configured in a production mode
    (i.e., with no spinlock or other debugging functions enabled; if you want to
    save memory taken up by in-core inodes, the first thing you should do is
    disable the debugging options; they are responsible for a huge amount of bloat
    in the VFS inode structure).

    This patch:

    The filesystem or device-specific pointer in the inode is inside a union,
    which is pretty pointless given that all 30+ users of this field have been
    using the void pointer. Get rid of the union and rename it to i_private, with
    a comment to explain who is allowed to use the void pointer. This is just a
    cleanup, but it allows us to reuse the union 'u' for something something where
    the union will actually be used.

    [judith@osdl.org: powerpc build fix]
    Signed-off-by: "Theodore Ts'o"
    Signed-off-by: Judith Lebzelter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Theodore Ts'o
     

26 Sep, 2006

1 commit


01 Jul, 2006

1 commit


25 Jun, 2006

1 commit


23 Jun, 2006

1 commit

  • Extend the get_sb() filesystem operation to take an extra argument that
    permits the VFS to pass in the target vfsmount that defines the mountpoint.

    The filesystem is then required to manually set the superblock and root dentry
    pointers. For most filesystems, this should be done with simple_set_mnt()
    which will set the superblock pointer and then set the root dentry to the
    superblock's s_root (as per the old default behaviour).

    The get_sb() op now returns an integer as there's now no need to return the
    superblock pointer.

    This patch permits a superblock to be implicitly shared amongst several mount
    points, such as can be done with NFS to avoid potential inode aliasing. In
    such a case, simple_set_mnt() would not be called, and instead the mnt_root
    and mnt_sb would be set directly.

    The patch also makes the following changes:

    (*) the get_sb_*() convenience functions in the core kernel now take a vfsmount
    pointer argument and return an integer, so most filesystems have to change
    very little.

    (*) If one of the convenience function is not used, then get_sb() should
    normally call simple_set_mnt() to instantiate the vfsmount. This will
    always return 0, and so can be tail-called from get_sb().

    (*) generic_shutdown_super() now calls shrink_dcache_sb() to clean up the
    dcache upon superblock destruction rather than shrink_dcache_anon().

    This is required because the superblock may now have multiple trees that
    aren't actually bound to s_root, but that still need to be cleaned up. The
    currently called functions assume that the whole tree is rooted at s_root,
    and that anonymous dentries are not the roots of trees which results in
    dentries being left unculled.

    However, with the way NFS superblock sharing are currently set to be
    implemented, these assumptions are violated: the root of the filesystem is
    simply a dummy dentry and inode (the real inode for '/' may well be
    inaccessible), and all the vfsmounts are rooted on anonymous[*] dentries
    with child trees.

    [*] Anonymous until discovered from another tree.

    (*) The documentation has been adjusted, including the additional bit of
    changing ext2_* into foo_* in the documentation.

    [akpm@osdl.org: convert ipath_fs, do other stuff]
    Signed-off-by: David Howells
    Acked-by: Al Viro
    Cc: Nathan Scott
    Cc: Roland Dreier
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     

09 Jun, 2006

2 commits


29 Mar, 2006

2 commits

  • This is a conversion to make the various file_operations structs in fs/
    const. Basically a regexp job, with a few manual fixups

    The goal is both to increase correctness (harder to accidentally write to
    shared datastructures) and reducing the false sharing of cachelines with
    things that get dirty in .data (while .rodata is nicely read only and thus
    cache clean)

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     
  • Mark the f_ops members of inodes as const, as well as fix the
    ripple-through this causes by places that copy this f_ops and then "do
    stuff" with it.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

21 Mar, 2006

1 commit


07 Feb, 2006

1 commit


10 Jan, 2006

1 commit