25 Sep, 2008
2 commits
-
Remove the unneeded (struct atl1e_adapter *) casts, for hw->adapter
already has type atl1e_adapter *.Signed-off-by: Jie Yang
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Lockdep warns about the mdio_lock taken with interrupts enabled then later
taken from interrupt context. Initially, I considered changing these
to spin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init()
and saw that it calls msleep(). Sleeping while holding a spinlock is
not allowed either.In the probe path, we haven't registered the interrupt handler, so
it can't poke at this card yet. It's before we call register_netdev(),
so I don't think any other threads can reach this card either. If I'm
right, we don't need a spinlock at all.Signed-off-by: Matthew Wilcox
Signed-off-by: Jeff Garzik
27 Aug, 2008
1 commit
-
Doesn't cause problems (yet) because err gets zeroed earlier.
Signed-off-by: Ilpo Järvinen
Signed-off-by: Jeff Garzik
14 Aug, 2008
2 commits
-
Signed-off-by: Jeff Garzik
-
There doesn't seem to be a compelling reason why atl1e_setup_mac_ctrl()
is marked as "inline":It's not used in any place where speed would matter much, and as long as
it has only one caller non-ancient gcc versions anyway inline it
automatically.This patch fixes the following compile error with gcc 3.4:
...
CC drivers/net/atl1e/atl1e_main.o
atl1e_main.c: In function `atl1e_check_link':
atl1e_main.c:50: sorry, unimplemented: inlining failed in call to
atl1e_main.c:196: sorry, unimplemented: called from here
make[4]: *** [drivers/net/atl1e/atl1e_main.o] Error 1Reported-by: Adrian Bunk
Signed-off-by: Adrian Bunk
Signed-off-by: Jeff Garzik
23 Jul, 2008
2 commits
-
Signed-off-by: Jeff Garzik
-
Full patch for the Atheros L1E Gigabit Ethernet driver.
Supportring AR8121, AR8113 and AR8114Signed-off-by: Jie Yang
Signed-off-by: Jeff Garzik
