27 Jul, 2008
1 commit
-
The acard->wss pointer is uninitialized in this function
which leads to crash during chip PNP detection.Signed-off-by: Krzysztof Helt
Acked-by: Rene Herman
Signed-off-by: Takashi Iwai
13 Jun, 2008
1 commit
-
This patch adds support for WSS compatible Opti93x
codec to the cs4231-lib.Signed-off-by: Krzysztof Helt
Tested-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
01 Feb, 2008
3 commits
-
This busy_wait is not needed after latest changes
to the cs4231-libSigned-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This header file exists only for some hacks to adapt alsa-driver
tree. It's useless for building in the kernel. Let's move a few
lines in it to sound/core.h and remove it.
With this patch, sound/driver.h isn't removed but has just a single
compile warning to include it. This should be really killed in
future.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
2.4 these were useful in providing an easy path to setting the resources,
but in 2.6 they retain function as a layering violation only.
This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
only remaining user of pnp_init_resource_table(), pnp_resource_change() and
pnp_manual_config_dev() (and, in fact, of 'struct pnp_resource_table') in
the tree outide of drivers/pnp itself meaning it makes for more cleanup
potential inside the PnP layer.
Thomas Renninger acked their removal from that side, you did from the ALSA
side (CC list just copied from that thread).
Against current alsa-kernel HG. Many more potential cleanups in there, but
this _only_ removes the pnp_resource_change code. Compile tested against
current alsa-kernel HG and compile- and use-tested against 2.6.23.x (few
offsets).
Cc: Thomas RenningerSigned-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
16 Oct, 2007
8 commits
-
The last patches to replace with schedule_timeout() don't work as expected.
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Signed-off-by: Jaroslav Kysela
-
This patch replaces long msleeps in waiting loops
with schedule_timeout() calls.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
While I'm at it another 'while I'm there' -- replace commented out debug
code with snd-printd{,d}.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
When the ad1848/cs2431 is first being initialized, auto-calibration may not
be set causing a timeout waiting for it in snd_ad1848/cs4231_mce_down().
This has no dire consequences other than an alarming printk, but since what
we need to wait for is for the calibration to _finish_, let's just check for
that instead.
The early chips need a slight delay (as commented -- 5 sample periods) to be
sure that _if_ calibration is going to happen, it has started when we check
While the CS4231A datasheet implies it'll happen immediately on downing MCE,
some testing is showing that there's a window there as well, so just do the
delay everywhere.
Thanks to Krysztof Helt for pinpointing this problem.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This patch replaces a common delay loop by a function.
It also uses ARRAY_SIZE macro for the rates table.
Acked-by: Rene HermanSigned-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This patch uses the Kconfig parameters SND_AD1848_LIB and
SND_CS4231_LIB instead of mentioning each driver that requires
the ad1848-lib or cs4231-lib separately in the Makefiles.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
The mode change / recalibration doesn't work always with opl3sa2 devices,
e.g. the first time it's played back. The patch fixes the problem.Signed-off-by: Paul Vojta
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
16 May, 2007
1 commit
-
isa_register_driver() returns an error if no device is found
and it's no fatal error for the drivers with pnp support.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
11 May, 2007
4 commits
-
isa_bus: delete snd_ prefix from the (sysfs visible) device/driver names.
Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Added a new macro snd_pcm_group_for_each_entry() just for code cleanup.
Old macros, snd_pcm_group_for_each() and snd_pcm_group_substream_entry(),
are removed.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Port the rest of ALSA ISA drivers to use isa_driver framework
instead of platform_driver.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
cs4231: port to isa_bus infrastructure.
Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
05 Oct, 2006
1 commit
-
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around. On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).Where appropriate, an arch may override the generic storage facility and do
something different with the variable. On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions. Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller. A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.I've build this code with allyesconfig for x86_64 and i386. I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.This will affect all archs. Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:struct pt_regs *old_regs = set_irq_regs(regs);
And put the old one back at the end:
set_irq_regs(old_regs);
Don't pass regs through to generic_handle_irq() or __do_IRQ().
In timer_interrupt(), this sort of change will be necessary:
- update_process_times(user_mode(regs));
- profile_tick(CPU_PROFILING, regs);
+ update_process_times(user_mode(get_irq_regs()));
+ profile_tick(CPU_PROFILING);I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().Some notes on the interrupt handling in the drivers:
(*) input_dev() is now gone entirely. The regs pointer is no longer stored in
the input_dev struct.(*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
something different depending on whether it's been supplied with a regs
pointer or not.(*) Various IRQ handler function pointers have been moved to type
irq_handler_t.Signed-Off-By: David Howells
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
13 Jul, 2006
1 commit
-
WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/sound/isa/opti9xx/snd-miro.ko
needs unknown symbol snd_cs4231_create
WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/sound/isa/opti9xx/snd-miro.ko
needs unknown symbol snd_cs4231_pcm
WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/sound/isa/opti9xx/snd-miro.ko
needs unknown symbol snd_cs4231_timer
WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/sound/isa/opti9xx/snd-miro.ko
needs unknown symbol snd_cs4231_mixer
WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/fs/reiser4/reiser4.ko needs
unknown symbol generic_file_readSigned-off-by: Randy Dunlap
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
03 Jul, 2006
1 commit
-
Signed-off-by: Thomas Gleixner
Cc: Ingo Molnar
Cc: "David S. Miller"
Cc: Benjamin Herrenschmidt
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Apr, 2006
2 commits
-
Unregister the platform device again if the probe was unsuccessful.
This restores the behaviour of not loading the driver on probe() failure.
Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai -
Continue with the next one on error from device registration.
This would seem the correct thing to do, even if it's not the probe()
error that we're getting.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
28 Mar, 2006
1 commit
-
Remove the assumption that pnp_register_driver() returns the number of devices
claimed.Signed-off-by: Bjorn Helgaas
Cc: Adam Belay
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
22 Mar, 2006
3 commits
-
Modules: CS4236+ driver
Fixed a typo in snd_cs4236_put_master_digital(), resulting in silence
right channel.Signed-off-by: Takashi Iwai
-
Fix the check of enable module option in probe of platform_device drivers.
It shouldn't break the loop but just ignore if enable[i] is false.Signed-off-by: Takashi Iwai
-
Semaphore to mutex conversion.
The conversion was generated via scripts, and the result was validated
automatically via a script as well.Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai
25 Feb, 2006
1 commit
-
I noticed on 2.6.16-rc4 that my MPU-401 wasn't functional, due to a simple
copy & paste error in sound/isa/cs423x/cs4236.c.Acked-by: Takashi Iwai
Cc: Jaroslav Kysela
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
01 Feb, 2006
1 commit
-
Modules: CS4236+ driver
PnP ids for Netfinity 3000 builtin soundcard.
This one works for me.
This patch was submitted through kernel Bugzilla #4214.
Signed-off-by: Adrian Bunk
Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai
23 Jan, 2006
1 commit
-
Modules: CS4236+ driver
Signed-off-by: Jaroslav Kysela
22 Jan, 2006
1 commit
-
Fix compilation of some ISA drivers without CONFIG_PNP.
Signed-off-by: Takashi Iwai
03 Jan, 2006
9 commits
-
Call platform_device_unregister() for all platform devices that we've
registered.Signed-off-by: Clemens Ladisch
-
Modules: CS4231 driver
Fix a compile warning (unused variable).
Signed-off-by: Takashi Iwai
-
Modules: CS4231 driver,CS4236+ driver
Add CS4232 PnP BIOS support. Still experimental.
Signed-off-by: Takashi Iwai
-
Modules: CS4231 driver
Use mce_down() again in the resume callback.
Signed-off-by: Takashi Iwai
-
Modules: CS4236+ driver
Rewrite the probe/remove with platform_device.
Signed-off-by: Takashi Iwai
-
Modules: CS4231 driver
Rewrite the probe/remove with platform_device.
Signed-off-by: Takashi Iwai
-
Modules: CS4231 driver
Fix PM support.
Signed-off-by: Takashi Iwai
-
Modules: CS4231 driver,CS4236+ driver
Remove xxx_t typedefs from the ISA CS423x drivers.
Signed-off-by: Takashi Iwai
-
Modules: CS4231 driver
Clean up ISA cs4231 code, removing experimental EBUS/SBUS merge,
to improve readability.Signed-off-by: Takashi Iwai