Eric Lee / smarc-fsl-linux-kernel

22 Jul, 2020

1 commit

2ca76b3e4 regulator: Replace HTTP links with HTTPS ones ... Browse Code »

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov
Acked-by: Rob Herring
Link: https://lore.kernel.org/r/20200719200623.61524-1-grandmaster@al2klimov.de
Signed-off-by: Mark Brown

Alexander A. Klimov
2020-07-22 21:43:48 +0800

26 Jun, 2020

2 commits

44455a6d3 regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() ... Browse Code »

Until now the aforementioned return value has been ignored.
Previous and current calls to tps65217_reg_read() return
instantly when the value is not 0, so let's do that.

Fixes the following W=1 warning:

drivers/regulator/tps65217-regulator.c: In function ‘tps65217_regulator_probe’:
drivers/regulator/tps65217-regulator.c:227:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
227 | int i, ret;
| ^~~

Signed-off-by: Lee Jones
Cc: Russ Dill
Cc: Keerthy
Cc: AnilKumar Ch
Cc: linux-omap@vger.kernel.org
Link: https://lore.kernel.org/r/20200626065738.93412-7-lee.jones@linaro.org
Signed-off-by: Mark Brown

Lee Jones
2020-06-26 22:34:22 +0800
f10a5e499 regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check ... Browse Code »

'rid' is declared as unsigned int, so there is little point checking for < 0 is always false [-Wtype-limits]
127 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
| ^
drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_disable’:
drivers/regulator/tps65217-regulator.c:140:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
140 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
| ^

Signed-off-by: Lee Jones
Cc: Russ Dill
Cc: Keerthy
Cc: AnilKumar Ch
Cc: linux-omap@vger.kernel.org
Link: https://lore.kernel.org/r/20200626065738.93412-6-lee.jones@linaro.org
Signed-off-by: Mark Brown

Lee Jones
2020-06-26 22:34:21 +0800

09 May, 2020

1 commit

60ab7f415 regulator: use linear_ranges helper ... Browse Code »

Change the regulator helpers to use common linear_ranges code.

Signed-off-by: Matti Vaittinen
Reviewed-by: Mark Brown
Acked-by: Charles Keepax
Acked-by: Adam Thomson
Link: https://lore.kernel.org/r/64f01d5e381b8631a271616b7790f9d5640974fb.1588944082.git.matti.vaittinen@fi.rohmeurope.com
Signed-off-by: Mark Brown

Matti Vaittinen
2020-05-09 01:18:13 +0800

06 May, 2019

1 commit

e2a23affe Merge branch 'regulator-5.2' into regulator-next Browse Code »

Mark Brown
2019-05-06 21:52:14 +0800

26 Mar, 2019

1 commit

0b5e200cc regulator: tps65217: Fix off-by-one for latest seletor of tps65217_uv1_ranges ... Browse Code »

According to the datasheet the latest seletor 11 1111b = 3.3 V.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2019-03-26 21:57:32 +0800

25 Mar, 2019

1 commit

2c33b50e6 regulator: tps65217: Constify regulator_ops ... Browse Code »

These regulator_ops variables never need to be modified, make them const so
compiler can put them to .rodata.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2019-03-25 20:21:29 +0800

21 Mar, 2019

1 commit

689b9e025 regulator: tps65217: Simplify linear range for selector 25-52 ... Browse Code »

The original code separates the selector 25-52 into 2 ranges on purpose
because DCDC1/DCDC3 only support up to 1.8V/1.5V in the old code.
Both DCDC1 and DCDC3 support up to 3.3V since commit b4c2e158a1e1
("regulator: tps65217: Allow DCDC1 and DCDC3 up to 3.3V"), so merge
25-30 and 31-52 ranges to one range.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2019-03-21 22:59:24 +0800

30 Jul, 2018

1 commit

4f919ca2b regulator: tps65217: Fix NULL pointer dereference on probe ... Browse Code »

There is no check that tps->strobes is allocated successfully in
tps65217_regulator_probe().
The patch adds corresponding check.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev
Signed-off-by: Mark Brown

Anton Vasilyev
2018-07-30 16:41:04 +0800

13 Jun, 2018

1 commit

a86854d0c treewide: devm_kzalloc() -> devm_kcalloc() ... Browse Code »

The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:

devm_kzalloc(handle, a * b, gfp)

with:
devm_kcalloc(handle, a * b, gfp)

as well as handling cases of:

devm_kzalloc(handle, a * b * c, gfp)

with:

devm_kzalloc(handle, array3_size(a, b, c), gfp)

as it's slightly less ugly than:

devm_kcalloc(handle, array_size(a, b), c, gfp)

This does, however, attempt to ignore constant size factors like:

devm_kzalloc(handle, 4 * 1024, gfp)

though any constants defined via macros get caught up in the conversion.

Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.

Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".

The Coccinelle script used for this was:

// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@

(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)

// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@

(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)

// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@

(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)

// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@

- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)

// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@

(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)

// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@

(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)

// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@

(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)

// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@

(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)

// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@

(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)

Signed-off-by: Kees Cook

Kees Cook
2018-06-13 07:19:22 +0800

13 Oct, 2017

1 commit

511cb1744 mfd: tps65217: Introduce dependency on CONFIG_OF ... Browse Code »

Currently the driver boots only via device tree hence add a
dependency on CONFIG_OF. This leaves with a bunch of unused code
so clean that up. This patch also makes use of probe_new function
in place of the probe function so as to avoid passing i2c_device_id.

Signed-off-by: Keerthy
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Lee Jones

Keerthy
2017-10-13 17:42:58 +0800

24 Jan, 2017

1 commit

b4c2e158a regulator: tps65217: Allow DCDC1 and DCDC3 up to 3.3V ... Browse Code »

The data sheet statement that DCDC1 and DCDC3 only can be set in the range
0.9V - 1.5V refers to storage on its internal EEPROM and therefore cold boot
configuration. After power-on the device can be reconfigured over i2c and
DCDC1/3 set up to 3.3V.

Signed-off-by: Måns Andersson
Signed-off-by: Mark Brown

Måns Andersson
2017-01-24 01:48:55 +0800

28 Jun, 2016

1 commit

3de560995 regulator: tps65217: Enable suspend configuration ... Browse Code »

The TPS65217 has a pre-defined power-up / power-down sequence which in
a typical application does not need to be changed. However, it is possible
to define custom sequences under I2C control. The power-up sequence is
defined by strobes and delay times. Each output rail is assigned to a
strobe to determine the order in which the rails are enabled.

Every regulator of tps65217 PMIC has sequence registers and every
regulator has a default strobe value and gets disabled when a particular
power down sequence occurs.

To keep a regulator on during suspend we write value 0 to strobe so
that the regulator is out of all sequencers and is not impacted by any
power down sequence. Hence saving the default strobe value during probe
so that when we want to regulator to be enabled during suspend we write 0
to strobe and when we want it to get disabled during suspend we write
the default saved strobe value.

This allows platform data to specify which power rails should be on or off
during RTC only suspend. This is necessary to keep DDR state while in RTC
only suspend.

Signed-off-by: Russ Dill
[Enhanced commit log and added dynamic allocation for strobes]
Signed-off-by: Keerthy
Signed-off-by: Mark Brown

Russ Dill
2016-06-28 00:56:43 +0800

10 Sep, 2014

2 commits

7d42a7f29 regulator: tps65217: Use simplified DT parsing ... Browse Code »

Remove a bunch of code in favour of data.

Signed-off-by: Mark Brown

Mark Brown
2014-09-10 19:02:48 +0800
c2542d2a8 regulator: tps65217: Remove unused driver_data from of_match table ... Browse Code »

We don't ever reference the driver_data we supply so remove it.

Signed-off-by: Mark Brown

Mark Brown
2014-09-10 06:22:19 +0800

06 Sep, 2014

1 commit

81baf9fe0 regulator: tps65217: Remove spurious platform data check ... Browse Code »

We should always be able to probe a regulator with no platform data. This
will enable readback of current state, though no changes can be made to
the device configuration.

Signed-off-by: Mark Brown

Mark Brown
2014-09-06 19:43:40 +0800

24 Jun, 2014

1 commit

6bdaaf0e5 regulator: tps65217: Fix build warnings ... Browse Code »

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:

drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat
Signed-off-by: Mark Brown

Sachin Kamat
2014-06-24 23:23:00 +0800

19 Apr, 2014

1 commit

5957ae1fd regulator: tps65217: Use regulator_map_voltage_ascend for LDO1 ... Browse Code »

The voltages in LDO1_VSEL_table are in ascendant order, so use
regulator_map_voltage_ascend.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2014-04-19 00:21:00 +0800

18 Apr, 2014

1 commit

073a77d03 regulator: tps65217: Remove *rdev[] from struct tps65217 ... Browse Code »

Now this driver uses devm_regulator_register() so we don't need to save rdev
pointer to tps->rdev[i] for cleanup.

Signed-off-by: Axel Lin
Acked-by: Lee Jones
Signed-off-by: Mark Brown

Axel Lin
2014-04-18 22:47:39 +0800

03 Mar, 2014

1 commit

94ee607c9 regulator: tps65217: Allow missing init_data for diagnostics ... Browse Code »

The regulator core supports this to allow the configuration to be inspected
at runtime even if no software management is enabled.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2014-03-03 12:00:39 +0800

15 Feb, 2014

1 commit

93195c33e regulator: tps65217: Use of_get_child_by_name ... Browse Code »

of_find_node_by_name walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name instead.

Signed-off-by: Sachin Kamat
Signed-off-by: Mark Brown

Sachin Kamat
2014-02-15 05:21:54 +0800

24 Oct, 2013

1 commit

4c35c8676 Merge remote-tracking branch 'regulator/topic/linear' into regulator-next Browse Code »

Mark Brown
2013-10-24 18:11:37 +0800

11 Oct, 2013

2 commits

8828bae46 regulator: Add REGULATOR_LINEAR_RANGE macro ... Browse Code »

Add REGULATOR_LINEAR_RANGE macro and convert regulator drivers to use it.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2013-10-11 19:49:16 +0800
e277e6568 regulator: Remove max_uV from struct regulator_linear_range ... Browse Code »

linear ranges means each range has linear voltage settings.
So we can calculate max_uV for each linear range in regulator core rather than
set the max_uV field in drivers.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2013-10-11 19:49:12 +0800

17 Sep, 2013

1 commit

4aac198dd regulator: tps65217: Use devm_regulator_register ... Browse Code »

devm_* simplifies the code.

Signed-off-by: Sachin Kamat
Signed-off-by: Mark Brown

Sachin Kamat
2013-09-17 07:28:43 +0800

30 Aug, 2013

1 commit

6290d6065 regulator: tps65217: Convert to use linear ranges ... Browse Code »

Below is the equation in original code:

tps65217_uv1_ranges:
0 ... 24: uV = vsel * 25000 + 900000;
25 ... 52: uV = (vsel - 24) * 50000 + 1500000;
= (vsel - 25) * 50000 + 1550000;
53 ... 55: uV = (vsel - 52) * 100000 + 2900000;
= (vsel - 53) * 100000 + 3000000;
56 ... 62: uV = 3300000;

tps65217_uv2_ranges:
0 ... 8: uV = vsel * 50000 + 1500000;
9 ... 13: uV = (vsel - 8) * 100000 + 1900000;
= (vsel - 9) * 100000 + 2000000;
14 ... 31: uV = (vsel - 13) * 50000 + 2400000;
= (vsel - 14) * 50000 + 2450000;

The voltage tables are composed of linear ranges.
This patch converts this driver to use multiple linear ranges APIs.

In original code, voltage range for DCDC1 is 900000 ~ 1800000 and voltage range
for DCDC3 is 900000 ~ 1500000. This patch separates the range 25~52 in
tps65217_uv1_ranges table to two linear ranges: 25~30 and 31~52.
This change makes it possible to reuse the same linear_ranges table for DCDCx.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2013-08-30 22:26:03 +0800

12 May, 2013

1 commit

405c54009 regulator: Remove all platform_set_drvdata(pdev, NULL) in drivers ... Browse Code »

Since 0998d06310 "device-core: Ensure drvdata = NULL when no driver is bound",
this is done by driver core after device_release or on probe failure.
Thus we can remove all platform_set_drvdata(pdev, NULL) in drivers.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2013-05-12 22:34:12 +0800

24 Jan, 2013

1 commit

5bce833c4 regulator: tps65217: Fix using wrong dev argument for calling of_regulator_match ... Browse Code »

The dev parameter is the device requestiong the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2013-01-24 18:58:33 +0800

20 Nov, 2012

3 commits

8dc995f56 regulator: remove use of __devexit ... Browse Code »

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton
Signed-off-by: Mark Brown

Bill Pemberton
2012-11-20 09:53:38 +0800
a5023574d regulator: remove use of __devinit ... Browse Code »

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton
Signed-off-by: Mark Brown

Bill Pemberton
2012-11-20 09:31:26 +0800
5eb9f2b96 regulator: remove use of __devexit_p ... Browse Code »

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton
Signed-off-by: Mark Brown

Bill Pemberton
2012-11-20 09:31:19 +0800

22 Aug, 2012

1 commit

1922b0f27 mfd: Move tps65217 regulator plat data handling to regulator ... Browse Code »

Regulator platform data handling was mistakenly added to MFD
driver. So we will see build errors if we compile MFD drivers
without CONFIG_REGULATOR. This patch moves regulator platform
data handling from TPS65217 MFD driver to regulator driver.

This makes MFD driver independent of REGULATOR framework so
build error is fixed if CONFIG_REGULATOR is not set.

drivers/built-in.o: In function `tps65217_probe':
tps65217.c:(.devinit.text+0x13e37): undefined reference
to `of_regulator_match'

This patch also fix allocation size of tps65217 platform data.
Current implementation allocates a struct tps65217_board for each
regulator specified in the device tree. But the structure itself
provides array of regulators so one instance of it is sufficient.

Signed-off-by: AnilKumar Ch

AnilKumar Ch
2012-08-22 16:55:25 +0800

13 Jul, 2012

1 commit

a7f1b63eb regulator: tps65217: Add device tree support ... Browse Code »

This commit adds device tree support for tps65217 pmic. And usage
details are added to device tree documentation. Driver is tested
by using kernel module with regulator set and get APIs.

Signed-off-by: AnilKumar Ch
Signed-off-by: Mark Brown

AnilKumar Ch
2012-07-13 01:27:36 +0800

04 Jul, 2012

1 commit

844e6901d regulator: tps65217: Fix voltage boundary checking in tps65217_pmic_map_voltage ... Browse Code »

It is ok to request voltage with min_uV < tps->info[rid]->min_uV and
max_uV > tps->info[rid]->max_uV.

The equation we used in uv_to_vsel() does not allow
min_uV < tps->info[rid]->min_uV, otherwise it returns negative selector.
So we need to set min_uV = tps->info[rid]->min_uV if
min_uV < tps->info[rid]->min_uV.

Signed-off-by: Axel Lin
Acked-by: AnilKumar Ch
Signed-off-by: Mark Brown

Axel Lin
2012-07-04 03:18:34 +0800

03 Jul, 2012

1 commit

1a5d39d06 regulator: tps65217: invalid if check ... Browse Code »

This permits the setting of bogus values because the invalidity check is
itself invalid.

Reported-by: dcb314@hotmail.com
Signed-off-by: Alan Cox
Signed-off-by: Mark Brown

Alan Cox
2012-07-03 01:26:04 +0800

02 Jul, 2012

1 commit

d172f319c regulator: tps65217: Convert LDO1 to use regulator_list_voltage_table ... Browse Code »

Convert tps65217_pmic_ldo1_ops to use regulator_list_voltage_table.

We have n_voltages and volt_table settings in regulator_desc,
so we don't need the table and table_len fields in struct tps_info.
Thus remove them from struct tps_info.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2012-07-02 02:12:58 +0800

14 Jun, 2012

1 commit

b4bc9ef62 regulator: tps65217: Convert to regulator_[is_enabled|get_voltage_sel]_regmap ... Browse Code »

This patch converts .is_enabled and .get_voltage_sel to
regulator_is_enabled_regmap and regulator_get_voltage_sel_regmap.

For .enable, .disable, and .set_voltage_sel, the write protect level is either
1 or 2. So we cannot use regulator_[enable|disable|set_voltage_sel]_regmap.

Now we store the enable reg/mask and vsel reg/mask in regulator_desc,
so we can remove enable_mask, set_vout_reg, and set_vout_mask from
struct tps_info.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2012-06-14 01:57:56 +0800

18 May, 2012

1 commit

8b22285fd regulator: tps65217: Convert to set_voltage_sel and map_voltage ... Browse Code »

Convert tps65217_pmic_ops to use set_voltage_sel and map_voltage.
After this convertion, we can also use tps65217_pmic_set_voltage_sel()
for set_voltage_sel callback of tps65217_pmic_ldo1_ops.
Thus this patch also removes tps65217_pmic_ldo1_set_voltage_sel() function.

Signed-off-by: Axel Lin
Signed-off-by: Mark Brown

Axel Lin
2012-05-18 15:38:32 +0800

09 Apr, 2012

1 commit

c172708d3 regulator: core: Use a struct to pass in regulator runtime configuration ... Browse Code »
129

Rather than adding new arguments to regulator_register() every time we
want to add a new bit of dynamic information at runtime change the function
to take these via a struct. By doing this we avoid needing to do further
changes like the recent addition of device tree support which required each
regulator driver to be updated to take an additional parameter.

The regulator_desc which should (mostly) be static data is still passed
separately as most drivers are able to configure this statically at build
time.

Signed-off-by: Mark Brown

Mark Brown
2012-04-09 19:37:09 +0800

06 Apr, 2012

1 commit

78637a3d8 regulator: tps65217: Constify regulator_desc ... Browse Code »

Signed-off-by: Axel Lin
Acked-by: AnilKumar Ch
Signed-off-by: Mark Brown

Axel Lin
2012-04-06 17:07:03 +0800