03 Sep, 2020

3 commits

  • When Software CM is running it should not send any NHI mailbox command
    during PM flows. Only force power bit needs to be set and cleared so
    change Tiger Lake (well and Ice Lake) nhi_ops to take this into account.

    Signed-off-by: Mika Westerberg

    Mika Westerberg
     
  • Currently the Ice Lake and Tiger Lake NHI (host controller) LC (link
    controller) mailbox command processing checks for the completion of
    command every 100 msecs. These controllers are found to complete this in
    the order of 1 ms or so. Since this delay is in suspend path, surplus
    delay is effectively affecting runtime PM suspend flows.

    Optimize this so that we do the wait for 1 ms after reading the mailbox
    register. This should make Ice Lake and Tiger Lake runtime suspend take
    less time to complete.

    Reported-by: Dana Alkattan
    Signed-off-by: Rajmohan Mani
    Signed-off-by: Mika Westerberg

    Rajmohan Mani
     
  • Currently the "Force Power" logic uses 10 retries, each with a delay of
    250 ms. Thunderbolt controllers in Ice Lake and Tiger Lake platforms are
    found to complete this in the order of 3 ms or so. Since this delay
    is in resume path, surplus delay is effectively affecting runtime PM
    resume flows.

    Decrease the granularity of the delay to 3 ms and increase the number of
    retries so we wait maximum of ~1 s which is the recommended timeout.
    This should make runtime resume a bit faster.

    Reported-by: Dana Alkattan
    Signed-off-by: Rajmohan Mani
    Signed-off-by: Mika Westerberg

    Rajmohan Mani
     

08 Oct, 2019

1 commit


26 Aug, 2019

1 commit

  • The Thunderbolt controller is integrated into the Ice Lake CPU itself
    and requires special flows to power it on and off using force power bit
    in NHI VSEC registers. Runtime PM (RTD3) and Sx flows also differ from
    the discrete solutions. Now the firmware notifies the driver whether
    RTD3 entry or exit are possible. The driver is responsible of sending
    Go2Sx command through link controller mailbox when system enters Sx
    states (suspend-to-mem/disk). Rest of the ICM firwmare flows follow
    Titan Ridge.

    Signed-off-by: Raanan Avargil
    Signed-off-by: Mika Westerberg
    Reviewed-by: Yehezkel Bernat
    Tested-by: Mario Limonciello

    Mika Westerberg