31 Jul, 2020
1 commit
-
The flag CRYPTO_ALG_INTERNAL is not meant to be used outside of
the Crypto API. It isn't needed here anyway.Signed-off-by: Herbert Xu
Signed-off-by: Johan Hedberg
07 Oct, 2017
4 commits
-
CC net/bluetooth/selftest.o
net/bluetooth/selftest.c: In function ‘bt_selftest_init’:
net/bluetooth/selftest.c:246:3: warning: ‘duration’ may be used uninitialized in this function [-Wmaybe-uninitialized]
snprintf(test_ecdh_buffer, sizeof(test_ecdh_buffer),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"PASS (%llu usecs)\n", duration);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/bluetooth/selftest.c:203:21: note: ‘duration’ was declared here
unsigned long long duration;
^~~~~~~~Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg -
That Bluetooth SMP knows about the private key is pointless, since the
detection of debug key usage is actually via the public key portion.
With this patch, the Bluetooth SMP will stop keeping a copy of the
ecdh private key and will let the crypto subsystem to generate and
handle the ecdh private key, potentially benefiting of hardware
ecc private key generation and retention.The loop that tries to generate a correct private key is now removed and
we trust the crypto subsystem to generate a correct private key. This
backup logic should be done in crypto, if really needed.Signed-off-by: Tudor Ambarus
Signed-off-by: Marcel Holtmann -
Signed-off-by: Tudor Ambarus
Signed-off-by: Marcel Holtmann -
Before this change, a new crypto tfm was allocated, each time,
for both key generation and shared secret computation.Allocate a single tfm for both cases.
Signed-off-by: Tudor Ambarus
Signed-off-by: Marcel Holtmann
12 Aug, 2017
1 commit
-
While the kfree of dhkey_a is of the same address of tmp, it
probably is clearer and more human readable if tmp is kfree'd
rather than dhkey_a.Detected by CoverityScan, CID#1448650 ("Free of address-of expression")
Signed-off-by: Colin Ian King
Signed-off-by: Marcel Holtmann
30 Apr, 2017
1 commit
-
Bluetooth would crash when computing ECDH keys with kpp
if VMAP_STACK is enabled. Fix by allocating data passed
to kpp on heap.Fixes: 58771c1c ("Bluetooth: convert smp and selftest to crypto kpp
API")
Signed-off-by: Salvatore Benedetto
Signed-off-by: Marcel Holtmann
25 Apr, 2017
1 commit
-
* Convert both smp and selftest to crypto kpp API
* Remove module ecc as no more required
* Add ecdh_helper functions for wrapping kpp async callsThis patch has been tested *only* with selftest, which is called on
module loading.Signed-off-by: Salvatore Benedetto
Signed-off-by: Marcel Holtmann
02 Apr, 2015
1 commit
-
When ECDH selftest is enabled, then besides printing the result into the
kernel message buffer, also create a debugfs file that allows retrieving
the same information.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
14 Jan, 2015
1 commit
-
The duration variable for the selftests is unsigned long long and with
that use %llu instead of %lld when printing the results.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
30 Dec, 2014
4 commits
-
After successful completion of the ECDH test cases, print the time it
took to run them.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg -
This patch adds the initial skeleton and kernel config option for SMP
self-tests.Signed-off-by: Johan Hedberg
Signed-off-by: Marcel Holtmann -
This patch adds the test cases for ECDH cryptographic functionality
used by Bluetooth Low Energy Secure Connections feature.Signed-off-by: Johan Hedberg
Signed-off-by: Marcel Holtmann -
This add support for the Bluetooth self testing framework that allows
running certain test cases of sample data to ensure correctness of its
basic functionality.With this patch only the basic framework will be added. It contains
the build magic that allows running this at module loading time or
at late_initcall stage when built into the kernel image.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
