Eric Lee / smarc-fsl-linux-kernel

22 Jul, 2020

1 commit

  • 954d82979   netfilter: Use fallthrough pseudo-keyword ... Browse Code »

    Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
    fall-through markings when it is the case.

    [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Pablo Neira Ayuso

    Gustavo A. R. Silva
     

16 Jul, 2019

1 commit

  • 05ba4c895   netfilter: Update obsolete comments referring to ip_conntrack ... Browse Code »

    In 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.") the new
    generic nf_conntrack was introduced, and it came to supersede the old
    ip_conntrack.

    This change updates (some) of the obsolete comments referring to old
    file/function names of the ip_conntrack mechanism, as well as removes a
    few self-referencing comments that we shouldn't maintain anymore.

    I did not update any comments referring to historical actions (e.g,
    comments like "this file was derived from ..." were left untouched, even
    if the referenced file is no longer here).

    Signed-off-by: Yonatan Goldschmidt
    Signed-off-by: Pablo Neira Ayuso

    Yonatan Goldschmidt
     

19 Jun, 2019

1 commit

  • 40b0b3f8f   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230 ... Browse Code »

    Based on 2 normalized pattern(s):

    this source code is licensed under the gnu general public license
    version 2 see the file copying for more details

    this source code is licensed under general public license version 2
    see

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 52 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Enrico Weigelt
    Reviewed-by: Allison Randal
    Reviewed-by: Alexios Zavras
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190602204653.449021192@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

06 May, 2019

1 commit

  • f5e85ce8e   netfilter: nf_conntrack_h323: restore boundary check correctness ... Browse Code »

    Since commit bc7d811ace4a ("netfilter: nf_ct_h323: Convert
    CHECK_BOUND macro to function"), NAT traversal for H.323
    doesn't work, failing to parse H323-UserInformation.
    nf_h323_error_boundary() compares contents of the bitstring,
    not the addresses, preventing valid H.323 packets from being
    conntrack'd.

    This looks like an oversight from when CHECK_BOUND macro was
    converted to a function.

    To fix it, stop dereferencing bs->cur and bs->end.

    Fixes: bc7d811ace4a ("netfilter: nf_ct_h323: Convert CHECK_BOUND macro to function")
    Signed-off-by: Jakub Jankowski
    Signed-off-by: Pablo Neira Ayuso

    Jakub Jankowski
     

09 Jan, 2018

2 commits

20 Nov, 2017

2 commits

25 Oct, 2017

2 commits

  • e8daf27c2   netfilter: nf_ct_h323: Out Of Bound Read in Netfilter Conntrack ... Browse Code »

    Add missing counter decrement to prevent out of bounds memory read.

    Signed-off-by: Eric Sesterhenn
    Acked-by: Florian Westphal
    Signed-off-by: Pablo Neira Ayuso

    Eric Sesterhenn
     
  • 67704c2a0   netfilter: nf_conntrack_h323: Remove typedef struct ... Browse Code »

    Remove typedef from struct as linux-kernel coding style tends to
    avoid using typedefs.
    Done using following coccinelle semantic patch

    @r1@
    type T;
    @@

    typedef struct { ... } T;

    @script:python c1@
    T2;
    T << r1.T;
    @@
    if T[-2:] =="_t" or T[-2:] == "_T":
    coccinelle.T2 = T[:-2];
    else:
    coccinelle.T2 = T;

    print T, coccinelle.T2

    @r2@
    type r1.T;
    identifier c1.T2;
    @@
    -typedef
    struct
    + T2
    { ... }
    -T
    ;

    @r3@
    type r1.T;
    identifier c1.T2;
    @@
    -T
    +struct T2

    Signed-off-by: Harsha Sharma
    Signed-off-by: Pablo Neira Ayuso

    Harsha Sharma
     

11 Jul, 2016

1 commit

04 Apr, 2011

1 commit

  • b4232a227   netfilter: h323: bug in parsing of ASN1 SEQOF field ... Browse Code »

    Static analyzer of clang found a dead store which appears to be a bug in
    reading count of items in SEQOF field, only the lower byte of word is
    stored. This may lead to corrupted read and communication shutdown.

    The bug has been in the module since it's first inclusion into linux
    kernel.

    [Patrick: the bug is real, but without practical consequence since the
    largest amount of sequence-of members we parse is 30.]

    Signed-off-by: David Sterba
    Signed-off-by: Patrick McHardy

    David Sterba
     

01 Feb, 2008

3 commits

29 Jan, 2008

1 commit

11 Jul, 2007

1 commit

06 Jul, 2007

1 commit

03 Dec, 2006

1 commit