Eric Lee / smarc-fsl-linux-kernel

22 Jun, 2020

1 commit

  • cf6e26c71   ASoC: soc-component: merge snd_soc_component_read() and snd_soc_component_read32() ... Browse Code »

    We had read/write function for Codec, Platform, etc,
    but these has been merged into snd_soc_component_read/write().

    Internally, it is using regmap or driver function.
    In read case, each styles are like below

    regmap
    ret = regmap_read(..., reg, &val);

    driver function
    val = xxx->read(..., reg);

    Because of this kind of different style, to keep same read style,
    when we merged each read function into snd_soc_component_read(),
    we created snd_soc_component_read32(), like below.
    commit 738b49efe6c6 ("ASoC: add snd_soc_component_read32")

    (1) val = snd_soc_component_read32(component, reg);

    (2) ret = snd_soc_component_read(component, reg, &val);

    Many drivers are using snd_soc_component_read32(), and
    some drivers are using snd_soc_component_read() today.

    In generally, we don't check read function successes,
    because, we will have many other issues at initial timing
    if read function didn't work.

    Now we can use soc_component_err() when error case.
    This means, it is easy to notice if error occurred.

    This patch aggressively merge snd_soc_component_read() and _read32(),
    and makes snd_soc_component_read/write() as generally style.

    This patch do
    1) merge snd_soc_component_read() and snd_soc_component_read32()
    2) it uses soc_component_err() when error case (easy to notice)
    3) keeps read32 for now by #define
    4) update snd_soc_component_read() for all drivers

    Because _read() user drivers are not too many, this patch changes
    all user drivers.

    Signed-off-by: Kuninori Morimoto
    Reviewed-by: Kai Vehmanen
    Link: https://lore.kernel.org/r/87sgev4mfl.wl-kuninori.morimoto.gx@renesas.com
    Signed-off-by: Mark Brown

    Kuninori Morimoto
     

24 Feb, 2020

1 commit

  • 1640c8df0   ASoC: meson: aiu: fix semicolon.cocci warnings ... Browse Code »

    sound/soc/meson/aiu-encoder-i2s.c:129:2-3: Unneeded semicolon

    Remove unneeded semicolon.

    Generated by: scripts/coccinelle/misc/semicolon.cocci

    Fixes: 3e25c44598aa ("ASoC: meson: aiu: add support for the Meson8 and Meson8b SoC families")
    Signed-off-by: kbuild test robot
    CC: Martin Blumenstingl
    Link: https://lore.kernel.org/r/20200222170154.GA119396@e50d7db646c3
    Signed-off-by: Mark Brown

    kbuild test robot
     

21 Feb, 2020

1 commit

  • 3e25c4459   ASoC: meson: aiu: add support for the Meson8 and Meson8b SoC families ... Browse Code »

    The AIU audio controller on the Meson8 and Meson8b SoC families is
    compatible with the one found in the later GXBB family. Add compatible
    strings for these two older SoC families so the driver can be loaded for
    them.

    Instead of using the I2S divider from the AIU_CLK_CTRL_MORE register we
    need to use the I2S divider from the AIU_CLK_CTRL register. This older
    register is less flexible because it only supports four divider settings
    (1, 2, 4, 8) compared to the AIU_CLK_CTRL_MORE register (which supports
    dividers in the range 0..64).

    Signed-off-by: Martin Blumenstingl
    Reviewed-by: Jerome Brunet
    Link: https://lore.kernel.org/r/20200220205711.77953-4-martin.blumenstingl@googlemail.com
    Signed-off-by: Mark Brown

    Martin Blumenstingl
     

15 Feb, 2020

1 commit

  • 51c366e38   ASoC: meson: aiu: remove unused encoder structure ... Browse Code »

    Remove an unused structure definition which slipped through the initial
    driver submission.

    Fixes: 6ae9ca9ce986 ("ASoC: meson: aiu: add i2s and spdif support")
    Signed-off-by: Jerome Brunet
    Link: https://lore.kernel.org/r/20200214131350.337968-2-jbrunet@baylibre.com
    Signed-off-by: Mark Brown

    Jerome Brunet
     

14 Feb, 2020

1 commit