08 Sep, 2011
2 commits
-
In the process the batman iv OGM aggregation code could be merged
into the batman iv code base which makes the separate aggregation
files superfluous.Signed-off-by: Marek Lindner
-
The follow-up routing code changes are going to introduce additional
routing packet types which make this distinction necessary.Signed-off-by: Marek Lindner
22 Aug, 2011
1 commit
-
Several typos have been corrected and some sentences have been rephrased
Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
08 Jul, 2011
1 commit
-
To keep transtable consistency among all the nodes, an originator must
not send not yet announced clients within a full table TT_RESPONSE.
Instead, deleted client have to be kept in the table in order to be sent
within an immediate TT_RESPONSE. In this way all the nodes in the
network will always provide the same response for the same request.All the modification are committed at the next ttvn increment event.
Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
05 Jul, 2011
2 commits
-
The primary interface OGM has to be broadcasted on all hard-interfaces
even if the primary interface is not the first interface (if_num = 0).
Therefore the code has to compare the originating interface with the
primary interface instead of checking the if_num.Reported-by: Linus Luessing
Signed-off-by: Marek Lindner -
In order to make possible to use the broadcast list for delayed sendings
the "delay" parameter is now provided instead of using 1 as hardcoded
value.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
20 Jun, 2011
3 commits
-
With the current client announcement implementation, in case of roaming,
an update is triggered on the new AP serving the client. At that point
the new information is spread around by means of the OGM broadcasting
mechanism. Until this operations is not executed, no node is able to
correctly route traffic towards the client. This obviously causes packet
drops and introduces a delay in the time needed by the client to recover
its connections.A new packet type called ROAMING_ADVERTISEMENT is added to account this
issue.This message is sent in case of roaming from the new AP serving the
client to the old one and will contain the client MAC address. In this
way an out-of-OGM update is immediately committed, so that the old node
can update its global translation table. Traffic reaching this node will
then be redirected to the correct destination utilising the fresher
information. Thus reducing the packet drops and the connection recovery
delay.Signed-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann -
The client announcement mechanism informs every mesh node in the network
of any connected non-mesh client, in order to find the path towards that
client from any given point in the mesh.The old implementation was based on the simple idea of appending a data
buffer to each OGM containing all the client MAC addresses the node is
serving. All other nodes can populate their global translation tables
(table which links client MAC addresses to node addresses) using this
MAC address buffer and linking it to the node's address contained in the
OGM. A node that wants to contact a client has to lookup the node the
client is connected to and its address in the global translation table.It is easy to understand that this implementation suffers from several
issues:
- big overhead (each and every OGM contains the entire list of
connected clients)
- high latencies for client route updates due to long OGM trip time and
OGM lossesThe new implementation addresses these issues by appending client
changes (new client joined or a client left) to the OGM instead of
filling it with all the client addresses each time. In this way nodes
can modify their global tables by means of "updates", thus reducing the
overhead within the OGMs.To keep the entire network in sync each node maintains a translation
table version number (ttvn) and a translation table checksum. These
values are spread with the OGM to allow all the network participants to
determine whether or not they need to update their translation table
information.When a translation table lookup is performed in order to send a packet
to a client attached to another node, the destination's ttvn is added to
the payload packet. Forwarding nodes can compare the packet's ttvn with
their destination's ttvn (this node could have a fresher information
than the source) and re-route the packet if necessary. This greatly
reduces the packet loss of clients roaming from one AP to the next.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
char was used in different places to store information without really
using the characteristics of that data type or by ignoring the fact that
char has not a well defined signedness.Signed-off-by: Sven Eckelmann
10 Jun, 2011
1 commit
-
The definition NO_FLAGS was introduced to make the code more
readable and shall be used to initialize flag fields.Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann
30 May, 2011
2 commits
-
Documentation/CodingStyle recommends to use the form
p = kmalloc(sizeof(*p), ...);
to calculate the size of a struct and not the version where the struct
name is spelled out to prevent bugs when the type of p changes. This
also seems appropriate for manipulation of buffers when they are
directly associated with p.Signed-off-by: Sven Eckelmann
-
batman-adv uses pointers which are marked as const and should not
violate that type qualifier by passing it to functions which force a
cast to the non-const version.Signed-off-by: Sven Eckelmann
15 May, 2011
2 commits
-
The broadcast flood protection should be reset to its original value
if the primary interface could not be retrieved.Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
add_bcast_packet_to_list increases the refcount for if_incoming but the
reference count is never decreased. The reference count must be
increased for all kinds of forwarded packets which have the primary
interface stored and forw_packet_free must decrease them. Also
purge_outstanding_packets has to invoke forw_packet_free when a work
item was really cancelled.This regression was introduced in
32ae9b221e788413ce68feaae2ca39e406211a0a.Reported-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann
08 May, 2011
1 commit
-
To be coherent, all the functions/variables/constants have been renamed
to the TranslationTable styleSigned-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann
02 May, 2011
2 commits
-
The rcu protected macros rcu_dereference() and rcu_assign_pointer()
for the bat_priv->primary_if need to be used, as well as spin/rcu locking.Otherwise we might end up using a primary_if pointer pointing to already
freed memory.Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
atomic_dec_not_zero() is very useful and it is currently defined
multiple times. So it is possible to move it in main.hSigned-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann
18 Apr, 2011
1 commit
-
The rcu protected macros rcu_dereference() and rcu_assign_pointer()
for the orig_node->router need to be used, as well as spin/rcu locking.
Otherwise we might end up using a router pointer pointing to already
freed memory.Therefore this commit introduces the safe getter method
orig_node_get_router().Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann
05 Mar, 2011
3 commits
-
Signed-off-by: Marek Lindner
-
Batman-adv works with "hard interfaces" as well as "soft interfaces".
The new name should better make clear which kind of interfaces this
list stores.Signed-off-by: Marek Lindner
-
Note: The function compare_ether_addr() provided by the Linux kernel
requires aligned memory.Signed-off-by: Marek Lindner
12 Feb, 2011
1 commit
-
types.h is included by main.h, which is included at the beginning of any
other c-file anyway. Therefore this commit removes those duplicate
inclussions.Signed-off-by: Linus Lüssing
Signed-off-by: Sven Eckelmann
31 Jan, 2011
2 commits
-
Signed-off-by: Sven Eckelmann
-
Some function parameters are obsolete now and can be removed.
Reported-by: Sven Eckelmann
Signed-off-by: Simon Wunderlich
Signed-off-by: Sven Eckelmann
17 Dec, 2010
1 commit
-
B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is a routing
protocol for multi-hop ad-hoc mesh networks. The networks may be wired or
wireless. See http://www.open-mesh.org/ for more information and user space
tools.Signed-off-by: Sven Eckelmann
Signed-off-by: David S. Miller