Eric Lee / smarc-fsl-linux-kernel

04 Dec, 2011

1 commit

  • 75f2811c6   ipv6: Add fragment reporting to ipv6_skip_exthdr(). ... Browse Code »

    While parsing through IPv6 extension headers, fragment headers are
    skipped making them invisible to the caller. This reports the
    fragment offset of the last header in order to make it possible to
    determine whether the packet is fragmented and, if so whether it is
    a first or last fragment.

    Signed-off-by: Jesse Gross

    Jesse Gross
     

23 Nov, 2011

1 commit

14 Oct, 2011

1 commit

  • 87fb4b7b5   net: more accurate skb truesize ... Browse Code »

    skb truesize currently accounts for sk_buff struct and part of skb head.
    kmalloc() roundings are also ignored.

    Considering that skb_shared_info is larger than sk_buff, its time to
    take it into account for better memory accounting.

    This patch introduces SKB_TRUESIZE(X) macro to centralize various
    assumptions into a single place.

    At skb alloc phase, we put skb_shared_info struct at the exact end of
    skb head, to allow a better use of memory (lowering number of
    reallocations), since kmalloc() gives us power-of-two memory blocks.

    Unless SLUB/SLUB debug is active, both skb->head and skb_shared_info are
    aligned to cache lines, as before.

    Note: This patch might trigger performance regressions because of
    misconfigured protocol stacks, hitting per socket or global memory
    limits that were previously not reached. But its a necessary step for a
    more accurate memory accounting.

    Signed-off-by: Eric Dumazet
    CC: Andi Kleen
    CC: Ben Hutchings
    Signed-off-by: David S. Miller

    Eric Dumazet
     

01 Aug, 2011

1 commit

23 Apr, 2011

1 commit

13 Mar, 2011

4 commits

03 Mar, 2011

1 commit

02 Mar, 2011

1 commit

  • b42835dbe   ipv6: Make icmp route lookup code a bit clearer. ... Browse Code »

    The route lookup code in icmpv6_send() is slightly tricky as a result of
    having to handle all of the requirements of RFC 4301 host relookups.

    Pull the route resolution into a seperate function, so that the error
    handling and route reference counting is hopefully easier to see and
    contained wholly within this new routine.

    Signed-off-by: David S. Miller

    David S. Miller
     

05 Feb, 2011

1 commit

10 Jun, 2010

1 commit

  • 00d9d6a18   ipv6: fix ICMP6_MIB_OUTERRORS ... Browse Code »

    In commit 1f8438a85366 (icmp: Account for ICMP out errors), I did a typo
    on IPV6 side, using ICMP6_MIB_OUTMSGS instead of ICMP6_MIB_OUTERRORS

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

24 Apr, 2010

1 commit

12 Apr, 2010

1 commit

04 Apr, 2010

1 commit

  • 1f8438a85   icmp: Account for ICMP out errors ... Browse Code »

    When ip_append() fails because of socket limit or memory shortage,
    increment ICMP_MIB_OUTERRORS counter, so that "netstat -s" can report
    these errors.

    LANG=C netstat -s | grep "ICMP messages failed"
    0 ICMP messages failed

    For IPV6, implement ICMP6_MIB_OUTERRORS counter as well.

    # grep Icmp6OutErrors /proc/net/dev_snmp6/*
    /proc/net/dev_snmp6/eth0:Icmp6OutErrors 0
    /proc/net/dev_snmp6/lo:Icmp6OutErrors 0

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

19 Feb, 2010

2 commits

18 Jan, 2010

1 commit

12 Nov, 2009

1 commit

  • f8572d8f2   sysctl net: Remove unused binary sysctl code ... Browse Code »

    Now that sys_sysctl is a compatiblity wrapper around /proc/sys
    all sysctl strategy routines, and all ctl_name and strategy
    entries in the sysctl tables are unused, and can be
    revmoed.

    In addition neigh_sysctl_register has been modified to no longer
    take a strategy argument and it's callers have been modified not
    to pass one.

    Cc: "David Miller"
    Cc: Hideaki YOSHIFUJI
    Cc: netdev@vger.kernel.org
    Signed-off-by: Eric W. Biederman

    Eric W. Biederman
     

15 Sep, 2009

1 commit

14 Aug, 2009

1 commit

  • e651f03af   inet6: Conversion from u8 to int ... Browse Code »

    This replaces assignments of the type "int on LHS" = "u8 on RHS" with
    simpler code. The LHS can express all of the unsigned right hand side
    values, hence the assigned value can not be negative.

    Signed-off-by: Gerrit Renker
    Signed-off-by: David S. Miller

    Gerrit Renker
     

23 Jun, 2009

1 commit

28 Jan, 2009

1 commit

  • 6c06a478c   net: fix xfrm reverse flow lookup for icmp6 ... Browse Code »

    This patch fixes the xfrm reverse flow lookup for icmp6 so that icmp6 packets
    don't get lost over ipsec tunnels. Similar patch is in RHEL5 kernel for a quite
    long time and I do not see why it isn't in mainline.

    Signed-off-by: Jiri Pirko
    Acked-by: Herbert Xu
    Signed-off-by: David S. Miller

    Jiri Pirko
     

26 Nov, 2008

1 commit

  • 52479b623   netns xfrm: lookup in netns ... Browse Code »

    Pass netns to xfrm_lookup()/__xfrm_lookup(). For that pass netns
    to flow_cache_lookup() and resolver callback.

    Take it from socket or netdevice. Stub DECnet to init_net.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     

20 Nov, 2008

1 commit

04 Nov, 2008

1 commit

  • 6d9f239a1   net: '&' redux ... Browse Code »

    I want to compile out proc_* and sysctl_* handlers totally and
    stub them to NULL depending on config options, however usage of &
    will prevent this, since taking adress of NULL pointer will break
    compilation.

    So, drop & in front of every ->proc_handler and every ->strategy
    handler, it was never needed in fact.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     

30 Oct, 2008

1 commit

29 Oct, 2008

2 commits

09 Oct, 2008

3 commits

23 Aug, 2008

1 commit

  • fdc0bde90   icmp: icmp_sk() should not use smp_processor_id() in preemptible code ... Browse Code »

    Pass namespace into icmp_xmit_lock, obtain socket inside and return
    it as a result for caller.

    Thanks Alexey Dobryan for this report:

    Steps to reproduce:

    CONFIG_PREEMPT=y
    CONFIG_DEBUG_PREEMPT=y
    tracepath

    BUG: using smp_processor_id() in preemptible [00000000] code: tracepath/3205
    caller is icmp_sk+0x15/0x30
    Pid: 3205, comm: tracepath Not tainted 2.6.27-rc4 #1

    Call Trace:
    [] debug_smp_processor_id+0xe4/0xf0
    [] icmp_sk+0x15/0x30
    [] icmp_send+0x4b/0x3f0
    [] ? trace_hardirqs_on_caller+0xd5/0x160
    [] ? trace_hardirqs_on+0xd/0x10
    [] ? local_bh_enable_ip+0x95/0x110
    [] ? _spin_unlock_bh+0x39/0x40
    [] ? mark_held_locks+0x4c/0x90
    [] ? trace_hardirqs_on+0xd/0x10
    [] ? trace_hardirqs_on_caller+0xd5/0x160
    [] ip_fragment+0x8d4/0x900
    [] ? ip_finish_output2+0x0/0x290
    [] ? ip_finish_output+0x0/0x60
    [] ? dst_output+0x0/0x10
    [] ip_finish_output+0x4c/0x60
    [] ip_output+0xa3/0xf0
    [] ip_local_out+0x20/0x30
    [] ip_push_pending_frames+0x27f/0x400
    [] udp_push_pending_frames+0x233/0x3d0
    [] udp_sendmsg+0x321/0x6f0
    [] inet_sendmsg+0x45/0x80
    [] sock_sendmsg+0xdf/0x110
    [] ? autoremove_wake_function+0x0/0x40
    [] ? validate_chain+0x415/0x1010
    [] ? __do_fault+0x140/0x450
    [] ? __lock_acquire+0x260/0x590
    [] ? sockfd_lookup_light+0x45/0x80
    [] sys_sendto+0xea/0x120
    [] ? _spin_unlock_irqrestore+0x42/0x80
    [] ? __up_read+0x4c/0xb0
    [] ? up_read+0x26/0x30
    [] system_call_fastpath+0x16/0x1b

    icmp6_sk() is similar.

    Signed-off-by: Denis V. Lunev
    Signed-off-by: David S. Miller

    Denis V. Lunev
     

02 Jul, 2008

1 commit

  • 6dbf4bcac   icmp: fix units for ratelimit ... Browse Code »

    Convert the sysctl values for icmp ratelimit to use milliseconds instead
    of jiffies which is based on kernel configured HZ.
    Internal kernel jiffies are not a proper unit for any userspace API.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

12 Jun, 2008

1 commit

14 Apr, 2008

1 commit

04 Apr, 2008

2 commits

  • 1ed8516f0   [IPV6]: Simplify IPv6 control sockets creation. ... Browse Code »

    Do this by replacing sock_create_kern with inet_ctl_sock_create.

    Signed-off-by: Denis V. Lunev
    Acked-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Denis V. Lunev
     
  • af2681828   [ICMP]: Ensure that ICMP relookup maintains status quo ... Browse Code »

    The ICMP relookup path is only meant to modify behaviour when
    appropriate IPsec policies are in place and marked as requiring
    relookups. It is certainly not meant to modify behaviour when
    IPsec policies don't exist at all.

    However, due to an oversight on the error paths existing behaviour
    may in fact change should one of the relookup steps fail.

    This patch corrects this by redirecting all errors on relookup
    failures to the previous code path. That is, if the initial
    xfrm_lookup let the packet pass, we will stand by that decision
    should the relookup fail due to an error.

    This should be safe from a security point-of-view because compliant
    systems must install a default deny policy so the packet would'nt
    have passed in that case.

    Many thanks to Julian Anastasov for pointing out this error.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu