30 Oct, 2020

1 commit


29 Oct, 2020

1 commit

  • If enable DEBUG, will meet the following errors when build mpssd, so fix
    them here.
    Only one error is listed here, other errors are similar.

    mpssd.c: In function ‘virtio_net’:
    mpssd.c:615:21: error: incompatible type for argument 2 of ‘disp_iovec’
    disp_iovec(mic, copy, __func__, __LINE__);
    ^~~~
    mpssd.c:361:1: note: expected ‘struct mic_copy_desc *’ but argument is of type ‘struct mic_copy_desc’
    disp_iovec(struct mic_info *mic, struct mic_copy_desc *copy,
    ^~~~~~~~~~

    Signed-off-by: Sherry Sun
    Reviewed-by: Fugang Duan

    Sherry Sun
     

22 Sep, 2020

2 commits

  • Since imx-mic also need user space tool to boot vop, so use Intel's
    mpssd tool directly. Here need change makefile to make mpssd can be
    built on arm64 architecture.

    For arm64 architecture, use below command to build mpssd:
    make -C samples/mic/mpssd/ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-

    Signed-off-by: Sherry Sun
    Signed-off-by: Joakim Zhang
    Reviewed-by: Frank Li
    Reviewed-by: Fugang Duan

    Sherry Sun
     
  • Since struct _mic_vring_info and vring are allocated together and follow
    vring, if the vring_size() is not four bytes aligned, which will cause
    the start address of struct _mic_vring_info is not four byte aligned.
    For example, when vring entries is 128, the vring_size() will be 5126
    bytes. The _mic_vring_info struct layout in ddr looks like:
    0x90002400: 00000000 00390000 EE010000 0000C0FF
    Here 0x39 is avail_idx member, and 0xC0FFEE01 is magic member.

    When EP use ioread32(magic) to reads the magic in RC's share memory, it
    will cause kernel panic on ARM64 platform. Here read magic in user space
    use le32toh(vr0->info->magic) will meet the same issue.
    So here add round_up(x,4) for vring_size, then the struct _mic_vring_info
    will store in this way:
    0x90002400: 00000000 00000000 00000039 C0FFEE01
    Which will avoid kernel panic when read magic in struct _mic_vring_info.

    Signed-off-by: Sherry Sun
    Signed-off-by: Joakim Zhang
    Reviewed-by: Frank Li
    Reviewed-by: Fugang Duan

    Sherry Sun
     

05 Jun, 2019

1 commit

  • Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation this program is
    distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details the full gnu general public license is included in
    this distribution in the file called copying

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 39 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Alexios Zavras
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190529141901.397680977@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

08 Mar, 2019

1 commit


07 Nov, 2017

1 commit


02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

25 Oct, 2017

1 commit

  • For several reasons, it is desirable to use {READ,WRITE}_ONCE() in
    preference to ACCESS_ONCE(), and new code is expected to use one of the
    former. So far, there's been no reason to change most existing uses of
    ACCESS_ONCE(), as these aren't currently harmful.

    However, for some features it is necessary to instrument reads and
    writes separately, which is not possible with ACCESS_ONCE(). This
    distinction is critical to correct operation.

    The bulk of the kernel code can be transformed via Coccinelle to use
    {READ,WRITE}_ONCE(), though this only modifies users of ACCESS_ONCE(),
    and not the implementation itself. As such, it has the potential to
    break homebrew ACCESS_ONCE() macros seen in some user code in the kernel
    tree (e.g. the virtio code, as fixed in commit ea9156fb3b71d9f7).

    To avoid fragility if/when that transformation occurs, and to align with
    the preferred usage of {READ,WRITE}_ONCE(), this patch updates the MPSSD
    sample code to use READ_ONCE() rather than ACCESS_ONCE(). There should
    be no functional change as a result of this patch.

    Signed-off-by: Mark Rutland
    Signed-off-by: Paul E. McKenney
    Cc: Linus Torvalds
    Cc: Peter Zijlstra
    Cc: Shuah Khan
    Cc: Thomas Gleixner
    Cc: davem@davemloft.net
    Cc: linux-arch@vger.kernel.org
    Cc: mpe@ellerman.id.au
    Cc: snitzer@redhat.com
    Cc: thor.thayer@linux.intel.com
    Cc: tj@kernel.org
    Cc: viro@zeniv.linux.org.uk
    Cc: will.deacon@arm.com
    Link: http://lkml.kernel.org/r/1508792849-3115-10-git-send-email-paulmck@linux.vnet.ibm.com
    Signed-off-by: Ingo Molnar

    Mark Rutland
     

21 Sep, 2016

1 commit

  • Move mic/mpssd examples to samples and remove it from Documentation
    Makefile. Create a new Makefile to build mic/mpssd. It can be built
    from top level directory or from mic/mpssd directory:

    Run make -C samples/mic/mpssd or cd samples/mic/mpssd; make

    Acked-by: Jonathan Corbet
    Signed-off-by: Shuah Khan

    Shuah Khan