24 Feb, 2020

2 commits

  • [ Upstream commit f1dd4795b1523fbca7ab4344dd5a8bb439cc770d ]

    A long-standing compile warning was seen during build test:
    sound/sh/aica.c: In function 'load_aica_firmware':
    sound/sh/aica.c:521:25: warning: passing argument 2 of 'spu_memload' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

    Fixes: 198de43d758c ("[ALSA] Add ALSA support for the SEGA Dreamcast PCM device")
    Link: https://lore.kernel.org/r/20200105144823.29547-69-tiwai@suse.de
    Signed-off-by: Takashi Iwai
    Signed-off-by: Sasha Levin

    Takashi Iwai
     
  • [ Upstream commit 5da116f164ce265e397b8f59af5c39e4a61d61a5 ]

    Remove unused variables that are left over after the conversion of new
    PCM ops:
    sound/sh/sh_dac_audio.c:166:26: warning: unused variable 'runtime'
    sound/sh/sh_dac_audio.c:186:26: warning: unused variable 'runtime'
    sound/sh/sh_dac_audio.c:205:26: warning: unused variable 'runtime'

    Fixes: 1cc2f8ba0b3e ("ALSA: sh: Convert to the new PCM ops")
    Link: https://lore.kernel.org/r/20200104110057.13875-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai
    Signed-off-by: Sasha Levin

    Takashi Iwai
     

05 Jun, 2019

1 commit

  • Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of version 2 of the gnu general public license as
    published by the free software foundation this program is
    distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details you should have received a copy of the gnu general
    public license along with this program if not write to the free
    software foundation inc 59 temple place suite 330 boston ma 02111
    1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 24 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Richard Fontana
    Reviewed-by: Alexios Zavras
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190529141334.606756275@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

31 May, 2019

2 commits

  • Based on 1 normalized pattern(s):

    this code is licenced under the general public licence version 2

    and additional 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify it
    under the terms of version 2 of the gnu general public license as
    published by the free software foundation this program is distributed in
    the hope that it will be useful but without any warranty without even the
    implied warranty of merchantability or fitness for a particular purpose
    see the gnu general public license for more details you should have
    received a copy of the gnu general public license along with this
    program; if not write to the free software foundation inc 59 temple place
    suite 330 boston ma 02111-1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 1 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Steve Winslow
    Reviewed-by: Alexios Zavras
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190528170028.004542325@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     
  • Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version this program is distributed in the
    hope that it will be useful but without any warranty without even
    the implied warranty of merchantability or fitness for a particular
    purpose see the gnu general public license for more details you
    should have received a copy of the gnu general public license along
    with this program if not write to the free software foundation inc
    59 temple place suite 330 boston ma 02111 1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 1334 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

21 May, 2019

1 commit


08 May, 2019

1 commit

  • The build of aica sound driver has been broken since the timer API
    conversion and some code rewrite. This patch fixes the breakage by
    using the common substream field, as well as a bit cleaning up wrt the
    timer handling in the code.

    Fixes: d522bb6a105f ("ALSA: sh: aica: Convert timers to use timer_setup()")
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

06 Feb, 2019

1 commit


05 Oct, 2017

1 commit

  • In preparation for unconditionally passing the struct timer_list pointer to
    all timer callbacks, switch to using the new timer_setup() and from_timer()
    to pass the timer pointer explicitly. This requires adding a pointer to
    hold the timer's target substream, as there won't be a way to pass this in
    the future.

    Signed-off-by: Kees Cook
    Signed-off-by: Takashi Iwai

    Kees Cook
     

31 Aug, 2017

1 commit


19 Aug, 2017

1 commit


17 Aug, 2017

1 commit


03 Jun, 2017

1 commit


30 May, 2017

1 commit

  • Declare snd_kcontrol_new structures as const as they are only passed an
    argument to the function snd_ctl_new1. This argument is of type const,
    so snd_kcontrol_new structures having this property can be made const.
    Done using Coccinelle:

    @r disable optional_qualifier@
    identifier x;
    position p;
    @@
    static struct snd_kcontrol_new x@p={...};

    @ok@
    identifier r.x;
    position p;
    @@
    snd_ctl_new1(&x@p,...)

    @bad@
    position p != {r.p,ok.p};
    identifier r.x;
    @@
    x@p

    @depends on !bad disable optional_qualifier@
    identifier r.x;
    @@
    +const
    struct snd_kcontrol_new x;

    Cross compiled these files:
    sound/aoa/codecs/tas.c - powerpc
    sound/mips/{hal2.c/sgio2audio.c} - mips
    sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
    sound/soc/sh/siu_dai.c - sh
    Could not find an architecture to compile sound/sh/aica.c.

    Signed-off-by: Bhumika Goyal
    Acked-by: Mark Brown
    Signed-off-by: Takashi Iwai

    Bhumika Goyal
     

26 Dec, 2016

1 commit

  • ktime_set(S,N) was required for the timespec storage type and is still
    useful for situations where a Seconds and Nanoseconds part of a time value
    needs to be converted. For anything where the Seconds argument is 0, this
    is pointless and can be replaced with a simple assignment.

    Signed-off-by: Thomas Gleixner
    Cc: Peter Zijlstra

    Thomas Gleixner
     

07 Jun, 2016

1 commit

  • System workqueues have been able to handle high level of concurrency
    for a long time now and there's no reason to use dedicated workqueues
    just to gain concurrency. Since aica_queue for AICA sound
    driver has workitem dreamcastcard->spu_dma_work (maps to run_spu_dma)
    which is involved in aica dma transfers and is not being used on a memory
    reclaim path, dedicated aica_queue has been replaced with the
    use of system_wq.

    Unlike a dedicated per-cpu workqueue created with create_workqueue(),
    system_wq allows multiple work items to overlap executions even on
    the same CPU; however, a per-cpu workqueue doesn't have any CPU
    locality or global ordering guarantees unless the target CPU is
    explicitly specified and thus the increase of local concurrency
    shouldn't make any difference.

    Since the work items could be pending, flush_work() has been used in
    snd_aicapcm_pcm_close() to ensure that there is no pending task while
    disconnecting the driver.

    Signed-off-by: Bhaktipriya Shridhar
    Signed-off-by: Takashi Iwai

    Bhaktipriya Shridhar
     

28 Jan, 2015

1 commit


19 Jan, 2015

1 commit


20 Oct, 2014

1 commit


14 Feb, 2014

1 commit


23 May, 2013

2 commits


07 Dec, 2012

1 commit

  • CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Signed-off-by: Takashi Iwai

    Bill Pemberton
     

02 Jul, 2012

1 commit


21 May, 2012

1 commit

  • The module_platform_driver() conversion ended up tripping over the driver
    name, leading to confusion in the macro with regards to 'driver' being
    redefined. rename it to something slightly more suitable to avoid
    namespace collisions.

    sound/sh/sh_dac_audio.c:444:122: error: conflicting types for 'driver_init'
    include/linux/device.h:773:6: note: previous declaration of 'driver_init' was here
    make[3]: *** [sound/sh/sh_dac_audio.o] Error 1

    Signed-off-by: Paul Mundt
    Signed-off-by: Takashi Iwai

    Paul Mundt
     

19 Dec, 2011

1 commit

  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

28 Nov, 2011

1 commit


01 Nov, 2011

2 commits


27 Oct, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

01 Dec, 2009

1 commit


08 Nov, 2009

1 commit


04 Nov, 2009

1 commit

  • This is a port of the sound/oss/sh_dac_audio.c driver.
    The driver uses an on-chip 8-bit D/A converter, which has a speaker connected
    to one of its channels, found in several ancient HP machines.
    For interrupts it uses a high-resolution timer (hrtimer).
    Tested on SH7709 based hp6xx (HP Jornada 680/690 and HP Palmtop 620lx/660lx).

    Also, since OSS Emulation works, the old OSS sound/oss/sh_dac_audio.c driver
    would be obsolete soon, and it could be removed.

    Signed-off-by: Rafael Ignacio Zurita
    Acked-by: Paul Mundt
    Signed-off-by: Takashi Iwai

    Rafael Ignacio Zurita
     

30 Mar, 2009

1 commit


27 Mar, 2009

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6: (96 commits)
    sh: add support for SMSC Polaris platform
    sh: fix the HD64461 level-triggered interrupts handling
    sh: sh-rtc wakeup support
    sh: sh-rtc invalid time rework
    sh: sh-rtc carry interrupt rework
    sh: disallow kexec virtual entry
    sh: kexec jump: fix for ftrace.
    sh: kexec: Drop SR.BL bit toggling.
    sh: add kexec jump support
    sh: rework kexec segment code
    sh: simplify kexec vbr code
    sh: Flush only the needed range when unmapping a VMA.
    sh: Update debugfs ASID dumping for 16-bit ASID support.
    sh: tlb-pteaex: Kill off legacy PTEA updates.
    sh: Support for extended ASIDs on PTEAEX-capable SH-X3 cores.
    sh: sh7763rdp: Change IRQ number for sh_eth of sh7763rdp
    sh: espt-giga board support
    sh: dma: Make G2 DMA configurable.
    sh: dma: Make PVR2 DMA configurable.
    sh: Move IRQ multi definition of DMAC to defconfig
    ...

    Linus Torvalds
     

17 Mar, 2009

1 commit


12 Jan, 2009

1 commit


23 Sep, 2008

1 commit

  • Don't use __init but __devinit to define probe function. A pointer to
    snd_aica_probe is passed to the core via platform_driver_register and so the
    function must not disappear after the module is loaded. Using __init
    and having HOTPLUG=y and SND_AICA=m the following probably oopses:

    echo -n AICA > /sys/bus/platform/driver/AICA/unbind
    echo -n AICA > /sys/bus/platform/driver/AICA/bind

    Strange enough add_aicamixer_controls which is only called by
    snd_aica_probe was already using __devinit.

    While at it move the remove function to .devexit.text section.

    Signed-off-by: Uwe Kleine-König
    Cc: Adrian McMenamin
    Cc: Paul Mundt
    Cc: Jaroslav Kysela
    Cc: Andrew Morton
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Uwe Kleine-König
     

13 Aug, 2008

1 commit