Eric Lee / smarc-fsl-linux-kernel

16 Jun, 2009

3 commits

  • e4792aa30   debugfs: use specified mode to possibly mark files read/write only ... Browse Code »

    In many SoC implementations there are hardware registers can be read or
    write only. This extends the debugfs to enforce the file permissions for
    these types of registers by providing a set of fops which are read or
    write only. This assumes that the kernel developer knows more about the
    hardware than the user (even root users) -- which is normally true.

    Signed-off-by: Robin Getz
    Signed-off-by: Mike Frysinger
    Signed-off-by: Bryan Wu
    Signed-off-by: Greg Kroah-Hartman

    Robin Getz
     
  • 400ced61f   debugfs: fix docbook error ... Browse Code »

    Fix an error in debugfs_create_blob's docbook description

    It cannot actually be used to write a binary blob.

    Signed-off-by: Jonathan Corbet

    Jonathan Corbet
     
  • 56a83cc92   debugfs: dont stop on first failed recursive delete ... Browse Code »

    debugfs: dont stop on first failed recursive delete

    While running a while loop of removing a module that removes a debugfs
    directory with debugfs_remove_recursive, and at the same time doing a
    while loop of cat of a file in that directory, I would hit a point where
    somehow the cat of the file caused the remove to fail.

    The result is that other files did not get removed when the module
    was removed. I simple read of one of those file can oops the kernel
    because the operations to the file no longer exist (removed by module).

    The funny thing is that the file being cat'ed was removed. It was
    the siblings that were not. I see in the code to debugfs_remove_recursive
    there's a test that checks if the child fails to bail out of the loop
    to prevent an infinite loop.

    What this patch does is to still try any siblings in that directory.
    If all the siblings fail, or there are no more siblings, then we exit
    the loop.

    This fixes the above symptom, but...

    This is no full proof. It makes the debugfs_remove_recursive a bit more
    robust, but it does not explain why the one file failed. There may
    be some kind of delay deletion that makes the debugfs think it did
    not succeed. So this patch is more of a fix for the symptom but not
    the disease.

    This patch still makes the debugfs_remove_recursive more robust and
    until I can find out why the bug exists, this patch will keep
    the kernel from oopsing in most cases. Even after the cause is found
    I think this change can stand on its own and should be kept.

    [ Impact: prevent kernel oops on module unload and reading debugfs files ]

    Signed-off-by: Steven Rostedt
    Signed-off-by: Greg Kroah-Hartman

    Steven Rostedt
     

23 Mar, 2009

1 commit

  • c0f92ba99   debugfs: function to know if debugfs is initialized ... Browse Code »

    Impact: add new debugfs API

    With ftrace, some tracers are registered in early initcalls
    and attempt to create files on the debugfs filesystem.
    Depending on when they are activated, they can try to create their
    file at any time. Some checks can be done on the tracing area
    but providing a helper to know if debugfs is registered make it
    really more easy.

    Signed-off-by: Frederic Weisbecker
    Acked-by: Greg Kroah-Hartman
    Cc: Steven Rostedt
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Frederic Weisbecker
     

08 Jan, 2009

1 commit

  • 5e0787878   debugfs: add helpers for exporting a size_t simple value ... Browse Code »

    In the same spirit as debugfs_create_*(), introduce helpers for
    exporting size_t values over debugfs.

    The only trick done is that the format verifier is kept at %llu
    instead of %zu; otherwise type warnings would pop up:

    format ‘%zu’ expects type ‘size_t’, but argument 2 has type ‘long long unsigned int’

    There is no real way to fix this one--however, we can consider %llu
    and %zu to be compatible if we consider that we are using the same for
    validating in debugfs_create_{x,u}{8,16,32}().

    Signed-off-by: Inaky Perez-Gonzalez
    Signed-off-by: Greg Kroah-Hartman

    Inaky Perez-Gonzalez
     

06 Jan, 2009

1 commit

13 Oct, 2008

1 commit

  • 925629278   integrity: special fs magic ... Browse Code »

    Discussion on the mailing list questioned the use of these
    magic values in userspace, concluding these values are already
    exported to userspace via statfs and their correct/incorrect
    usage is left up to the userspace application.

    - Move special fs magic number definitions to magic.h
    - Add magic.h include

    Signed-off-by: Mimi Zohar
    Reviewed-by: James Morris
    Signed-off-by: James Morris

    Mimi Zohar
     

22 Jul, 2008

1 commit

  • 9505e6375   debugfs: Implement debugfs_remove_recursive() ... Browse Code »

    debugfs_remove_recursive() will remove a dentry and all its children.
    Drivers can use this to zap their whole debugfs tree so that they don't
    need to keep track of every single debugfs dentry they created.

    It may fail to remove the whole tree in certain cases:

    sh-3.2# rmmod atmel-mci < /sys/kernel/debug/mmc0/ios/clock
    mmc0: card b368 removed
    atmel_mci atmel_mci.0: Lost dma0chan1, falling back to PIO
    sh-3.2# ls /sys/kernel/debug/mmc0/
    ios

    But I'm not sure if that case can be handled in any sane manner.

    Signed-off-by: Haavard Skinnemoen
    Cc: Pierre Ossman
    Signed-off-by: Greg Kroah-Hartman

    Haavard Skinnemoen
     

01 May, 2008

1 commit

05 Mar, 2008

1 commit

  • 3634634ed   debugfs: fix sparse warnings ... Browse Code »

    extern does not belong in C files, move declaration to linux/debugfs.h
    fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static?
    fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

    Signed-off-by: Harvey Harrison
    Signed-off-by: Greg Kroah-Hartman

    Harvey Harrison
     

09 Feb, 2008

1 commit

  • 8b88b0998   libfs: allow error return from simple attributes ... Browse Code »

    Sometimes simple attributes might need to return an error, e.g. for
    acquiring a mutex interruptibly. In fact we have that situation in
    spufs already which is the original user of the simple attributes. This
    patch merged the temporarily forked attributes in spufs back into the
    main ones and allows to return errors.

    [akpm@linux-foundation.org: build fix]
    Signed-off-by: Christoph Hellwig
    Cc:
    Cc: Arnd Bergmann
    Cc: Greg KH
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

25 Jan, 2008

5 commits

21 Oct, 2007

1 commit

16 Oct, 2007

1 commit

  • e6716b87d   docbook: fix filesystems content ... Browse Code »

    Fix filesystems docbook warnings.

    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'name'
    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'mode'
    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'parent'
    Warning(linux-2.6.23-git8//fs/debugfs/file.c:241): No description found for parameter 'value'
    Warning(linux-2.6.23-git8//include/linux/jbd.h:404): No description found for parameter 'h_lockdep_map'

    Signed-off-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

13 Oct, 2007

1 commit

19 Jul, 2007

1 commit

  • a6bb340da   debugfs: remove rmdir() non-empty complaint ... Browse Code »

    Hi,

    This patch kills the pointless debugfs rmdir() printk() when called on a
    non-empty directory. blktrace will sometimes have to call it a few times
    when forcefully ending a trace, which polutes the log with pointless
    warnings.

    Rationale:

    - It's more code to work-around this "problem" in the debugfs users, and
    you would have to add code to check for empty directories to do so (or
    assume that debugfs is using simple_ helpers, but that would be a
    layering violation).

    - Other rmdir() implementations don't complain about something this
    silly.

    Signed-off-by: Jens Axboe
    Signed-off-by: Greg Kroah-Hartman

    Jens Axboe
     

12 Jul, 2007

1 commit

03 May, 2007

1 commit

28 Apr, 2007

1 commit

  • 8447891fe   debugfs: Add debugfs_create_u64() ... Browse Code »

    I went to use this the other day, only to find it didn't exist.

    It's a straight copy of the debugfs u32 code, then s/u32/u64/. A quick
    test shows it seems to be working.

    Signed-off-by: Michael Ellerman
    Signed-off-by: Greg Kroah-Hartman

    Michael Ellerman
     

17 Feb, 2007

2 commits

  • 873760fbf   debugfs: Remove misleading comments. ... Browse Code »

    Just mention which error will be returned if debugfs is disabled. Callers
    should be able to figure out themselves what they need to check.

    Signed-off-by: Cornelia Huck
    Signed-off-by: Greg Kroah-Hartman

    Cornelia Huck
     
  • 66f549639   debugfs: implement symbolic links ... Browse Code »

    debugfs: implement symbolic links

    Implement a new function debugfs_create_symlink() which can be used
    to create symbolic links in debugfs. This function can be useful
    for people moving functionality from /proc to debugfs (e.g. the
    gcov-kernel patch).

    Signed-off-by: Peter Oberparleiter
    Signed-off-by: Greg Kroah-Hartman

    Peter Oberparleiter
     

13 Feb, 2007

1 commit

  • 00977a59b   [PATCH] mark struct file_operations const 6 ... Browse Code »

    Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

14 Dec, 2006

5 commits

  • 29a7f3ada   DebugFS : file/directory removal fix ... Browse Code »

    Fix file and directory removal in debugfs. Add inotify support for file removal.

    The following scenario :
    create dir a
    create dir a/b

    cd a/b (some process goes in cwd a/b)

    rmdir a/b
    rmdir a

    fails due to the fact that "a" appears to be non empty. It is because
    the "b" dentry is not deleted from "a" and still in use. The same
    problem happens if "b" is a file. d_delete is nice enough to know when
    it needs to unhash and free the dentry if nothing else is using it or,
    if someone is using it, to remove it from the hash queues and wait for
    it to be deleted when it has no users.

    The nice side-effect of this fix is that it calls the file removal
    notification.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • 65c333367   DebugFS : more file/directory creation error handling ... Browse Code »

    Correct dentry count to handle creation errors.

    This patch puts a dput at the file creation instead of the file removal :
    lookup_one_len already returns a dentry with reference count of 1. Then,
    the dget() in simple_mknod increments it when the dentry is associated
    with a file. In a scenario where simple_create or simple_mkdir returns
    an error, this would lead to an unwanted increment of the reference
    counter, therefore making file removal impossible.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • 63223a065   DebugFS : file/directory creation error handling ... Browse Code »

    Fix error handling of file and directory creation in DebugFS.

    The error path should release the file system because no _remove will be called
    for this erroneous creation.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • bafb232ec   DebugFS : coding style fixes ... Browse Code »

    Minor coding style fixes along the way : 80 cols and a white space.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     
  • 4f36557fb   DebugFS : inotify create/mkdir support ... Browse Code »

    Add inotify create and mkdir events to DebugFS.

    Signed-off-by: Mathieu Desnoyers
    Signed-off-by: Greg Kroah-Hartman

    Mathieu Desnoyers
     

26 Nov, 2006

1 commit

17 Nov, 2006

1 commit

04 Oct, 2006

1 commit

01 Oct, 2006

1 commit

27 Sep, 2006

2 commits

  • ba52de123   [PATCH] inode-diet: Eliminate i_blksize from the inode structure ... Browse Code »

    This eliminates the i_blksize field from struct inode. Filesystems that want
    to provide a per-inode st_blksize can do so by providing their own getattr
    routine instead of using the generic_fillattr() function.

    Note that some filesystems were providing pretty much random (and incorrect)
    values for i_blksize.

    [bunk@stusta.de: cleanup]
    [akpm@osdl.org: generic_fillattr() fix]
    Signed-off-by: "Theodore Ts'o"
    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Theodore Ts'o
     
  • 8e18e2941   [PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private ... Browse Code »

    The following patches reduce the size of the VFS inode structure by 28 bytes
    on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
    in the inode size on a UP kernel that is configured in a production mode
    (i.e., with no spinlock or other debugging functions enabled; if you want to
    save memory taken up by in-core inodes, the first thing you should do is
    disable the debugging options; they are responsible for a huge amount of bloat
    in the VFS inode structure).

    This patch:

    The filesystem or device-specific pointer in the inode is inside a union,
    which is pretty pointless given that all 30+ users of this field have been
    using the void pointer. Get rid of the union and rename it to i_private, with
    a comment to explain who is allowed to use the void pointer. This is just a
    cleanup, but it allows us to reuse the union 'u' for something something where
    the union will actually be used.

    [judith@osdl.org: powerpc build fix]
    Signed-off-by: "Theodore Ts'o"
    Signed-off-by: Judith Lebzelter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Theodore Ts'o
     

26 Sep, 2006

1 commit

01 Jul, 2006

1 commit

25 Jun, 2006

1 commit