10 Feb, 2010
1 commit
09 Feb, 2010
3 commits
-
Test the value that was just allocated rather than the previously tested one.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@r@
expression *x;
expression e;
identifier l;
@@if (x == NULL || ...) {
... when forall
return ...; }
... when != goto l;
when != x = e
when != &x
*x == NULL
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller -
Verify the HW checksum state for frames handed to GRO processing.
Signed-off-by: Divy Le Ray
Signed-off-by: David S. Miller
06 Feb, 2010
4 commits
-
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller -
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller -
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller -
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
05 Feb, 2010
9 commits
-
Reported by Stephen Rothwell.
Signed-off-by: David S. Miller
-
Just reordering this assignment that doesn't depend on any
condition.Signed-off-by: Breno Leitao
Signed-off-by: Ron Mercer
Signed-off-by: David S. Miller -
Currently the qlge_change_mtu() is never called if the new_mtu is
equal current MTU, due this condition on dev_set_mtu():if (new_mtu == dev->mtu)
return 0;So, this block of code is never reached and is being removed.
Signed-off-by: Breno Leitao
Signed-off-by: Ron Mercer
Signed-off-by: David S. Miller -
Add periodic heartbeat register read to trigger the eeh
recovery process.
We see cases where an eeh error was injected and the slot was
suspended. An asic access attempt is required to flush the recovery process,
but without interrupts the process can stall.
Adding this periodic register read causes the recovery process to begin.Signed-off-by: Ron Mercer
Signed-off-by: David S. Miller -
Many drivers do this in them manually. Now they can use this function.
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller -
This change corrects an issue that will cause false hangs when using either
82575 or 82580 in legacy interrupt mode. The issue is caused when there is
a slow traffic flow and an "ethtool -r" is executed while using legacy or
MSI interrupts. MSI-X is not affected by this issue due to the fact that
we were already reconfiguring the vectors after reset.If possible it would be best to push this for net-2.6 since it is resolving
a bug but if that is not possible then net-next-2.6 will be fine.Signed-off-by: Alexander Duyck
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Signed-off-by: Giuseppe Cavallaro
Signed-off-by: David S. Miller -
Signed-off-by: Thadeu Lima de Souza Cascardo
Signed-off-by: David S. Miller
04 Feb, 2010
23 commits
-
Thanks for your patch. A more general solution would be to move the
rx_dropped up into sky2_receive.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
If receive buffer mapping failed, then it was possible to get
stuck with unmapped receive buffer in DMA ring.This would be an extremely rare condition because the driver had just
released the map for the last receive so it should be able to get
another map again (in soft-irq).Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
This patch addresses concerns about efficiency of handling incoming
packets. Handling of interrupts is done in a threaded interrupt handler
which has a smaller latency than workqueues. This change needed a rework
of the locking scheme that was much simplified. Some other (more or less
longstanding) bugs are fixed: utilization of just half of the RX
buffers, useless wait for interrupt on open, more reliable reset
sequence. The MERR interrupt is not used anymore: it overloads the CPU
in error-passive state without any additional information. One shot mode
is disabled because it's not clear if it can be handled efficiently on
this CAN controller.Signed-off-by: Christian Pellegrin
Acked-by: Wolfgang Grandegger
Signed-off-by: David S. Miller -
There is no need to maintain stats in the bonding structure.
Use the instance of net_device_stats in netdevice.Signed-off-by: Ajit Khaparde
Signed-off-by: Jay Vosburgh
Signed-off-by: David S. Miller -
String constants that are continued on subsequent lines with \
are not good.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
Signed-off-by: Thadeu Lima de Souza Cascardo
Signed-off-by: David S. Miller -
In order to use macvlan with qemu and other tools that require
a tap file descriptor, the macvtap driver adds a small backend
with a character device with the same interface as the tun
driver, with a minimum set of features.Macvtap interfaces are created in the same way as macvlan
interfaces using ip link, but the netif is just used as a
handle for configuration and accounting, while the data
goes through the chardev. Each macvtap interface has its
own character device, simplifying permission management
significantly over the generic tun/tap driver.Cc: Patrick McHardy
Cc: Stephen Hemminger
Cc: David S. Miller"
Cc: "Michael S. Tsirkin"
Cc: Herbert Xu
Cc: Or Gerlitz
Cc: netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Arnd Bergmann
Signed-off-by: David S. Miller -
This makes it possible to hook into the macvlan driver
from another kernel module. In particular, the goal is
to extend it with the macvtap backend that provides
a tun/tap compatible interface directly on the macvlan
device.Signed-off-by: Arnd Bergmann
Signed-off-by: David S. Miller -
In the vlan and macvlan drivers, the start_xmit function forwards
data to the dev_queue_xmit function for another device, which may
potentially belong to a different namespace.To make sure that classification stays within a single namespace,
this resets the potentially critical fields.Signed-off-by: Arnd Bergmann
Signed-off-by: David S. Miller -
The error return should be negative. Its only caller that acts upon its
return, handle_bmsg(), transmits the positive error but can also return
negative errors.Signed-off-by: Roel Kluin
Cc: Karsten Keil
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
Remove these compiler warnings:
drivers/isdn/hardware/mISDN/w6692.c:534: warning: `setvolume' defined but not used
drivers/isdn/hardware/mISDN/w6692.c:561: warning: `enable_pots' defined but not usedby moving the functions inside #if 0 ... #endif. And an alternative is
to remove them completely if nobody has plans to use them.Signed-off-by: Jiri Slaby
Cc: Karsten Keil
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
If setup_instance() fails we kfree() the card, and then use it in the next
loop iteration. So lets bail out of the loop instead.Coverity CID: 13357
Signed-off-by: Darren Jenkins
Cc: Karsten Keil
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
With `while (timeout++ < maxdelay)' timeout reaches maxdelay + 1 after the
loop This is probably unlikely a problem in practice.Signed-off-by: Roel Kluin
Cc: Karsten Keil
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
Fix crash where resources are freed twice on an eeh recovery failure.
If eeh recovery fails we set a flag to indicate to close() that
resources have been freed.Signed-off-by: Ron Mercer
Signed-off-by: David S. Miller -
Issue asic reset and verify functionality before continuing to the
resume call. This allows proper error code to be returned in the case
the asic does not recover.Signed-off-by: Ron Mercer
Signed-off-by: David S. Miller -
This patch allocates the ring structures themselves on each
NUMA node along with the buffer_info structures. This way we
don't allocate the entire ring memory on a single node in one
big block, thus reducing NUMA node memory crosstalk.Signed-off-by: Peter P Waskiewicz Jr
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
The default policy for the current driver is to do all its memory
allocation on whatever processor is running insmod/modprobe. This
is less than optimal.This driver's default mode of operation will be to use each node for each
subsequent transmit/receive queue. The most efficient allocation will be
to then have the interrupts bound in such a way as to match up the
interrupt of the queue to the cpu where its memory was allocated.Signed-off-by: Jesse Brandeburg
Signed-off-by: Peter P Waskiewicz Jr
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
This patch adds a call to pci_save_state() immediately after
the call to pci_restore_state(). Due to a change in the behavior
of pci_restore_state() it is necessary to call pci_save_state()
to keep the state_saved flag. This patch is based on a similar
patch for ixgbe.Signed-off-by: Nicholas Nunley
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
With this change ethtool will correctly report link status when
the interface is down. Currently ethtool reports the link as not
detected when the interface is down.Signed-off-by: Nicholas Nunley
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Processing multiple ixgbe_watchdog_task calls may cause
the link_up variable and IXGBE_FLAG_NEED_LINK_UPDATE flag
to be set incorrectly. In the worse case this is causing
the netif_carrier_off to be called inappropriately which
results in an interface that can't be brought up.Although schedule_work() will only schedule the task if
it is not already on the work queue the WORK_STRUCT_PENDING
bits are cleared just before calling the work function.
This allows WORK_STRUCT_PENDING to be cleared, the work
function to start and meanwhile schedule another task.This patch adds a mutex to the watchdog task. This bug is
actualized by changing DCB settings or doing extended
cable pull or reset tests.Signed-off-by: John Fastabend
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
a developer had complained of getting lots of warnings:
"eth16 selects TX queue 98, but real number of TX queues is 64"
http://www.mail-archive.com/e1000-devel@lists.sourceforge.net/msg02200.html
As there was no follow up on that bug, I am submitting this
patch assuming that the other return points will not return
invalid txq's, and also that this fixes the bug (not tested).Signed-off-by: Krishna Kumar
Signed-off-by: Jesse Brandeburg
Acked-by: Peter P Waskiewicz Jr
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Commit e5a43549f7a58509a91b299a51337d386697b92c (ixgbe: remove
skb_dma_map/unmap calls from driver) looks to have introduced a bug in
ixgbe_tx_map. If we get an error from a PCI DMA call, we loop backwards
through count until it becomes -1 and return that.The caller of ixgbe_tx_map expects 0 on error, so return that instead.
Signed-off-by: Anton Blanchard
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller
