10 Jun, 2011
2 commits
-
Conflicts:
net/bluetooth/rfcomm/sock.c -
Signed-off-by: David S. Miller
Signed-off-by: Gustavo F. Padovan
08 Jun, 2011
9 commits
-
Signed-off-by: Mohammed Shafi Shajakhan
Signed-off-by: John W. Linville -
Padding per MSDU will affect the length of next packet and hence
the exact length of next packet is uncertain here.Also, aggregation of transmission buffer, while downloading the
data to the card, wont gain much on the AMSDU packets as the AMSDU
packets utilizes the transmission buffer space to the maximum
(adapter->tx_buf_size).Signed-off-by: Yogesh Ashok Powar
Signed-off-by: John W. Linville -
All MSDUs, except the last one in an AMSDU, should end up at 4
bytes boundary. There is need to check if enough skb_tailroom
space exists before padding the skb.Also re-arranging code for better readablity.
Signed-off-by: Yogesh Ashok Powar
Signed-off-by: John W. Linville -
The check of skb list empty before calling skb_peek and skb_dequeue is
redundant. These functions returns NULL if the list is empty.Signed-off-by: Yogesh Ashok Powar
Signed-off-by: John W. Linville -
Instead of counting the number of packets in txq
for particular RA list before AMSDU creation,
maintain a counter which will keep track of the
same.This will reduce some MIPS while generating AMSDU
traffic as we only have to check the counter instead
of traversing through skb list.Signed-off-by: Yogesh Ashok Powar
Signed-off-by: John W. Linville -
the code always returns ret regardless, so if(ret) check is unecessary.
Signed-off-by: Greg Dietsche
Signed-off-by: John W. Linville -
Use less indentions and remove uneeded irq-save flags.
Signed-off-by: Stanislaw Gruszka
Acked-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
Adding new event that close RX BA session in case of periodic BT activity
limiting WLAN activity.Signed-off-by: Shahar Levi
Signed-off-by: John W. Linville
07 Jun, 2011
3 commits
-
Setting tx power can be deferred during scan or changing channel.
If after that correct tx power settings will not be sent to device,
we can observe transmission problems and timeouts. Force to send
tx power settings also after partial rxon change, to assure device
always be configured with up-to-date settings.Resolves:
https://bugzilla.kernel.org/show_bug.cgi?id=36492Cc: stable@kernel.org # 2.6.39+
Signed-off-by: Stanislaw Gruszka
Signed-off-by: John W. Linville -
Avoid queue and run autowakeup_work when device is not present anymore.
That prevent rmmod and device remove crash introduced by:commit 1c0bcf89d85cc97a0d9ce4cd909351a81fa4fdde
Author: Ivo van Doorn
Date: Sat Apr 30 17:18:18 2011 +0200rt2x00: Add autowake support for USB hardware
Signed-off-by: Stanislaw Gruszka
Acked-by: Ivo van Doorn
Signed-off-by: John W. Linville -
This patch fixes 802.11n stability and performance regression we have
since 2.6.35. It boost performance on my 5GHz N-only network from about
5MB/s to 8MB/s. Similar percentage boost can be observed on 2.4 GHz.These are test results of 5x downloading of approximately 700MB iso
image:vanilla: 5.27 5.22 4.94 4.47 5.31 ; avr 5.0420 std 0.35110
patched: 8.07 7.95 8.06 7.99 7.96 ; avr 8.0060 std 0.055946This was achieved with NetworkManager configured to do not perform
periodical scans, by configuring constant BSSID. With periodical scans,
after some time, performance downgrade to unpatched driver level, like
in example below:patched: 7.40 7.61 4.28 4.37 4.80 avr 5.6920 std 1.6683
However patch still make better here, since similar test on unpatched
driver make link disconnects with below messages after some time:wlan1: authenticate with 00:23:69:35:d1:3f (try 1)
wlan1: authenticate with 00:23:69:35:d1:3f (try 2)
wlan1: authenticate with 00:23:69:35:d1:3f (try 3)
wlan1: authentication with 00:23:69:35:d1:3f timed outOn 2.6.35 kernel patch helps against connection hangs with messages:
iwlagn 0000:20:00.0: queue 10 stuck 3 time. Fw reload.
iwlagn 0000:20:00.0: On demand firmware reload
iwlagn 0000:20:00.0: Stopping AGG while state not ON or startingCc: stable@kernel.org # 2.6.35+
Signed-off-by: Stanislaw Gruszka
Acked-by: Wey-Yi Guy
Signed-off-by: John W. Linville
04 Jun, 2011
26 commits
-
No need to go though multiple levels of indirect call to send RXON command.
Call it directlySigned-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
After driver split, no need to use function "ops" for post_scan.
Signed-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
Both tx power and power save are being done after scan complete, move into
post_scan functionSigned-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
For some timing reason, 1000 device having problem to kick-in to aggregation
without sending rxon assoc command. This is a W/A until find the real reasonSigned-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
When change smps mode due to bt coex, save it
Signed-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
lq_sta has other null checks in this function.
assuming they are correct, this additional null check
should be added too.Incorporating suggestion from Gustavo Padovan.
Signed-off-by: Greg Dietsche
Signed-off-by: John W. Linville -
propogate the return value from iwl4965_get_tx_atten_grp instead
of implicitly returning -EINVAL in the error case.Signed-off-by: Greg Dietsche
Signed-off-by: John W. Linville -
Cleanup the code to return -EINVAL instead of -1
Signed-off-by: Greg Dietsche
Signed-off-by: John W. Linville -
the code always returns ret regardless, so if(ret) check is unecessary.
Signed-off-by: Greg Dietsche
Signed-off-by: John W. Linville -
return; at the end of the function is unecessary.
Signed-off-by: Greg Dietsche
Signed-off-by: John W. Linville -
Signed-off-by: Rafał Miłecki
Signed-off-by: John W. Linville -
It does nothing useful yet, so it is matched as BROKEN.
For now this is just an option for b43, in future we may want to make
b43 support SSB or BCMA (note: or, not xor).Signed-off-by: Rafał Miłecki
Signed-off-by: John W. Linville -
In case of BCMA cards SPROM is located in the ChipCommon core, it is
not mapped as separated host window. So far we have met only SPROMs rev
8.
SPROM layout seems to be the same as for SSB buses, so we decided to
share SPROM struct and some defines.
For now we extract MAC address only, this can be improved of course.Signed-off-by: Rafał Miłecki
Signed-off-by: John W. Linville -
Luckily the only flag we use when calling core reset is GMODE one.
Thanks to that we can just switch to single bool and make function calls
bus generic.Tested on my BCM4312 (LP-PHY) and early tested with BCM43224.
Signed-off-by: Rafał Miłecki
Signed-off-by: John W. Linville -
Signed-off-by: Felix Fietkau
Signed-off-by: John W. Linville -
Should pass along packet if there's no CRC and no hardware error.
Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
Make sure all updates to a descriptor are flushed to memory
before assigning ownship to hardware.Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
Ownership of an rx buffer should only be given to the hardware
after all other changes are written, otherwise there's
a potential race.Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
Now power state transitions are not called from an
interrupt context, there's no need to block interrupts.This code appears to block interrupts for too long,
causing my trackpad to lose sync occasionally.Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
This removes the need to use IRQ safe spinlocks in many places.
Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
_rtl_pci_rx_interrupt uses rtlpci->rx_ring[rx_queue_idx].idx a
few times, so store it in a separate variable.Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
set_rfpowerstate_inprogress is only set and never read
so remove it.Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
This make sure any IRQ handlers running on other CPUs complete.
Signed-off-by: Mike McCormack
Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
Commit 06e8935febe687e2a561707d4c7ca4245d261dbe adds an IRQ handling
optimization for single-function SDIO cards like this one, but at the
same time exposes a small hardware bug.During hardware init, an interrupt is generated with (apparently) no
source. Previously, mmc threw this interrupt away, but now (due to the
optimization), the mmc layer passes this onto libertas, before it is ready
(and before it has enabled interrupts), causing a crash.Work around this hardware bug by registering the IRQ handler later and
making it capable of handling interrupts with no cause. The change that
makes the IRQ handler registration happen later actually eliminates
the spurious interrupt as well.Signed-off-by: Daniel Drake
Signed-off-by: John W. Linville -
We use priv->mutex to avoid race conditions between iwl_chswitch_done()
and iwlagn_mac_channel_switch(), when marking channel switch in
progress. But iwl_chswitch_done() can be called in atomic context
from iwl_rx_csa() or with mutex already taken from iwlagn_commit_rxon().These bugs were introduced by:
commit 79d07325502e73508f917475bc1617b60979dd94
Author: Wey-Yi Guy
Date: Thu May 6 08:54:11 2010 -0700iwlwifi: support channel switch offload in driver
To fix remove mutex from iwl_chswitch_done() and use atomic bitops for
marking channel switch pending.Also remove iwl2030_hw_channel_switch() since 2000 series adapters are
2.4GHz only devices.Cc: stable@kernel.org # 2.6.36+
Signed-off-by: Stanislaw Gruszka
Acked-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
Disable fast channel change by default on AR2413/AR5413 due to
some bug reports (it still works for me but it's better to be safe).
Add a module parameter "fastchanswitch" in case anyone wants to enable
it and play with it.Signed-off-by: Nick Kossifidis
Tested-by: Sedat Dilek
Signed-off-by: John W. Linville
