16 Jan, 2020
1 commit
-
Check for valid packet type before calling hci_recv_frame which is
inline with what other drivers are doing.Signed-off-by: Luiz Augusto von Dentz
Signed-off-by: Marcel Holtmann
06 Jul, 2019
1 commit
-
BCM4356 devices soldered onto the PCB (non-removable) use an UART
connection for bluetooth, such as the Rock960, but it also advertise
btsdio support as a sdio function.Signed-off-by: Peter Robinson
CC: Manivannan Sadhasivam
Signed-off-by: Marcel Holtmann
31 May, 2019
1 commit
-
Based on 1 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license as published by
the free software foundation either version 2 of the license or at
your option any later version this program is distributed in the
hope that it will be useful but without any warranty without even
the implied warranty of merchantability or fitness for a particular
purpose see the gnu general public license for more details you
should have received a copy of the gnu general public license along
with this program if not write to the free software foundation inc
59 temple place suite 330 boston ma 02111 1307 usaextracted by the scancode license scanner the SPDX license identifier
GPL-2.0-or-later
has been chosen to replace the boilerplate/reference in 1334 file(s).
Signed-off-by: Thomas Gleixner
Reviewed-by: Allison Randal
Reviewed-by: Richard Fontana
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.de
Signed-off-by: Greg Kroah-Hartman
24 Apr, 2019
1 commit
-
Macro module_sdio_driver is used for drivers whose init and exit paths
only register and unregister to SDIO API. So remove boilerplate code to
make code simpler by using module_sdio_driver.Signed-off-by: Sean Wang
Acked-by: Ulf Hansson
Signed-off-by: Marcel Holtmann
14 Oct, 2018
1 commit
-
BCM43430 devices soldered onto the PCB (non-removable)
use an UART connection for bluetooth.
But also advertise btsdio support on their 3th sdio function.Signed-off-by: Cho, Yu-Chen
Signed-off-by: Marcel Holtmann
13 Dec, 2017
1 commit
-
BCM43341 devices soldered onto the PCB (non-removable) always (AFAICT)
use an UART connection for bluetooth. But they also advertise btsdio
support on their 3th sdio function, this causes 2 problems:1) A non functioning BT HCI getting registered
2) Since the btsdio driver does not have suspend/resume callbacks,
mmc_sdio_pre_suspend will return -ENOSYS, causing mmc_pm_notify()
to react as if the SDIO-card is removed and since the slot is
marked as non-removable it will never get detected as inserted again.
Which results in wifi no longer working after a suspend/resume.This commit fixes both by making btsdio ignore BCM43341 devices
when connected to a slot which is marked non-removable.Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede
Signed-off-by: Marcel Holtmann
22 Jul, 2017
1 commit
-
Fixed alignment of all block comments.
Found using checkpatchSigned-off-by: Derek Robson
Signed-off-by: Marcel Holtmann
10 Jul, 2016
1 commit
-
The HCI_BREDR naming is confusing since it actually stands for Primary
Bluetooth Controller. Which is a term that has been used in the latest
standard. However from a legacy point of view there only really have
been Basic Rate (BR) and Enhanced Data Rate (EDR). Recent versions of
Bluetooth introduced Low Energy (LE) and made this terminology a little
bit confused since Dual Mode Controllers include BR/EDR and LE. To
simplify this the name HCI_PRIMARY stands for the Primary Controller
which can be a single mode or dual mode controller.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
20 Nov, 2015
1 commit
-
The new hci_skb_pkt_* wrappers are mainly intented for drivers to
require less knowledge about bt_cb(sbk) handling. So after converting
the core packet handling, convert all drivers.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
05 Oct, 2015
2 commits
-
Setting and clearing of HCI_RUNNING flag in each and every driver is
just duplicating the same code all over the place. So instead of having
the driver do it in their hdev->open and hdev->close callbacks, set it
globally in the core transport handling.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg -
In all callbacks for hdev->send the status of HCI_RUNNING is checked. So
instead of repeating that code in every driver, move the check into the
hci_send_frame function before calling hdev->send.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
30 Dec, 2013
1 commit
-
The register for setting the SDIO card mode of a Type-B Bluetooth card
is called MD SET. The MD STAT register is used for reading the current
mode back.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
24 Dec, 2013
1 commit
-
The Socket Bluetooth SDIO cards are branded versions of Toshiba SD-BT2
and they do not support sending HCI_Reset as first command. To make
this card work the HCI_QUIRK_RESET_ON_CLOSE quirk needs to be set
before registering the controller.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
11 Oct, 2013
2 commits
-
Instead of masking hdev inside the skb->dev parameter, hand it
directly to the driver as a parameter to hdev->send. This makes
the driver interface more clear and simpler.This patch fixes all drivers to accept and handle the new parameter
of hdev->send callback. Special care has been taken for bpa10x
and btusb drivers that require having skb->dev set to hdev for
the URB transmit complete handlers.Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg -
To avoid casting skb->dev into hdev, just let the drivers provide
the hdev directly when calling hci_recv_frame() function.This patch also fixes up all drivers to provide the hdev.
Signed-off-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
07 Aug, 2012
1 commit
-
devm_kzalloc() eliminates the need to free memory explicitly
thereby saving some cleanup code.Signed-off-by: Sachin Kamat
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo Padovan
13 Feb, 2012
3 commits
-
The linux device model provides dev_set/get_drvdata so we can use this
to save private driver data.
This also removes several unnecessary casts.Signed-off-by: David Herrmann
Acked-by: Marcel Holtmann
Signed-off-by: Johan Hedberg -
After unregistering an hci_dev object a bluetooth driver does not have
any callbacks in the hci_dev structure left over. Therefore, there is no
need to keep a reference to the module.Previously, we needed this to protect the hci-destruct callback.
However, this callback is no longer available so we do not need this
owner field, anymore. Drivers now call hci_unregister_dev() and they
are done with the object.Signed-off-by: David Herrmann
Acked-by: Marcel Holtmann
Signed-off-by: Johan Hedberg -
Instead of waiting for the hdev object to get freed we now free the
private driver-internal data on SDIO shutdown. This allows us to remove
the obsolete hci-destruct callback and free our data object right away
after calling hci_unregister_dev(). The HCI-core does not call any
callbacks after this so we are never called again and can safely exit
the module.Signed-off-by: David Herrmann
Acked-by: Marcel Holtmann
Signed-off-by: Johan Hedberg
12 Oct, 2010
1 commit
-
Signed-off-by: David Vrabel
Signed-off-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
27 Feb, 2010
1 commit
-
The hdev->type is misnamed and should be actually hdev->bus instead. So
convert it now.Signed-off-by: Marcel Holtmann
30 Nov, 2008
2 commits
-
With the introduction of CONFIG_DYNAMIC_PRINTK_DEBUG it is possible to
allow debugging without having to recompile the kernel. This patch turns
all BT_DBG() calls into pr_debug() to support dynamic debug messages.As a side effect all CONFIG_BT_*_DEBUG statements are now removed and
some broken debug entries have been fixed.Signed-off-by: Marcel Holtmann
-
This patch fixes accumulating of the header in case packet was requeued
in the error path.Signed-off-by: Tomas Winkler
Signed-off-by: Marcel Holtmann
27 Oct, 2008
1 commit
-
free sk_buff with kfree_skb, instead of kree
Signed-off-by: Sergio Luis
Signed-off-by: David S. Miller
05 Feb, 2008
1 commit
-
This patch fixes a double-free spotted by the Coverity checker.
Signed-off-by: Adrian Bunk
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
22 Oct, 2007
1 commit
-
This patch adds a generic driver for Bluetooth SDIO devices. It
supports Type-A and Type-B devices.Signed-off-by: David Vrabel
Signed-off-by: Marcel Holtmann