03 Mar, 2015

1 commit

  • kbuild found out that commit 804e27dee49e ("bcma: support bringing up
    bus hosted on PCIe Gen 2") broke the build on m68k:

    drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up':
    >> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\
    =implicit-function-declaration]
    err = pcie_set_readrq(dev, pcie2->reqsize);
    ^
    cc1: some warnings being treated as errors

    Reported-by: kbuild test robot
    Signed-off-by: Rafał Miłecki
    Signed-off-by: Kalle Valo

    Rafał Miłecki
     

12 Nov, 2014

1 commit


27 Aug, 2013

1 commit

  • This PCIe controller does not support a max read request size above 128
    bytes. The sold card I tested this controller with used 128 as default
    value, but some new routers are sold with BCM4331 chips, which have a
    default max read request size of 512. This device fails at the first
    DMA reqeust whch is bigger than 126 bytes.

    This patch changes the max read request size to 128 for every device on
    the PCIe link.

    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     

02 Mar, 2013

1 commit


28 Feb, 2013

1 commit


29 Jan, 2013

1 commit


15 Jan, 2013

5 commits


12 Jan, 2013

2 commits


04 Jan, 2013

1 commit

  • CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, and __devexit
    from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: "Rafał Miłecki"
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

01 Dec, 2012

1 commit

  • This fixes the following warning:

    CC drivers/bcma/driver_pci_host.o
    drivers/bcma/driver_pci_host.c: In function 'bcma_core_pci_fixup_addresses':
    drivers/bcma/driver_pci_host.c:555:23: error: ignoring return value of
    'pci_assign_resource', declared with attribute warn_unused_result
    [-Werror=unused-result]

    Reported-by: Arend van Spriel
    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     

20 Oct, 2012

2 commits

  • Before it was tried to initialize the deactivated PCIe core in client
    mode, but this causes the SoC to hang. Just do not initialize it at all
    and ignore the core it is not working and nothing is connected to it
    when the specific bit is set in the boardflags.

    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     
  • The BCM4706 has two PCIe host controller on the bcma bus. For PCIe
    client mode it is assumed that there is only one PCIe controller so the
    PCIe driver, like b43 and brcmsmac are accessing the first PCIe
    controller when they want to issue a operation on the host controller.

    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     

29 Sep, 2012

1 commit


10 Jul, 2012

2 commits

  • Having bus number printed makes it much easier to anaylze logs on
    systems with more buses. For example Netgear WNDR4500 has 3 AMBA buses
    in total, which makes standard log really messy.

    Signed-off-by: Rafał Miłecki
    Signed-off-by: John W. Linville

    Rafał Miłecki
     
  • The chip IDs are used all over bcma and no constants where defined.
    This patch adds the constants and makes bcma use them.

    Acked-by: Arend van Spriel
    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     

17 May, 2012

2 commits


11 Apr, 2012

1 commit

  • The following is seen during allmodconfig builds for MIPS:

    drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
    of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1

    Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf

    "bcma: add PCIe host controller"

    Add the header instead of implicitly assuming it will be present.
    Sounds like a good idea, but that alone doesn't fix anything.

    The real problem is that the Kconfig has settings related to whether
    PCI is possible, i.e.

    config BCMA_HOST_PCI_POSSIBLE
    bool
    depends on BCMA && PCI = y
    default y

    config BCMA_HOST_PCI
    bool "Support for BCMA on PCI-host bus"
    depends on BCMA_HOST_PCI_POSSIBLE

    ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
    have any dependencies on the above. Add one.

    CC: Hauke Mehrtens
    CC: John W. Linville
    Signed-off-by: Paul Gortmaker
    Acked-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Paul Gortmaker
     

07 Feb, 2012

2 commits

  • Some SoCs have a PCIe host controller to make it possible to attach
    some other devices to it, like an other Wifi card.
    This code was tested with an Netgear WNDR3400 (bcm4716 based), but
    should work with all bcma based SoCs.

    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     
  • bcma_core_pci_hostmode_init() has to be in __devinit as it will call a
    function in that section and so all functions calling it also have to
    be in __devinit.

    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     

08 Jul, 2011

1 commit